| Message ID | 1f7606d932bd480bca466181658e656f93c4fe9e.1498919458.git.yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
Hi Yann, 2017-07-01 16:31 GMT+02:00 Yann E. MORIN <yann.morin.1998@free.fr>: > Move it to the top-level tools/ directory, so that it is easier to > find for users. > > Add a legacy symlink for those users who already used them, so as > not to break their habits. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > Cc: Arnout Vandecappelle <arnout@mind.be> > > --- > Changes v3 -> v4: > - drop legacy symlink (Arnout, Thomas) > --- > tools/readme.txt | 6 ++++++ > {support/scripts => tools}/size-stats-compare | 0 > 2 files changed, 6 insertions(+) > rename {support/scripts => tools}/size-stats-compare (100%) > > diff --git a/tools/readme.txt b/tools/readme.txt > index fc1108fded..dd8a1d4494 100644 > --- a/tools/readme.txt > +++ b/tools/readme.txt > @@ -11,6 +11,12 @@ get-developpers > of Buildroot, so they can be Cc:ed on a mail. Accepts a patch as > input, a package name or and architecture name. > > +size-stat-compare > + a script to compare the rootfs size between two differnt Buildroot You must have missed my comment about 'differnt' -> 'different' > + configurations. This can be used to identify the size impact of > + a specific option, or of a set of specific options, or an update > + to a newer Buildroot version... While you're at it, the last clause would either also need 'of': 'or of an update...', or otherwise it would need to be removed on the second clause, but now it is inconsistent. Thanks, Thomas
Hello, On Sat, 1 Jul 2017 18:02:57 +0200, Thomas De Schampheleire wrote: > > diff --git a/tools/readme.txt b/tools/readme.txt > > index fc1108fded..dd8a1d4494 100644 > > --- a/tools/readme.txt > > +++ b/tools/readme.txt > > @@ -11,6 +11,12 @@ get-developpers > > of Buildroot, so they can be Cc:ed on a mail. Accepts a patch as > > input, a package name or and architecture name. > > > > +size-stat-compare > > + a script to compare the rootfs size between two differnt Buildroot > > You must have missed my comment about 'differnt' -> 'different' > > > + configurations. This can be used to identify the size impact of > > + a specific option, or of a set of specific options, or an update > > + to a newer Buildroot version... > > While you're at it, the last clause would either also need 'of': 'or > of an update...', > or otherwise it would need to be removed on the second clause, but now > it is inconsistent. Sorry, I have already pushed. Can you send a patch? :-) Thomas
Thomas, All, On 2017-07-01 18:02 +0200, Thomas De Schampheleire spake thusly: > 2017-07-01 16:31 GMT+02:00 Yann E. MORIN <yann.morin.1998@free.fr>: > > Move it to the top-level tools/ directory, so that it is easier to > > find for users. > > > > Add a legacy symlink for those users who already used them, so as > > not to break their habits. > > > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > > Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> > > Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> > > Cc: Arnout Vandecappelle <arnout@mind.be> > > > > --- > > Changes v3 -> v4: > > - drop legacy symlink (Arnout, Thomas) > > --- > > tools/readme.txt | 6 ++++++ > > {support/scripts => tools}/size-stats-compare | 0 > > 2 files changed, 6 insertions(+) > > rename {support/scripts => tools}/size-stats-compare (100%) > > > > diff --git a/tools/readme.txt b/tools/readme.txt > > index fc1108fded..dd8a1d4494 100644 > > --- a/tools/readme.txt > > +++ b/tools/readme.txt > > @@ -11,6 +11,12 @@ get-developpers > > of Buildroot, so they can be Cc:ed on a mail. Accepts a patch as > > input, a package name or and architecture name. > > > > +size-stat-compare > > + a script to compare the rootfs size between two differnt Buildroot > > You must have missed my comment about 'differnt' -> 'different' Damn, I forgot it. And Thomas already applied it... Sorry.. > > + configurations. This can be used to identify the size impact of > > + a specific option, or of a set of specific options, or an update > > + to a newer Buildroot version... > > While you're at it, the last clause would either also need 'of': 'or > of an update...', > or otherwise it would need to be removed on the second clause, but now > it is inconsistent. I'm not sure I follow you... Regards, Yann E. MORIN. > Thanks, > Thomas
diff --git a/tools/readme.txt b/tools/readme.txt index fc1108fded..dd8a1d4494 100644 --- a/tools/readme.txt +++ b/tools/readme.txt @@ -11,6 +11,12 @@ get-developpers of Buildroot, so they can be Cc:ed on a mail. Accepts a patch as input, a package name or and architecture name. +size-stat-compare + a script to compare the rootfs size between two differnt Buildroot + configurations. This can be used to identify the size impact of + a specific option, or of a set of specific options, or an update + to a newer Buildroot version... + test-pkg a script that tests a specific package against a set of various toolchains, with the goal to detect toolchain-related dependencies diff --git a/support/scripts/size-stats-compare b/tools/size-stats-compare similarity index 100% rename from support/scripts/size-stats-compare rename to tools/size-stats-compare
Move it to the top-level tools/ directory, so that it is easier to find for users. Add a legacy symlink for those users who already used them, so as not to break their habits. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Thomas De Schampheleire <patrickdepinguin@gmail.com> Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Cc: Arnout Vandecappelle <arnout@mind.be> --- Changes v3 -> v4: - drop legacy symlink (Arnout, Thomas) --- tools/readme.txt | 6 ++++++ {support/scripts => tools}/size-stats-compare | 0 2 files changed, 6 insertions(+) rename {support/scripts => tools}/size-stats-compare (100%)