diff mbox series

[v2,4/6] testing/infra/basetest: support br2-external

Message ID 1542426982-54683-4-git-send-email-matthew.weber@rockwellcollins.com
State Superseded
Headers show
Series [v2,1/6] package/compiler-rt: new package | expand

Commit Message

Matt Weber Nov. 17, 2018, 3:56 a.m. UTC 
From: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>

This change will be needed when adding a common class to test the git
download infra.

Signed-off-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
Cc: Arnout Vandecappelle <arnout@mind.be>
Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
---
Changes
v2
 - New from: http://patchwork.ozlabs.org/patch/912354/
---
 support/testing/infra/basetest.py | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Ricardo Martincoski Nov. 18, 2018, 9:41 p.m. UTC | #1 
Hello,

Another nit that can be fixed while applying.

On Sat, Nov 17, 2018 at 01:56 AM, Matt Weber wrote:

> From: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
> 

> This change will be needed when adding a common class to test the git
> download infra.

Just like in patch 3, this is not untrue.
But in the context of your series, perhaps it could be replaced by:
"
Some upcoming test cases can use one or more br2-external trees as
fixtures that provide packages used only in runtime tests.

Add support for br2-external into the BRTest class. Any test case can
then provide a list of paths for be used as br2-external trees during
the build of the image to be tested.
"
And who applies it could even tweak this to a better phrase.

> 
> Signed-off-by: Ricardo Martincoski <ricardo.martincoski@datacom.ind.br>
> Cc: Arnout Vandecappelle <arnout@mind.be>
> Signed-off-by: Matt Weber <matthew.weber@rockwellcollins.com>
> ---

I reviewed it and the contents are OK.


Regards,
Ricardo
diff mbox series

Patch

diff --git a/support/testing/infra/basetest.py b/support/testing/infra/basetest.py
index 5014fef..8413943 100644
--- a/support/testing/infra/basetest.py
+++ b/support/testing/infra/basetest.py
@@ -30,6 +30,7 @@  MINIMAL_CONFIG = \
 
 class BRTest(unittest.TestCase):
     config = None
+    br2_external = list()
     downloaddir = None
     outputdir = None
     logtofile = True
@@ -58,7 +59,7 @@  class BRTest(unittest.TestCase):
 
         if not self.b.is_finished():
             self.show_msg("Building")
-            self.b.configure()
+            self.b.configure(["BR2_EXTERNAL={}".format(":".join(self.br2_external))])
             self.b.build()
             self.show_msg("Building done")