diff mbox series

[v2,6/6] llvm/clang: add note about version bumping together

Message ID 1542426982-54683-6-git-send-email-matthew.weber@rockwellcollins.com
State Superseded
Headers show
Series [v2,1/6] package/compiler-rt: new package | expand

Commit Message

Matt Weber Nov. 17, 2018, 3:56 a.m. UTC 
Signed-off-by: Matthew Weber <matthew.weber@rockwellcollins.com>
Acked-by: Romain Naour <romain.naour@smile.fr>
---
Changes
v1 -> v2
 - None
---
 package/clang/clang.mk | 1 +
 package/llvm/llvm.mk   | 1 +
 2 files changed, 2 insertions(+)

Comments

Ricardo Martincoski Nov. 18, 2018, 9:53 p.m. UTC | #1 
Hello,

Here again, the changes could be made while applying.
But please double-check, maybe I missed something.

On Sat, Nov 17, 2018 at 01:56 AM, Matt Weber wrote:

[snip]
> +++ b/package/clang/clang.mk
> @@ -4,6 +4,7 @@
>  #
>  ################################################################################
>  
> +# LLVM and Clang should be version bumped together

As I replied to patch 1, shouldn't compiler-rt be added to this list?

>  CLANG_VERSION = 7.0.0
>  CLANG_SITE = http://llvm.org/releases/$(CLANG_VERSION)
>  CLANG_SOURCE = cfe-$(CLANG_VERSION).src.tar.xz
> diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
> index 79477f0..56f6ed9 100644
> --- a/package/llvm/llvm.mk
> +++ b/package/llvm/llvm.mk
> @@ -4,6 +4,7 @@
>  #
>  ################################################################################
>  
> +# LLVM and Clang should be version bumped together

Same here.


Regards,
Ricardo
diff mbox series

Patch

diff --git a/package/clang/clang.mk b/package/clang/clang.mk
index f9d4ae3..16f93ee 100644
--- a/package/clang/clang.mk
+++ b/package/clang/clang.mk
@@ -4,6 +4,7 @@ 
 #
 ################################################################################
 
+# LLVM and Clang should be version bumped together
 CLANG_VERSION = 7.0.0
 CLANG_SITE = http://llvm.org/releases/$(CLANG_VERSION)
 CLANG_SOURCE = cfe-$(CLANG_VERSION).src.tar.xz
diff --git a/package/llvm/llvm.mk b/package/llvm/llvm.mk
index 79477f0..56f6ed9 100644
--- a/package/llvm/llvm.mk
+++ b/package/llvm/llvm.mk
@@ -4,6 +4,7 @@ 
 #
 ################################################################################
 
+# LLVM and Clang should be version bumped together
 LLVM_VERSION = 7.0.0
 LLVM_SITE = http://llvm.org/releases/$(LLVM_VERSION)
 LLVM_SOURCE = llvm-$(LLVM_VERSION).src.tar.xz