| Message ID | 1513780359-3685-1-git-send-email-fhunleth@troodon-software.com |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3,1/1] erlang: remove non-SMP build option | expand |
Frank, All, On 2017-12-20 09:32 -0500, Frank Hunleth spake thusly: > The non-SMP scheduler was deprecated with the Erlang/OTP 20.0 release and > slated for removal with the next major Erlang release. Since the non-SMP > scheduler isn't even built anymore, this option no longer has the > intended effect of saving space or compile time. The SMP scheduler > supports both SMP and non-SMP processors, so removing the option will > not break any platforms. > > We do not need to add a legacy entry, because the new behavior is the > same as with the option previously set (i.e. SMP enabled). > > Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com> Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Thanks! :-) Regards, Yann E. MORIN. > --- > Changes v2 -> v3: > - Removed text from Config.in.legacy and added info as to why it wasn't > needed (thanks to Yann) > Changes v1 -> v2: > - Added text to Config.in.legacy to explain the removal of the option > > package/erlang/Config.in | 10 ---------- > package/erlang/erlang.mk | 4 ---- > 2 files changed, 14 deletions(-) > > diff --git a/package/erlang/Config.in b/package/erlang/Config.in > index 1cd93ca..96af551 100644 > --- a/package/erlang/Config.in > +++ b/package/erlang/Config.in > @@ -27,16 +27,6 @@ config BR2_PACKAGE_ERLANG > > if BR2_PACKAGE_ERLANG > > -config BR2_PACKAGE_ERLANG_SMP > - bool "enable SMP support" > - help > - Erlang provides both a UP and an SMP emulator. The UP > - emulator is always built, and this option enables > - compilation of the SMP emulator. The choice of which > - emulator to use is made at runtime. If you do not need SMP > - support, turning this option off reduces compile time and > - the size of the Erlang installation. > - > config BR2_PACKAGE_ERLANG_MEGACO > bool "install megaco application" > help > diff --git a/package/erlang/erlang.mk b/package/erlang/erlang.mk > index 733c1d5..5705b98 100644 > --- a/package/erlang/erlang.mk > +++ b/package/erlang/erlang.mk > @@ -74,10 +74,6 @@ ERLANG_CONF_OPTS += --enable-shared-zlib > ERLANG_DEPENDENCIES += zlib > endif > > -ifeq ($(BR2_PACKAGE_ERLANG_SMP),) > -ERLANG_CONF_OPTS += --disable-smp-support > -endif > - > # Remove source, example, gs and wx files from staging and target. > ERLANG_REMOVE_PACKAGES = gs wx > > -- > 2.7.4 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Hello, On Wed, 20 Dec 2017 09:32:39 -0500, Frank Hunleth wrote: > The non-SMP scheduler was deprecated with the Erlang/OTP 20.0 release and > slated for removal with the next major Erlang release. Since the non-SMP > scheduler isn't even built anymore, this option no longer has the > intended effect of saving space or compile time. The SMP scheduler > supports both SMP and non-SMP processors, so removing the option will > not break any platforms. > > We do not need to add a legacy entry, because the new behavior is the > same as with the option previously set (i.e. SMP enabled). > > Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com> > --- > Changes v2 -> v3: > - Removed text from Config.in.legacy and added info as to why it wasn't > needed (thanks to Yann) > Changes v1 -> v2: > - Added text to Config.in.legacy to explain the removal of the option Applied to master, thanks. Thomas
diff --git a/package/erlang/Config.in b/package/erlang/Config.in index 1cd93ca..96af551 100644 --- a/package/erlang/Config.in +++ b/package/erlang/Config.in @@ -27,16 +27,6 @@ config BR2_PACKAGE_ERLANG if BR2_PACKAGE_ERLANG -config BR2_PACKAGE_ERLANG_SMP - bool "enable SMP support" - help - Erlang provides both a UP and an SMP emulator. The UP - emulator is always built, and this option enables - compilation of the SMP emulator. The choice of which - emulator to use is made at runtime. If you do not need SMP - support, turning this option off reduces compile time and - the size of the Erlang installation. - config BR2_PACKAGE_ERLANG_MEGACO bool "install megaco application" help diff --git a/package/erlang/erlang.mk b/package/erlang/erlang.mk index 733c1d5..5705b98 100644 --- a/package/erlang/erlang.mk +++ b/package/erlang/erlang.mk @@ -74,10 +74,6 @@ ERLANG_CONF_OPTS += --enable-shared-zlib ERLANG_DEPENDENCIES += zlib endif -ifeq ($(BR2_PACKAGE_ERLANG_SMP),) -ERLANG_CONF_OPTS += --disable-smp-support -endif - # Remove source, example, gs and wx files from staging and target. ERLANG_REMOVE_PACKAGES = gs wx
The non-SMP scheduler was deprecated with the Erlang/OTP 20.0 release and slated for removal with the next major Erlang release. Since the non-SMP scheduler isn't even built anymore, this option no longer has the intended effect of saving space or compile time. The SMP scheduler supports both SMP and non-SMP processors, so removing the option will not break any platforms. We do not need to add a legacy entry, because the new behavior is the same as with the option previously set (i.e. SMP enabled). Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com> --- Changes v2 -> v3: - Removed text from Config.in.legacy and added info as to why it wasn't needed (thanks to Yann) Changes v1 -> v2: - Added text to Config.in.legacy to explain the removal of the option package/erlang/Config.in | 10 ---------- package/erlang/erlang.mk | 4 ---- 2 files changed, 14 deletions(-)