[2/4] linux-headers: indent custom choices

Fix the indentation of config entries in the "Custom kernel headers
series" choice menu.

Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
---
 package/linux-headers/Config.in.host | 160 +++++++++++++++++------------------
 1 file changed, 80 insertions(+), 80 deletions(-)

On 04/19/16 22:52, Vivien Didelot wrote:
> Fix the indentation of config entries in the "Custom kernel headers
> series" choice menu.

  We currently have 5 choice statements where the contents is indented, and 54 
where it's not. So I wouldn't say that we usually indent it...

  That said, I'm not strictly against indenting choice contents: it's not going 
to be nested any deeper, and the lines are normally not that long. The only 
question is what to do with the help texts, because they would suddenly have to 
be wrapped at 82 characters...

>
> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
>   package/linux-headers/Config.in.host | 160 +++++++++++++++++------------------
>   1 file changed, 80 insertions(+), 80 deletions(-)
>
> diff --git a/package/linux-headers/Config.in.host b/package/linux-headers/Config.in.host
> index 9f80224..6d86113 100644
> --- a/package/linux-headers/Config.in.host
> +++ b/package/linux-headers/Config.in.host
> @@ -99,112 +99,112 @@ choice
>   	  This is used to hide/show some packages that have strict
>   	  requirements on the version of kernel headers.
>
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_5
> -	bool "4.5.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_5
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_5
> +		bool "4.5.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_5
[snip]

Hello,

On Wed, 20 Apr 2016 00:58:48 +0200, Arnout Vandecappelle wrote:

>   We currently have 5 choice statements where the contents is indented, and 54 
> where it's not. So I wouldn't say that we usually indent it...

I agreed.

>   That said, I'm not strictly against indenting choice contents: it's not going 
> to be nested any deeper, and the lines are normally not that long. The only 
> question is what to do with the help texts, because they would suddenly have to 
> be wrapped at 82 characters...

I prefer to keep things non-indented. Otherwise, to be consistent, we
would also have to indent the config options within a if...endif block,
or within a menuconfig...endmenu. And then suddenly you can have a
choice nested in an if, nested in a menuconfig, and your indentation
goes crazy.

So, I'd say no.

Thomas

Hi Thomas, Arnout,

Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

> Hello,
>
> On Wed, 20 Apr 2016 00:58:48 +0200, Arnout Vandecappelle wrote:
>
>>   We currently have 5 choice statements where the contents is indented, and 54 
>> where it's not. So I wouldn't say that we usually indent it...
>
> I agreed.
>
>>   That said, I'm not strictly against indenting choice contents: it's not going 
>> to be nested any deeper, and the lines are normally not that long. The only 
>> question is what to do with the help texts, because they would suddenly have to 
>> be wrapped at 82 characters...
>
> I prefer to keep things non-indented. Otherwise, to be consistent, we
> would also have to indent the config options within a if...endif block,
> or within a menuconfig...endmenu. And then suddenly you can have a
> choice nested in an if, nested in a menuconfig, and your indentation
> goes crazy.
>
> So, I'd say no.

I didn't take a look at other files, but only this one, and wanted to be
consistent with the rest of the code where the "Kernel Headers" config
entries are indented.

But I really don't mind, I'll drop this one ;-)

Thanks,
-v

Vivien, All,

On 2016-04-19 16:52 -0400, Vivien Didelot spake thusly:
> Fix the indentation of config entries in the "Custom kernel headers
> series" choice menu.

After the comments by Arnout and Thomas, and your further feedback, I've
marked this patch as rejected in out patchwork.

Regards,
Yann E. MORIN.

> Signed-off-by: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
> ---
>  package/linux-headers/Config.in.host | 160 +++++++++++++++++------------------
>  1 file changed, 80 insertions(+), 80 deletions(-)
> 
> diff --git a/package/linux-headers/Config.in.host b/package/linux-headers/Config.in.host
> index 9f80224..6d86113 100644
> --- a/package/linux-headers/Config.in.host
> +++ b/package/linux-headers/Config.in.host
> @@ -99,112 +99,112 @@ choice
>  	  This is used to hide/show some packages that have strict
>  	  requirements on the version of kernel headers.
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_5
> -	bool "4.5.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_5
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_5
> +		bool "4.5.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_5
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_4
> -	bool "4.4.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_4
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_4
> +		bool "4.4.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_4
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_3
> -	bool "4.3.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_3
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_3
> +		bool "4.3.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_3
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_2
> -	bool "4.2.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_2
> +		bool "4.2.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1
> -	bool "4.1.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_1
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_1
> +		bool "4.1.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_1
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_0
> -	bool "4.0.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_0
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_0
> +		bool "4.0.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_0
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_19
> -	bool "3.19.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_19
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_19
> +		bool "3.19.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_19
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18
> -	bool "3.18.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_18
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_18
> +		bool "3.18.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_18
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_17
> -	bool "3.17.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_17
> +		bool "3.17.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_17
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_16
> -	bool "3.16.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_16
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_16
> +		bool "3.16.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_16
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_15
> -	bool "3.15.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_15
> +		bool "3.15.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_15
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_14
> -	bool "3.14.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_14
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_14
> +		bool "3.14.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_14
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_13
> -	bool "3.13.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_13
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_13
> +		bool "3.13.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_13
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_12
> -	bool "3.12.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_12
> +		bool "3.12.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_12
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_11
> -	bool "3.11.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_11
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_11
> +		bool "3.11.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_11
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_10
> -	bool "3.10.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_10
> +		bool "3.10.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_10
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_9
> -	bool "3.9.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_9
> +		bool "3.9.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_9
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_8
> -	bool "3.8.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_8
> +		bool "3.8.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_8
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_7
> -	bool "3.7.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_7
> +		bool "3.7.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_7
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_6
> -	bool "3.6.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_6
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_6
> +		bool "3.6.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_6
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_5
> -	bool "3.5.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_5
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_5
> +		bool "3.5.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_5
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_4
> -	bool "3.4.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_4
> +		bool "3.4.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_4
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_3
> -	bool "3.3.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_3
> +		bool "3.3.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_3
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_2
> -	bool "3.2.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_2
> +		bool "3.2.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_2
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_1
> -	bool "3.1.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_1
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_1
> +		bool "3.1.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_1
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_0
> -	bool "3.0.x"
> -	select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_3_0
> +		bool "3.0.x"
> +		select BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0
>  
> -config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_REALLY_OLD
> -	bool "2.6.x"
> +	config BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_REALLY_OLD
> +		bool "2.6.x"
>  
>  endchoice
>  
> -- 
> 2.8.0
>