diff mbox

[1/1] setools: disable arch sparc64

Message ID 1458698562-11227-1-git-send-email-matt@thewebers.ws
State Rejected
Headers show

Commit Message

Matt Weber March 23, 2016, 2:02 a.m. UTC
Currently the buildroot sparc64 toolchain encounters a series of relocation
errors.  i.e.
policy_scan.c: relocation truncated to fit: R_SPARC_GOT13 against symbol ....

Workaround for numerous autobuilder failures, including:
http://autobuild.buildroot.net/results/ba1/ba1e473178bb66ebc43897b20e534606d2577ee3/

Signed-off-by: Matt Weber <matt@thewebers.ws>
---
 package/setools/Config.in | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

Comments

Thomas Petazzoni March 23, 2016, 12:09 p.m. UTC | #1
Hello,

On Tue, 22 Mar 2016 21:02:42 -0500, Matt Weber wrote:
> Currently the buildroot sparc64 toolchain encounters a series of relocation
> errors.  i.e.
> policy_scan.c: relocation truncated to fit: R_SPARC_GOT13 against symbol ....
> 
> Workaround for numerous autobuilder failures, including:
> http://autobuild.buildroot.net/results/ba1/ba1e473178bb66ebc43897b20e534606d2577ee3/
> 
> Signed-off-by: Matt Weber <matt@thewebers.ws>
> ---
>  package/setools/Config.in | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

IMO, it can be made to work quite easily on sparc64, it's just a matter
of using -fPIE to build, and not -fpie.

Thomas
Matt Weber March 23, 2016, 9:31 p.m. UTC | #2
Thomas,

On Wed, Mar 23, 2016 at 7:09 AM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Tue, 22 Mar 2016 21:02:42 -0500, Matt Weber wrote:
>> Currently the buildroot sparc64 toolchain encounters a series of relocation
>> errors.  i.e.
>> policy_scan.c: relocation truncated to fit: R_SPARC_GOT13 against symbol ....
>>
>> Workaround for numerous autobuilder failures, including:
>> http://autobuild.buildroot.net/results/ba1/ba1e473178bb66ebc43897b20e534606d2577ee3/
>>
>> Signed-off-by: Matt Weber <matt@thewebers.ws>
>> ---
>>  package/setools/Config.in | 5 +++--
>>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> IMO, it can be made to work quite easily on sparc64, it's just a matter
> of using -fPIE to build, and not -fpie.
>

Good to know.  I'll reject this patch and do some further testing.
Thomas Petazzoni March 26, 2016, 5:53 p.m. UTC | #3
Hello,

On Wed, 23 Mar 2016 16:31:13 -0500, Matthew Weber wrote:

> Good to know.  I'll reject this patch and do some further testing.

In fact, it's just -fPIC vs. -fpic. I've committed a fix:

  https://git.busybox.net/buildroot/commit/?id=8a2e75633f136f021692354434ac0b2d9a81e38c

Thanks!

Thomas
Matt Weber March 26, 2016, 7:57 p.m. UTC | #4
Thomas,

On Mar 26, 2016 12:53 PM, "Thomas Petazzoni" <
thomas.petazzoni@free-electrons.com> wrote:
>
> Hello,
>
> On Wed, 23 Mar 2016 16:31:13 -0500, Matthew Weber wrote:
>
> > Good to know.  I'll reject this patch and do some further testing.
>
> In fact, it's just -fPIC vs. -fpic. I've committed a fix:
>
>
https://git.busybox.net/buildroot/commit/?id=8a2e75633f136f021692354434ac0b2d9a81e38c
>

Appreciated!
diff mbox

Patch

diff --git a/package/setools/Config.in b/package/setools/Config.in
index c291b21..fb4044e 100644
--- a/package/setools/Config.in
+++ b/package/setools/Config.in
@@ -12,7 +12,8 @@  config BR2_PACKAGE_SETOOLS
 	# nios2: triggers some toolchain issue "No symbol version
 	# section for versioned symbol"
 	# arc: libselinux not available
-	depends on !BR2_nios2 && !BR2_bfin && !BR2_arc
+	# sparc64: relocation truncated to fit: R_SPARC_GOT13 against sym
+	depends on !BR2_nios2 && !BR2_bfin && !BR2_arc && !BR2_sparc64
 	help
 	  SETools is an open source project designed to facilitate
 	  SELinux policy analysis. The primary tools are:
@@ -31,4 +32,4 @@  config BR2_PACKAGE_SETOOLS
 comment "setools needs a toolchain w/ threads, C++, wchar, dynamic library"
 	depends on !BR2_TOOLCHAIN_HAS_THREADS || BR2_STATIC_LIBS \
 		|| !BR2_USE_WCHAR || !BR2_INSTALL_LIBSTDCPP
-	depends on !BR2_nios2 && !BR2_bfin && !BR2_arc
+	depends on !BR2_nios2 && !BR2_bfin && !BR2_arc && !BR2_sparc64