| Message ID | 1446219567-4540-1-git-send-email-james.knight@rockwellcollins.com |
|---|---|
| State | Accepted |
| Headers | show |
Dear James Knight, On Fri, 30 Oct 2015 11:39:27 -0400, James Knight wrote: > Signed-off-by: James Knight <james.knight@rockwellcollins.com> > --- > Changes v5 -> v6: > - Cleanup yad help formatting to fit Buildroot style (with help from > Vicente Olivert Riera). I've applied after doing a small change: [Thomas: remove dependency on libglib2, as it is not tested directly by yad's configure script, and is anyway guaranteed to be available since yad depends on gtk2 or gtk3, which both require libglib2.] Thanks, Thomas
Dear James Knight,
On Fri, 30 Oct 2015 11:39:27 -0400, James Knight wrote:
> Signed-off-by: James Knight <james.knight@rockwellcollins.com>
This package is causing some build failure:
http://autobuild.buildroot.org/?reason=yad-0.31.2
(they are all the same).
Can you have a look into it ?
Thanks,
Thomas
Thomas, On Sat, Nov 28, 2015 at 1:24 PM, Thomas Petazzoni < thomas.petazzoni@free-electrons.com> wrote: > This package is causing some build failure: > > http://autobuild.buildroot.org/?reason=yad-0.31.2 > > (they are all the same). > > Can you have a look into it ? > Sure. I'll take a stab at it this week.
Dear James Knight, On Tue, 1 Dec 2015 11:17:52 -0500, James Knight wrote: > > http://autobuild.buildroot.org/?reason=yad-0.31.2 > > > > (they are all the same). > > > > Can you have a look into it ? > > > > Sure. I'll take a stab at it this week. It has already been fixed: http://git.buildroot.net/buildroot/commit/?id=9b17d8285096087bff8543d79e8a2b6ea0810192 Thanks, Thomas
Thomas,
On Tue, Dec 1, 2015 at 11:24 AM, Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> wrote:
> It has already been fixed:
Gah, sorry. Was away and catching up on Emails; didn't check. Glad it got
fixed.
diff --git a/package/Config.in b/package/Config.in index 10ff94e..9c75fa3 100644 --- a/package/Config.in +++ b/package/Config.in @@ -293,6 +293,7 @@ comment "X applications" source "package/xscreensaver/Config.in" source "package/xterm/Config.in" source "package/xvkbd/Config.in" + source "package/yad/Config.in" comment "X libraries and helper libraries" source "package/libsexy/Config.in" diff --git a/package/yad/Config.in b/package/yad/Config.in new file mode 100644 index 0000000..3fa583d --- /dev/null +++ b/package/yad/Config.in @@ -0,0 +1,17 @@ +config BR2_PACKAGE_YAD + bool "yad" + depends on BR2_PACKAGE_XORG7 + depends on BR2_PACKAGE_LIBGTK2 || BR2_PACKAGE_LIBGTK3 + depends on BR2_USE_WCHAR # libglib2 + depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2 + depends on BR2_USE_MMU # libglib2 + select BR2_PACKAGE_LIBGLIB2 + help + YAD (yet another dialog) is a tool for create graphical dialogs + from shell scripts. + + http://sourceforge.net/projects/yad-dialog/ + +comment "yad needs libgtk2 or libgtk3" + depends on BR2_PACKAGE_XORG7 && BR2_USE_MMU + depends on !BR2_PACKAGE_LIBGTK2 && !BR2_PACKAGE_LIBGTK3 diff --git a/package/yad/yad.hash b/package/yad/yad.hash new file mode 100644 index 0000000..4e88ab0 --- /dev/null +++ b/package/yad/yad.hash @@ -0,0 +1,2 @@ +# Locally computed +sha256 c91d6a9eb36abdb502d2d8ada0ec29c266b94a6628f723adeca436bee0b6c55c yad-0.31.2.tar.xz diff --git a/package/yad/yad.mk b/package/yad/yad.mk new file mode 100644 index 0000000..57262e8 --- /dev/null +++ b/package/yad/yad.mk @@ -0,0 +1,24 @@ +################################################################################ +# +# yad +# +################################################################################ + +YAD_VERSION = 0.31.2 +YAD_SOURCE = yad-$(YAD_VERSION).tar.xz +YAD_SITE = http://sourceforge.net/projects/yad-dialog/files +YAD_LICENSE = GPLv3 +YAD_LICENSE_FILES = COPYING +YAD_DEPENDENCIES = host-intltool host-pkgconf libglib2 + +YAD_CONF_OPTS = --enable-html=no + +ifeq ($(BR2_PACKAGE_LIBGTK3),y) +YAD_DEPENDENCIES += libgtk3 +YAD_CONF_OPTS += --with-gtk=gtk3 +else +YAD_DEPENDENCIES += libgtk2 +YAD_CONF_OPTS += --with-gtk=gtk2 +endif + +$(eval $(autotools-package))
Signed-off-by: James Knight <james.knight@rockwellcollins.com> --- Changes v5 -> v6: - Cleanup yad help formatting to fit Buildroot style (with help from Vicente Olivert Riera). Changes v4 -> v5: - Increment to version 0.31.2. - Cleanup yad menu option to be visible after Xorg/MMU is selected. Changes v3 -> v4: - Add missing libglib2 dependencies (pointed out by Vicente Olivert Riera). - Cleanup YAD help description to maximize the 72-character limit space (suggested by Vicente Olivert Riera). Changes v2 -> v3: - Increment to version 0.31.1 (removed need for HTML patch introduced in v2 change; suggested by Vicente Olivert Riera). Changes v1 -> v2: - Increment to version 0.29.0 (with updated hash and patch fix). - Removed complex gtk library selection. Defaults to libgtk3, if available; elsewise, uses libgtk2 (suggested from comments by Baruch Siach, Thomas Petazzoni and Peter Korsgaard). --- package/Config.in | 1 + package/yad/Config.in | 17 +++++++++++++++++ package/yad/yad.hash | 2 ++ package/yad/yad.mk | 24 ++++++++++++++++++++++++ 4 files changed, 44 insertions(+) create mode 100644 package/yad/Config.in create mode 100644 package/yad/yad.hash create mode 100644 package/yad/yad.mk