| Message ID | 1438071916-13248-1-git-send-email-fancp2007@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Dear Scott Fan, On Tue, 28 Jul 2015 16:25:16 +0800, Scott Fan wrote: > Fixes error message while freerdp connected the remote desktop: > Unable to detect time zone > > Signed-off-by: Scott Fan <fancp2007@gmail.com> You have already sent this patch numerous times, but you never include a changelog between the versions, so we don't understand why you're sending it again and again. Can you at least put a cover letter in your patch series, which explains why you are sending the patches again? Thanks, Thomas
Sorry, my emails always been blocked by GFW in China, so i'm not sure whether mails sent successfully. Just now, i've got a stable VPN connection. I promise i won't repeat again. THIS patch should be independent from the patch series, which fixes the error message 'Unable to detect time zone' while the freerdp command connected a remote desktop. Thanks, Scott Fan On Tue, Jul 28, 2015 at 5:07 PM, Thomas Petazzoni < thomas.petazzoni@free-electrons.com> wrote: > Dear Scott Fan, > > On Tue, 28 Jul 2015 16:25:16 +0800, Scott Fan wrote: > > Fixes error message while freerdp connected the remote desktop: > > Unable to detect time zone > > > > Signed-off-by: Scott Fan <fancp2007@gmail.com> > > You have already sent this patch numerous times, but you never include > a changelog between the versions, so we don't understand why you're > sending it again and again. > > Can you at least put a cover letter in your patch series, which > explains why you are sending the patches again? > > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com >
Dear Scott Fan, On Tue, 28 Jul 2015 21:45:55 +0800, Scott Fan wrote: > Sorry, my emails always been blocked by GFW in China, so i'm not sure > whether mails sent successfully. Just now, i've got a stable VPN connection. > I promise i won't repeat again. Ok, I understand. You can check whether your e-mail arrived to the list by checking the list archives: http://lists.busybox.net/pipermail/buildroot/ Note that it takes some time for the e-mails to get archived. I'm not sure how much, but maybe up to a few hours. > THIS patch should be independent from the patch series, which fixes the > error > message 'Unable to detect time zone' while the freerdp command connected a > remote desktop. Right, but it was part of your earlier patch series nonetheless. Could you have a look at http://patchwork.ozlabs.org/project/buildroot/list/, and tell us which of your patches are the latest ones and should still be considered for merging, and which ones are no longer current? Thanks! Thomas
you can merge the patch 501074, 501261 now, pls abort the previous patch 501049, 501050 Scott Fan On Tue, Jul 28, 2015 at 10:03 PM, Thomas Petazzoni < thomas.petazzoni@free-electrons.com> wrote: > Dear Scott Fan, > > On Tue, 28 Jul 2015 21:45:55 +0800, Scott Fan wrote: > > Sorry, my emails always been blocked by GFW in China, so i'm not sure > > whether mails sent successfully. Just now, i've got a stable VPN > connection. > > I promise i won't repeat again. > > Ok, I understand. You can check whether your e-mail arrived to the list > by checking the list archives: > > http://lists.busybox.net/pipermail/buildroot/ > > Note that it takes some time for the e-mails to get archived. I'm not > sure how much, but maybe up to a few hours. > > > THIS patch should be independent from the patch series, which fixes the > > error > > message 'Unable to detect time zone' while the freerdp command connected > a > > remote desktop. > > Right, but it was part of your earlier patch series nonetheless. > > Could you have a look at > http://patchwork.ozlabs.org/project/buildroot/list/, and tell us which > of your patches are the latest ones and should still be considered for > merging, and which ones are no longer current? > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com >
Dear Scott Fan, On Tue, 28 Jul 2015 22:26:18 +0800, Scott Fan wrote: > you can merge the patch 501074, 501261 now, Well, they need some review and testing first. > pls abort the previous patch 501049, 501050 Thanks, those ones marked as "Superseded". Thomas
Ok, got it. Thanks, Scott Fan On Tue, Jul 28, 2015 at 10:32 PM, Thomas Petazzoni < thomas.petazzoni@free-electrons.com> wrote: > Dear Scott Fan, > > On Tue, 28 Jul 2015 22:26:18 +0800, Scott Fan wrote: > > > you can merge the patch 501074, 501261 now, > > Well, they need some review and testing first. > > > pls abort the previous patch 501049, 501050 > > Thanks, those ones marked as "Superseded". > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com >
Scott, All, On 2015-07-28 16:25 +0800, Scott Fan spake thusly: > Fixes error message while freerdp connected the remote desktop: > Unable to detect time zone > > Signed-off-by: Scott Fan <fancp2007@gmail.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Regards, Yann E. MORIN. > --- > .../freerdp/0004-add-support-for-tz-package.patch | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 package/freerdp/0004-add-support-for-tz-package.patch > > diff --git a/package/freerdp/0004-add-support-for-tz-package.patch b/package/freerdp/0004-add-support-for-tz-package.patch > new file mode 100644 > index 0000000..93e4afd > --- /dev/null > +++ b/package/freerdp/0004-add-support-for-tz-package.patch > @@ -0,0 +1,30 @@ > +From 605d0a85183d2f9d5b0da5629cbadf01173bbb2f Mon Sep 17 00:00:00 2001 > +From: Scott Fan <fancp2007@gmail.com> > +Date: Mon, 13 Jul 2015 15:01:17 +0800 > +Subject: [PATCH] Add support for tz package > + > +Fixes error message while freerdp connected the remote desktop: > +Unable to detect time zone > + > +Signed-off-by: Scott Fan <fancp2007@gmail.com> > +--- > + libfreerdp/locale/timezone.c | 3 ++- > + 1 file changed, 2 insertions(+), 1 deletion(-) > + > +diff --git a/libfreerdp/locale/timezone.c b/libfreerdp/locale/timezone.c > +index 3070f1f..4a06786 100644 > +--- a/libfreerdp/locale/timezone.c > ++++ b/libfreerdp/locale/timezone.c > +@@ -1539,7 +1539,8 @@ char* freerdp_get_unix_timezone_identifier() > + * America/Montreal for example. > + */ > + > +- if ((len = readlink("/etc/localtime", buf, sizeof(buf) - 1)) != -1) > ++ if ((len = readlink("/etc/localtime", buf, sizeof(buf) - 1)) != -1 || > ++ (len = readlink("/etc/TZ", buf, sizeof(buf) - 1)) != -1) > + { > + int num = 0; > + int pos = len; > +-- > +2.4.5 > + > -- > 2.4.6 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Dear Scott Fan, On Tue, 28 Jul 2015 16:25:16 +0800, Scott Fan wrote: > Fixes error message while freerdp connected the remote desktop: > Unable to detect time zone > > Signed-off-by: Scott Fan <fancp2007@gmail.com> > --- > .../freerdp/0004-add-support-for-tz-package.patch | 30 ++++++++++++++++++++++ > 1 file changed, 30 insertions(+) > create mode 100644 package/freerdp/0004-add-support-for-tz-package.patch Applied, thanks. Can you please submit the patch to the freerdp project? Thanks, Thomas
Thomas, > Can you please submit the patch to the freerdp project? OK, I'll do it later on. Scott Fan On Fri, Jul 31, 2015 at 5:37 AM, Thomas Petazzoni < thomas.petazzoni@free-electrons.com> wrote: > Dear Scott Fan, > > On Tue, 28 Jul 2015 16:25:16 +0800, Scott Fan wrote: > > Fixes error message while freerdp connected the remote desktop: > > Unable to detect time zone > > > > Signed-off-by: Scott Fan <fancp2007@gmail.com> > > --- > > .../freerdp/0004-add-support-for-tz-package.patch | 30 > ++++++++++++++++++++++ > > 1 file changed, 30 insertions(+) > > create mode 100644 package/freerdp/0004-add-support-for-tz-package.patch > > Applied, thanks. Can you please submit the patch to the freerdp project? > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com >
diff --git a/package/freerdp/0004-add-support-for-tz-package.patch b/package/freerdp/0004-add-support-for-tz-package.patch new file mode 100644 index 0000000..93e4afd --- /dev/null +++ b/package/freerdp/0004-add-support-for-tz-package.patch @@ -0,0 +1,30 @@ +From 605d0a85183d2f9d5b0da5629cbadf01173bbb2f Mon Sep 17 00:00:00 2001 +From: Scott Fan <fancp2007@gmail.com> +Date: Mon, 13 Jul 2015 15:01:17 +0800 +Subject: [PATCH] Add support for tz package + +Fixes error message while freerdp connected the remote desktop: +Unable to detect time zone + +Signed-off-by: Scott Fan <fancp2007@gmail.com> +--- + libfreerdp/locale/timezone.c | 3 ++- + 1 file changed, 2 insertions(+), 1 deletion(-) + +diff --git a/libfreerdp/locale/timezone.c b/libfreerdp/locale/timezone.c +index 3070f1f..4a06786 100644 +--- a/libfreerdp/locale/timezone.c ++++ b/libfreerdp/locale/timezone.c +@@ -1539,7 +1539,8 @@ char* freerdp_get_unix_timezone_identifier() + * America/Montreal for example. + */ + +- if ((len = readlink("/etc/localtime", buf, sizeof(buf) - 1)) != -1) ++ if ((len = readlink("/etc/localtime", buf, sizeof(buf) - 1)) != -1 || ++ (len = readlink("/etc/TZ", buf, sizeof(buf) - 1)) != -1) + { + int num = 0; + int pos = len; +-- +2.4.5 +
Fixes error message while freerdp connected the remote desktop: Unable to detect time zone Signed-off-by: Scott Fan <fancp2007@gmail.com> --- .../freerdp/0004-add-support-for-tz-package.patch | 30 ++++++++++++++++++++++ 1 file changed, 30 insertions(+) create mode 100644 package/freerdp/0004-add-support-for-tz-package.patch