| Message ID | 1429302375-12275-1-git-send-email-fhunleth@troodon-software.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Hi all, Sorry for showing up a bit late on this thread. > +config BR2_TARGET_UBOOT_PATCHES > + string "custom patches" [...] > +UBOOT_PATCH += $(call qstrip,$(BR2_TARGET_UBOOT_PATCHES)) > + > define UBOOT_CONFIGURE_CMDS While we are adding new U-Boot related symbols, I think it would be nice to respect the project naming convention, which is described in the "Names and Spelling" section [1] of the project README file. So, I'd suggest these symbols to be named BR2_TARGET_U_BOOT_PATCHES and U_BOOT_PATCH in respect to the official project name. [1] http://git.denx.de/?p=u-boot.git;a=blob;f=README;h=9b748ccc34120b3c10dd8c33d84269bff6853b1b;hb=HEAD#l93 Best Regards, -v
Dear Frank Hunleth, On Fri, 17 Apr 2015 16:26:13 -0400, Frank Hunleth wrote: > The existing u-boot patch option only allowed directories to be > specified. As suggested by Arnout Vandecappelle, hooking into the > generic patch framework enables files and URLs to be specified. The > downside is that patch directories need to be converted to lists of > files to use this approach. > > This change is useful for Intel Edison support, so that Intel's u-boot > patch can be downloaded rather than stored in the Buildroot source tree. > > Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com> > --- > boot/uboot/Config.in | 8 ++++++++ > boot/uboot/uboot.mk | 2 ++ > 2 files changed, 10 insertions(+) > > diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in > index 3f39ee8..32fcb21 100644 > --- a/boot/uboot/Config.in > +++ b/boot/uboot/Config.in > @@ -79,6 +79,14 @@ config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR > > Most users may leave this empty > > +config BR2_TARGET_UBOOT_PATCHES > + string "custom patches" > + help > + If your board requires custom patches, add a list of patches > + here. > + > + Most users may leave this empty What about doing like for the Linux kernel: a single option to list patches, which can be local patches, local directories, or remote patches to be downloaded? Best regards, Thomas
diff --git a/boot/uboot/Config.in b/boot/uboot/Config.in index 3f39ee8..32fcb21 100644 --- a/boot/uboot/Config.in +++ b/boot/uboot/Config.in @@ -79,6 +79,14 @@ config BR2_TARGET_UBOOT_CUSTOM_PATCH_DIR Most users may leave this empty +config BR2_TARGET_UBOOT_PATCHES + string "custom patches" + help + If your board requires custom patches, add a list of patches + here. + + Most users may leave this empty + choice prompt "U-Boot binary format" default BR2_TARGET_UBOOT_FORMAT_BIN diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk index 6b152ca..e9f90a2 100644 --- a/boot/uboot/uboot.mk +++ b/boot/uboot/uboot.mk @@ -101,6 +101,8 @@ endef UBOOT_POST_PATCH_HOOKS += UBOOT_APPLY_CUSTOM_PATCHES endif +UBOOT_PATCH += $(call qstrip,$(BR2_TARGET_UBOOT_PATCHES)) + define UBOOT_CONFIGURE_CMDS $(TARGET_CONFIGURE_OPTS) \ $(MAKE) -C $(@D) $(UBOOT_MAKE_OPTS) \
The existing u-boot patch option only allowed directories to be specified. As suggested by Arnout Vandecappelle, hooking into the generic patch framework enables files and URLs to be specified. The downside is that patch directories need to be converted to lists of files to use this approach. This change is useful for Intel Edison support, so that Intel's u-boot patch can be downloaded rather than stored in the Buildroot source tree. Signed-off-by: Frank Hunleth <fhunleth@troodon-software.com> --- boot/uboot/Config.in | 8 ++++++++ boot/uboot/uboot.mk | 2 ++ 2 files changed, 10 insertions(+)