diff mbox

[1/1] busybox: make LOGIN_FAIL_DELAY configurable

Message ID 1419085332-379-1-git-send-email-syntheticpp@gmx.net
State Changes Requested
Headers show

Commit Message

Peter Kümmel Dec. 20, 2014, 2:22 p.m. UTC
Pass LOGIN_FAIL_DELAY=<seconds> in busybox's CONFIG_EXTRA_CFLAGS
to change default delay of 3 seconds.

Signed-off-by: Peter Kümmel <syntheticpp@gmx.net>
---
 .../busybox/busybox-0007-login-fail-delay.patch    | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 package/busybox/busybox-0007-login-fail-delay.patch

Comments

Thomas Petazzoni Dec. 20, 2014, 2:58 p.m. UTC | #1
Dear Peter Kümmel,

On Sat, 20 Dec 2014 15:22:12 +0100, Peter Kümmel wrote:
> Pass LOGIN_FAIL_DELAY=<seconds> in busybox's CONFIG_EXTRA_CFLAGS
> to change default delay of 3 seconds.
> 
> Signed-off-by: Peter Kümmel <syntheticpp@gmx.net>
> ---
>  .../busybox/busybox-0007-login-fail-delay.patch    | 28 ++++++++++++++++++++++
>  1 file changed, 28 insertions(+)
>  create mode 100644 package/busybox/busybox-0007-login-fail-delay.patch

Even though the patch is small, it is in a way a "feature" patch: do
something that the upstream Busybox doesn't allow to do. Could you
instead submit this patch upstream, and once it gets accepted, backport
it into Buildroot?

Thanks,

Thomas
Peter Kümmel Dec. 20, 2014, 3:14 p.m. UTC | #2
Am 20.12.2014 um 15:58 schrieb Thomas Petazzoni:
> Dear Peter Kümmel,
>
> On Sat, 20 Dec 2014 15:22:12 +0100, Peter Kümmel wrote:
>> Pass LOGIN_FAIL_DELAY=<seconds> in busybox's CONFIG_EXTRA_CFLAGS
>> to change default delay of 3 seconds.
>>
>> Signed-off-by: Peter Kümmel <syntheticpp@gmx.net>
>> ---
>>   .../busybox/busybox-0007-login-fail-delay.patch    | 28 ++++++++++++++++++++++
>>   1 file changed, 28 insertions(+)
>>   create mode 100644 package/busybox/busybox-0007-login-fail-delay.patch
>
> Even though the patch is small, it is in a way a "feature" patch: do
> something that the upstream Busybox doesn't allow to do. Could you
> instead submit this patch upstream, and once it gets accepted, backport
> it into Buildroot?
>
> Thanks,
>
> Thomas
>

OK, pushed it to the busybox ml.

pk
diff mbox

Patch

diff --git a/package/busybox/busybox-0007-login-fail-delay.patch b/package/busybox/busybox-0007-login-fail-delay.patch
new file mode 100644
index 0000000..158088d
--- /dev/null
+++ b/package/busybox/busybox-0007-login-fail-delay.patch
@@ -0,0 +1,28 @@ 
+From 782002e319d01aba1ddf77419ace633998320866 Mon Sep 17 00:00:00 2001
+From: =?UTF-8?q?Peter=20K=C3=BCmmel?= <syntheticpp@gmx.net>
+Date: Sat, 20 Dec 2014 14:35:56 +0100
+Subject: [PATCH] make LOGIN_FAIL_DELAY configurable
+
+Pass LOGIN_FAIL_DELAY=<seconds> in busybox's CONFIG_EXTRA_CFLAGS
+to change default delay of 3 seconds.
+---
+ include/libbb.h | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/include/libbb.h b/include/libbb.h
+index 64167bb..60c7013 100644
+--- a/include/libbb.h
++++ b/include/libbb.h
+@@ -1252,7 +1252,9 @@ char *bb_simplify_path(const char *path) FAST_FUNC;
+ /* Returns ptr to NUL */
+ char *bb_simplify_abs_path_inplace(char *path) FAST_FUNC;
+ 
++#ifndef LOGIN_FAIL_DELAY
+ #define LOGIN_FAIL_DELAY 3
++#endif
+ extern void bb_do_delay(int seconds) FAST_FUNC;
+ extern void change_identity(const struct passwd *pw) FAST_FUNC;
+ extern void run_shell(const char *shell, int loginshell, const char *command, const char **additional_args) NORETURN FAST_FUNC;
+-- 
+1.9.1
+