| Message ID | 1418852858-818-1-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Wed, 17 Dec 2014 22:47:37 +0100, Thomas Petazzoni wrote: > if config["libc"] != "glibc" and randint(0, 20) == 0: > - configlines.append("BR2_PREFER_STATIC_LIB=y\n") > + configlines.append("BR2_STATIC_LIBS=y\n") Instead, should I also sometimes test BR2_SHARED_STATIC_LIBS ? Like 5% of times static only, 5% of times static+shared, and 90% of the time shared only (the default) ? Best regards, Thomas
Thomas, All, On 2014-12-21 22:03 +0100, Thomas Petazzoni spake thusly: > On Wed, 17 Dec 2014 22:47:37 +0100, Thomas Petazzoni wrote: > > if config["libc"] != "glibc" and randint(0, 20) == 0: > > - configlines.append("BR2_PREFER_STATIC_LIB=y\n") > > + configlines.append("BR2_STATIC_LIBS=y\n") > > Instead, should I also sometimes test BR2_SHARED_STATIC_LIBS ? Like 5% > of times static only, 5% of times static+shared, and 90% of the time > shared only (the default) ? Yes. If there are some packages that do not like to be build both static and shared at the same time, we want to catch those. Regards, Yann E. MORIN.
Dear Yann E. MORIN, On Sun, 21 Dec 2014 22:13:58 +0100, Yann E. MORIN wrote: > If there are some packages that do not like to be build both static and > shared at the same time, we want to catch those. I've already pushed my autobuild-run patches, but we can do a followup patch to implement this. Thanks, Thomas
diff --git a/scripts/autobuild-run b/scripts/autobuild-run index 4d9ef90..ce89e1e 100755 --- a/scripts/autobuild-run +++ b/scripts/autobuild-run @@ -348,7 +348,7 @@ def gen_config(instance, log, sysinfo): elif randint(0, 20) == 0: configlines.append("BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y\n") if config["libc"] != "glibc" and randint(0, 20) == 0: - configlines.append("BR2_PREFER_STATIC_LIB=y\n") + configlines.append("BR2_STATIC_LIBS=y\n") # Write out the configuration file with open(os.path.join(outputdir, ".config"), "w+") as configf:
In Buildroot, the BR2_PREFER_STATIC_LIB option was renamed to BR2_STATIC_LIBS. This commit takes this into account when generating the autobuild configurations. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- scripts/autobuild-run | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)