| Message ID | 1416764163-12826-4-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Headers | show |
Thomas, All, On 2014-11-23 18:36 +0100, Thomas Petazzoni spake thusly: > The ushare configure script is a custom shell script, and it is not > designed to understand that the library order is important when doing > static linking. > > Fixes: > > http://autobuild.buildroot.org/results/32e/32ed2a521043f929cc290145c8a651e69042e104/ > > Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr> However, see below... > --- > package/ushare/Config.in | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/package/ushare/Config.in b/package/ushare/Config.in > index 981f081..7f817d2 100644 > --- a/package/ushare/Config.in > +++ b/package/ushare/Config.in > @@ -4,6 +4,10 @@ config BR2_PACKAGE_USHARE > depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp > select BR2_PACKAGE_LIBUPNP > select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE > + # ushare has a completely custom configure script that does > + # broken things with library ordering, which breaks static > + # linking. > + depends on !BR2_PREFER_STATIC_LIB > help > uShare is a UPnP (TM) A/V & DLNA Media Server. > It implements the server component that provides UPnP media devices > @@ -11,5 +15,5 @@ config BR2_PACKAGE_USHARE > > http://ushare.geexbox.org/ > > -comment "ushare needs a toolchain w/ largefile, threads" > - depends on !(BR2_LARGEFILE && BR2_TOOLCHAIN_HAS_THREADS) > +comment "ushare needs a toolchain w/ largefile, threads, dynamic library" > + depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB This line is now > 80 chars. Maybe it could be split? Regards, Yann E. MORIN. > -- > 2.1.0 > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
diff --git a/package/ushare/Config.in b/package/ushare/Config.in index 981f081..7f817d2 100644 --- a/package/ushare/Config.in +++ b/package/ushare/Config.in @@ -4,6 +4,10 @@ config BR2_PACKAGE_USHARE depends on BR2_TOOLCHAIN_HAS_THREADS # libupnp select BR2_PACKAGE_LIBUPNP select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE + # ushare has a completely custom configure script that does + # broken things with library ordering, which breaks static + # linking. + depends on !BR2_PREFER_STATIC_LIB help uShare is a UPnP (TM) A/V & DLNA Media Server. It implements the server component that provides UPnP media devices @@ -11,5 +15,5 @@ config BR2_PACKAGE_USHARE http://ushare.geexbox.org/ -comment "ushare needs a toolchain w/ largefile, threads" - depends on !(BR2_LARGEFILE && BR2_TOOLCHAIN_HAS_THREADS) +comment "ushare needs a toolchain w/ largefile, threads, dynamic library" + depends on !BR2_LARGEFILE || !BR2_TOOLCHAIN_HAS_THREADS || BR2_PREFER_STATIC_LIB
The ushare configure script is a custom shell script, and it is not designed to understand that the library order is important when doing static linking. Fixes: http://autobuild.buildroot.org/results/32e/32ed2a521043f929cc290145c8a651e69042e104/ Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- package/ushare/Config.in | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-)