diff mbox

[1/1] Removed X depency for make build-graphs

Message ID 1411317986-793-1-git-send-email-sascha.arthur@gmail.com
State Accepted
Headers show

Commit Message

Sascha Arthur Sept. 21, 2014, 4:46 p.m. UTC
Signed-off-by: Sascha Arthur <sascha.arthur@gmail.com>
---
 support/scripts/graph-build-time |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Yann E. MORIN Sept. 21, 2014, 8:25 p.m. UTC | #1
Sascha, All,

On 2014-09-21 18:46 +0200, Sascha Arthur spake thusly:
> 
> Signed-off-by: Sascha Arthur <sascha.arthur@gmail.com>

The resulting graphs do not seem to be affected by this change, as far
as I could see with a minimal build.

Tested-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Reviewed-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

It is a solution I also found suggested on StackOverflow.

Regards,
Yann E. MORIN.

> ---
>  support/scripts/graph-build-time |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/support/scripts/graph-build-time b/support/scripts/graph-build-time
> index 524c30d..4bb90c2 100755
> --- a/support/scripts/graph-build-time
> +++ b/support/scripts/graph-build-time
> @@ -49,9 +49,10 @@
>  #   * argparse (by default in Python 2.7, requires python-argparse if
>  #     Python 2.6 is used)
>  
> -import matplotlib
> +import matplotlib as mpl
>  import numpy
>  
> +mpl.use('Agg')
>  import matplotlib.pyplot as plt
>  import matplotlib.font_manager as fm
>  import csv
> -- 
> 1.7.10.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni Sept. 21, 2014, 8:46 p.m. UTC | #2
Dear Sascha Arthur,

On Sun, 21 Sep 2014 18:46:26 +0200, Sascha Arthur wrote:
> 
> Signed-off-by: Sascha Arthur <sascha.arthur@gmail.com>
> ---
>  support/scripts/graph-build-time |    3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)

Thanks, I've applied the patch after tweaking the commit title. It
contained a typo: depency -> dependency. And also, it didn't contain a
prefix, as we typically do for all patches. So I changed the title to:

	scripts/graph-build-time: remove X dependency

Thanks,

Thomas
diff mbox

Patch

diff --git a/support/scripts/graph-build-time b/support/scripts/graph-build-time
index 524c30d..4bb90c2 100755
--- a/support/scripts/graph-build-time
+++ b/support/scripts/graph-build-time
@@ -49,9 +49,10 @@ 
 #   * argparse (by default in Python 2.7, requires python-argparse if
 #     Python 2.6 is used)
 
-import matplotlib
+import matplotlib as mpl
 import numpy
 
+mpl.use('Agg')
 import matplotlib.pyplot as plt
 import matplotlib.font_manager as fm
 import csv