| Message ID | 1392332394-27935-5-git-send-email-maxime.hadjinlian@gmail.com |
|---|---|
| State | Superseded |
| Headers | show |
Dear Maxime Hadjinlian, On Thu, 13 Feb 2014 23:59:53 +0100, Maxime Hadjinlian wrote: > +if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then > + for prog in java; do Since you're checking for only one program, there's no point in having a loop here. Just do: if ! which java > /dev/null ; then Thanks, Thomas
Hi Thomas, all On Fri, Feb 14, 2014 at 9:39 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Maxime Hadjinlian, > > On Thu, 13 Feb 2014 23:59:53 +0100, Maxime Hadjinlian wrote: > >> +if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then >> + for prog in java; do > > Since you're checking for only one program, there's no point in having > a loop here. Just do: > > if ! which java > /dev/null ; then > Argh, how could I have missed that :( Anyway, thank you. I'll resend when there is some review on the XBMC patch. > Thanks, > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux, Kernel and Android engineering > http://free-electrons.com
On Fri, 14 Feb 2014 09:39:30 +0100 Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Dear Maxime Hadjinlian, > > On Thu, 13 Feb 2014 23:59:53 +0100, Maxime Hadjinlian wrote: > > > +if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then > > + for prog in java; do > > Since you're checking for only one program, there's no point in having > a loop here. Just do: > > if ! which java > /dev/null ; then > Wasn't there a patch this development session that replaced the use of "which" with a standards compliant command? Mike > > Thanks, > > Thomas
On Fri, Feb 14, 2014 at 1:51 PM, Mike Zick <minimod@morethan.org> wrote: > On Fri, 14 Feb 2014 09:39:30 +0100 > Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > >> Dear Maxime Hadjinlian, >> >> On Thu, 13 Feb 2014 23:59:53 +0100, Maxime Hadjinlian wrote: >> >> > +if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then >> > + for prog in java; do >> >> Since you're checking for only one program, there's no point in having >> a loop here. Just do: >> >> if ! which java > /dev/null ; then >> > > Wasn't there a patch this development session that replaced > the use of "which" with a standards compliant command? You are right, you are talking about: http://thread.gmane.org/gmane.comp.lib.uclibc.buildroot/75049/ But as you can see it was never merged. Maybe this patch should be bumped again ? It seems there was a problem with the aliases the user can set but Arnout had an idea about that. > > Mike >> >> Thanks, >> >> Thomas > > _______________________________________________ > buildroot mailing list > buildroot@busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot
Maxime, On 13/02/14 22:59, Maxime Hadjinlian wrote: > XBMC uses a code-generator which is build in two phases: > In the first phase SWIG is used to parse C++ header files that define the API. > SWIG outputs an XML file that contains a complete description of the structure > of the API. > In the second phase, the XML file is ingested by a Groovy (Java) program that > then creates C++ code that forms the bridge to the scripting language (Python). > > The second phase is why we need java on the host. > > You can learn more at the XBMC's wiki: > http://wiki.xbmc.org/index.php?title=Codegeneration#How_it_works > > Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> > --- > support/dependencies/dependencies.sh | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh > index 0e7e1fa..5f77f35 100755 > --- a/support/dependencies/dependencies.sh > +++ b/support/dependencies/dependencies.sh > @@ -191,6 +191,16 @@ if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ; then > done > fi > > +if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then would it be better to have something like if grep -q ^BR2_HOST_NEEDS_JAVA=y $BUILDROOT_CONFIG ; then so that future packages that require java on the host can use this same tes? I'm thinking something like how the BR2_HOSTARCH_NEEDS_IA32_COMPILER test is used by grub. > + for prog in java; do > + if ! which $prog > /dev/null ; then > + echo >&2 > + echo "You must install '$prog' on your build machine" >&2 > + exit 1 > + fi > + done > +fi > + > if grep -q ^BR2_HOSTARCH_NEEDS_IA32_LIBS=y $BR2_CONFIG ; then > if test ! -f /lib/ld-linux.so.2 ; then > echo > Thanks
Hi Martin, all On Fri, Feb 14, 2014 at 9:35 PM, Martin Bark <martin@barkynet.com> wrote: > Maxime, > > > On 13/02/14 22:59, Maxime Hadjinlian wrote: >> >> XBMC uses a code-generator which is build in two phases: >> In the first phase SWIG is used to parse C++ header files that define the >> API. >> SWIG outputs an XML file that contains a complete description of the >> structure >> of the API. >> In the second phase, the XML file is ingested by a Groovy (Java) program >> that >> then creates C++ code that forms the bridge to the scripting language >> (Python). >> >> The second phase is why we need java on the host. >> >> You can learn more at the XBMC's wiki: >> http://wiki.xbmc.org/index.php?title=Codegeneration#How_it_works >> >> Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> >> --- >> support/dependencies/dependencies.sh | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/support/dependencies/dependencies.sh >> b/support/dependencies/dependencies.sh >> index 0e7e1fa..5f77f35 100755 >> --- a/support/dependencies/dependencies.sh >> +++ b/support/dependencies/dependencies.sh >> @@ -191,6 +191,16 @@ if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ; >> then >> done >> fi >> >> +if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then > > > would it be better to have something like > > if grep -q ^BR2_HOST_NEEDS_JAVA=y $BUILDROOT_CONFIG ; then > > so that future packages that require java on the host can use this same tes? > I'm thinking something like how the BR2_HOSTARCH_NEEDS_IA32_COMPILER test is > used by grub. I agree with the idea, at the moment we don't have any package that needs Java to be built, but it may be a nice idea to have a mechanisms for such packages in the future. > > > >> + for prog in java; do >> + if ! which $prog > /dev/null ; then >> + echo >&2 >> + echo "You must install '$prog' on your build >> machine" >&2 >> + exit 1 >> + fi >> + done >> +fi >> + >> if grep -q ^BR2_HOSTARCH_NEEDS_IA32_LIBS=y $BR2_CONFIG ; then >> if test ! -f /lib/ld-linux.so.2 ; then >> echo >> > > Thanks >
diff --git a/support/dependencies/dependencies.sh b/support/dependencies/dependencies.sh index 0e7e1fa..5f77f35 100755 --- a/support/dependencies/dependencies.sh +++ b/support/dependencies/dependencies.sh @@ -191,6 +191,16 @@ if grep -q ^BR2_PACKAGE_CLASSPATH=y $BR2_CONFIG ; then done fi +if grep -q ^BR2_PACKAGE_XBMC=y $BUILDROOT_CONFIG ; then + for prog in java; do + if ! which $prog > /dev/null ; then + echo >&2 + echo "You must install '$prog' on your build machine" >&2 + exit 1 + fi + done +fi + if grep -q ^BR2_HOSTARCH_NEEDS_IA32_LIBS=y $BR2_CONFIG ; then if test ! -f /lib/ld-linux.so.2 ; then echo
XBMC uses a code-generator which is build in two phases: In the first phase SWIG is used to parse C++ header files that define the API. SWIG outputs an XML file that contains a complete description of the structure of the API. In the second phase, the XML file is ingested by a Groovy (Java) program that then creates C++ code that forms the bridge to the scripting language (Python). The second phase is why we need java on the host. You can learn more at the XBMC's wiki: http://wiki.xbmc.org/index.php?title=Codegeneration#How_it_works Signed-off-by: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> --- support/dependencies/dependencies.sh | 10 ++++++++++ 1 file changed, 10 insertions(+)