Message ID | 1363115372-5679-1-git-send-email-viniciustinti@gmail.com |
---|---|
State | Superseded |
Headers | show |
Dear Vinicius Tinti, On Tue, 12 Mar 2013 16:09:31 -0300, Vinicius Tinti wrote: > diff --git a/package/python-thrift/Config.in b/package/python-thrift/Config.in > new file mode 100644 > index 0000000..3aa6bfb > --- /dev/null > +++ b/package/python-thrift/Config.in > @@ -0,0 +1,8 @@ > +config BR2_PACKAGE_PYTHON_THRIFT > + bool "python-thrift" > + depends on BR2_PACKAGE_PYTHON The "depends on BR2_PACKAGE_PYTHON" here is not needed, since the 'source "package/python-thrift/Config.in"' in package/Config.in is already enclosed in a if BR2_PACKAGE_PYTHON...endif. > +PYTHON_THRIFT_VERSION = 0.9.0 > +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_VERSION).tar.gz > +PYTHON_THRIFT_SITE = https://pypi.python.org/packages/source/t/thrift/ Could you add PYTHON_THRIFT_LICENSE and PYTHON_THRIFT_LICENSE_FILES ? Otherwise, looks good to me. Thomas
Yes, sure. But about BR2_PACKAGE_PYTHON I have seen that many other python-<module> use it. Since I get 'python-serial' as template I thought it was mandatory. Should I really remove it? On Wed, Mar 13, 2013 at 4:30 AM, Thomas Petazzoni < thomas.petazzoni@free-electrons.com> wrote: > Dear Vinicius Tinti, > > On Tue, 12 Mar 2013 16:09:31 -0300, Vinicius Tinti wrote: > > diff --git a/package/python-thrift/Config.in > b/package/python-thrift/Config.in > > new file mode 100644 > > index 0000000..3aa6bfb > > --- /dev/null > > +++ b/package/python-thrift/Config.in > > @@ -0,0 +1,8 @@ > > +config BR2_PACKAGE_PYTHON_THRIFT > > + bool "python-thrift" > > + depends on BR2_PACKAGE_PYTHON > > The "depends on BR2_PACKAGE_PYTHON" here is not needed, since the > 'source "package/python-thrift/Config.in"' in package/Config.in is > already enclosed in a if BR2_PACKAGE_PYTHON...endif. > > > +PYTHON_THRIFT_VERSION = 0.9.0 > > +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_VERSION).tar.gz > > +PYTHON_THRIFT_SITE = > https://pypi.python.org/packages/source/t/thrift/ > > Could you add PYTHON_THRIFT_LICENSE and PYTHON_THRIFT_LICENSE_FILES ? > > Otherwise, looks good to me. > > Thomas > -- > Thomas Petazzoni, Free Electrons > Kernel, drivers, real-time and embedded Linux > development, consulting, training and support. > http://free-electrons.com >
diff --git a/package/Config.in b/package/Config.in index a65054c..8467735 100644 --- a/package/Config.in +++ b/package/Config.in @@ -334,6 +334,7 @@ source "package/python-pygame/Config.in" source "package/python-pyparsing/Config.in" source "package/python-serial/Config.in" source "package/python-setuptools/Config.in" +source "package/python-thrift/Config.in" endmenu endif source "package/ruby/Config.in" diff --git a/package/python-thrift/Config.in b/package/python-thrift/Config.in new file mode 100644 index 0000000..3aa6bfb --- /dev/null +++ b/package/python-thrift/Config.in @@ -0,0 +1,8 @@ +config BR2_PACKAGE_PYTHON_THRIFT + bool "python-thrift" + depends on BR2_PACKAGE_PYTHON + help + python-thrift is a Python bindings for the Apache Thrift RPC system. + + http://thrift.apache.org/ + diff --git a/package/python-thrift/python-thrift.mk b/package/python-thrift/python-thrift.mk new file mode 100644 index 0000000..00bb90c --- /dev/null +++ b/package/python-thrift/python-thrift.mk @@ -0,0 +1,21 @@ +############################################################# +# +# python-thrift +# +############################################################# + +PYTHON_THRIFT_VERSION = 0.9.0 +PYTHON_THRIFT_SOURCE = thrift-$(PYTHON_THRIFT_VERSION).tar.gz +PYTHON_THRIFT_SITE = https://pypi.python.org/packages/source/t/thrift/ + +PYTHON_THRIFT_DEPENDENCIES = python + +define PYTHON_THRIFT_BUILD_CMDS + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py build) +endef + +define PYTHON_THRIFT_INSTALL_TARGET_CMDS + (cd $(@D); $(HOST_DIR)/usr/bin/python setup.py install --prefix=$(TARGET_DIR)/usr) +endef + +$(eval $(generic-package))