| Message ID | 1354120492-17059-1-git-send-email-thomas.petazzoni@free-electrons.com |
|---|---|
| State | Accepted |
| Commit | 21a0c11a90f9ff19c78a5f32e0a2e9064fd28054 |
| Headers | show |
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:
Thomas> When building gdb for the host, we properly pass the PATH (through
Thomas> HOST_CONFIGURE_OPTS) during the configure step, but we forget to do so
Thomas> for the compilation step.
Thomas> The result of this is that when the Crosstool-NG backend is used, gawk
Thomas> is built and installed in $(HOST_DIR), as a dependency of the
Thomas> crosstool-ng package.
Thomas> Then, the host gdb configure script detects this gawk binary
Thomas> ($(HOST_DIR) is in the PATH), and assumes gawk is
Thomas> available. Unfortunately, during the compilation step, it fails to
Thomas> find the expected gawk binary, because $(HOST_DIR) is no longer in the
Thomas> PATH. This causes the following build failure:
Thomas> http://autobuild.buildroot.org/results/067d0c2ea01673ba98ec11de2426f1ab92dac800/build-end.log
Committed, thanks.
diff --git a/toolchain/gdb/gdb.mk b/toolchain/gdb/gdb.mk index c42c755..4b8fe3a 100644 --- a/toolchain/gdb/gdb.mk +++ b/toolchain/gdb/gdb.mk @@ -196,6 +196,7 @@ $(GDB_HOST_DIR)/.configured: $(GDB_DIR)/.unpacked $(GDB_HOST_DIR)/gdb/gdb: $(GDB_HOST_DIR)/.configured # force ELF support since it fails due to BFD linking problems + $(HOST_MAKE_ENV) \ gdb_cv_var_elf=yes \ $(MAKE) -C $(GDB_HOST_DIR) strip $(GDB_HOST_DIR)/gdb/gdb
When building gdb for the host, we properly pass the PATH (through HOST_CONFIGURE_OPTS) during the configure step, but we forget to do so for the compilation step. The result of this is that when the Crosstool-NG backend is used, gawk is built and installed in $(HOST_DIR), as a dependency of the crosstool-ng package. Then, the host gdb configure script detects this gawk binary ($(HOST_DIR) is in the PATH), and assumes gawk is available. Unfortunately, during the compilation step, it fails to find the expected gawk binary, because $(HOST_DIR) is no longer in the PATH. This causes the following build failure: http://autobuild.buildroot.org/results/067d0c2ea01673ba98ec11de2426f1ab92dac800/build-end.log In order to fix this, we simply call the compilation step of gdb for the host with $(HOST_MAKE_ENV), as it should have been done from the beginning. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com> --- toolchain/gdb/gdb.mk | 1 + 1 file changed, 1 insertion(+)