| Message ID | 1348774062-23946-1-git-send-email-baruch@tkos.co.il |
|---|---|
| State | Accepted |
| Commit | 96688934c471d81197ebf0e19c72bba8fa5feb2e |
| Headers | show |
Baruch, All, On Thursday 27 September 2012 21:27:42 Baruch Siach wrote: > v4: now actually commit the rephrased text. [--SNIP--] > config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC > - bool "glibc" > + bool "glibc/eglibc" > select BR2_TOOLCHAIN_EXTERNAL_GLIBC > + help > + Note: eglibc is a variant of glibc that (among other things) can be > + configured to exclude some of its features. Using a toolchain with > + eglibc configured to exclude key features may cause build failures to > + some packages. Well, that's even better! :-) Regards, Yann E. MORIN.
Dear Baruch Siach, On Thu, 27 Sep 2012 21:27:42 +0200, Baruch Siach wrote: > Yann E. MORIN says: > > "Although eglibc can be configured to include/exclude parts of the > features, it seems to not be in wide use, if at all." > > Acked-by: Yann E. MORIN <yann.morin.1998@free.fr> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> Acked-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Baruch Siach wrote: > Yann E. MORIN says: > > "Although eglibc can be configured to include/exclude parts of the > features, it seems to not be in wide use, if at all." > > Acked-by: Yann E. MORIN <yann.morin.1998@free.fr> > Signed-off-by: Baruch Siach <baruch@tkos.co.il> Acked-by: Luca Ceresoli <luca@lucaceresoli.net> Luca
>>>>> "Baruch" == Baruch Siach <baruch@tkos.co.il> writes:
Baruch> Yann E. MORIN says:
Baruch> "Although eglibc can be configured to include/exclude parts of the
Baruch> features, it seems to not be in wide use, if at all."
Committed, thanks.
diff --git a/toolchain/toolchain-external/Config.in b/toolchain/toolchain-external/Config.in index f86ed74..cd56443 100644 --- a/toolchain/toolchain-external/Config.in +++ b/toolchain/toolchain-external/Config.in @@ -664,8 +664,13 @@ config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_UCLIBC select BR2_TOOLCHAIN_HAS_SHADOW_PASSWORDS config BR2_TOOLCHAIN_EXTERNAL_CUSTOM_GLIBC - bool "glibc" + bool "glibc/eglibc" select BR2_TOOLCHAIN_EXTERNAL_GLIBC + help + Note: eglibc is a variant of glibc that (among other things) can be + configured to exclude some of its features. Using a toolchain with + eglibc configured to exclude key features may cause build failures to + some packages. endchoice
Yann E. MORIN says: "Although eglibc can be configured to include/exclude parts of the features, it seems to not be in wide use, if at all." Acked-by: Yann E. MORIN <yann.morin.1998@free.fr> Signed-off-by: Baruch Siach <baruch@tkos.co.il> --- v4: now actually commit the rephrased text. v3: rephrase the help text to make it clear that the eglibc build is given, address the comment of Thomas Petazzoni. v2: mention in the help text that eglibc may lack some features as suggested by Yann E. MORIN. toolchain/toolchain-external/Config.in | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-)