mbox series

[v6,0/3] add support for TI's AM64x boards

Message ID 20221117001511.1753592-1-gadiyar@ti.com
Headers show
Series add support for TI's AM64x boards | expand

Message

Anand Gadiyar Nov. 17, 2022, 12:15 a.m. UTC 
This series introduces support for TI's AM64x SK boards.

We would like to add support for the AM62x SK as well, but are
currently blocked by availability of some firmware. That's still
on the list, as is the SK-TDA4VM. We should also be able to
enable the beagleboard-ai64 alongside that at the same time.


This series was previously sent out by Xuanhao in August and
was reviewed by Giulio Benetti up to v5 (Thanks!).

This series addresses further review comments for v5 from Romain
Naour. Thanks for the review Romain!

Andrew Davis acked the previous series, except for one new change
that I've addressed in this version.

I addressed all of Romain's comments except one - I couldn't get
the sha256sum for the k3-image-gen package to be updated in the
source repository, so for now it's still manually computed. I'll
see what I can do about getting the repository owners to generate
these automatically at release time.

Changes in v6:
- rebased to latest next branch and retested
- updated u-boot and kernel to latest released versions as of today
From Andrew's comments:
- added a new SOC_TYPE option for k3-image-gen, as requested by Andrew
  Davis in a review comment.
From Romain's comments:
- use "if" instead of "depends on" for sub-options
- move TI K3 R5 Loader defconfig selection to Kconfig
- use $(HOST_DIR) instead of $(HOST_ARM_GNU_TOOLCHAIN_INSTALL_DIR)
- Retain Xuanhao's gmail ID in the MAINTAINERs file, but drop his TI
  email from CC list as it will be inactive till he rejoins TI
- Add a plain-text license file into the k3-image-gen repository and use
  it instead of the HTML manifest file. Confirmed that this is still
  BSD-3-Clause license.
- Add comments in the ti-k3-image-gen.mk file for a couple of options

Changes in v5:
- None (resubmission of Xuanhao's series)

Changes in v4:
- rebased to latest master and retested
- dropped OPTEE CUSTOM* options as we don't need them.

Changes in v3:
- Fix boot/ti-k3-r5-loader package's build options and dependencies.
- Fix boot/ti-k3-image-gen package's config
- Add more details in board/ti/am64x_sk's readme
- Trim configs/am64x_sk's toolchain options and 
  fix uboot and genimage dependencies.
- Remove board/ti/am62x_sk and configs/am62x_sk for now due to some
  firmware dependency problems. Will be added back in the future.

Changes in v2:
- Revert arm-gnu-toolchain back to version 10.x due to a bug.
  When the pre-packaged GCC was built, it could be targeting
  a newer x86_64 architecture than the processor being used.
- Add boot/ti-k3-r5-loader package that builds a separate U-Boot
  for the R5 cores on TI's K3 devices.
- Add boot/ti-k3-image-gen package that builds the full boot binary
  tiboot3.bin from the spl built from ti-k3-r5-loader.
- Add board/ti directory to include sdcard config and board information
  for AM64x_sk and AM62x_sk boards.
- Add the Buildroot defconfigs for AM64x_sk and AM62x_sk.
- Add to DEVELOPERS list.

Xuanhao Shi (3):
  boot/ti-k3-r5-loader: add new package
  boot/ti-k3-image-gen: add new package
  board/ti/am64x_sk: add new board

 DEVELOPERS                                | 12 ++++++
 board/ti/am64x_sk/genimage.cfg            | 27 +++++++++++++
 board/ti/am64x_sk/readme.txt              | 49 +++++++++++++++++++++++
 boot/Config.in                            |  2 +
 boot/ti-k3-image-gen/Config.in            | 24 +++++++++++
 boot/ti-k3-image-gen/ti-k3-image-gen.hash |  2 +
 boot/ti-k3-image-gen/ti-k3-image-gen.mk   | 40 ++++++++++++++++++
 boot/ti-k3-r5-loader/Config.in            | 14 +++++++
 boot/ti-k3-r5-loader/ti-k3-r5-loader.hash |  2 +
 boot/ti-k3-r5-loader/ti-k3-r5-loader.mk   | 45 +++++++++++++++++++++
 configs/am64x_sk_defconfig                | 45 +++++++++++++++++++++
 11 files changed, 262 insertions(+)
 create mode 100644 board/ti/am64x_sk/genimage.cfg
 create mode 100644 board/ti/am64x_sk/readme.txt
 create mode 100644 boot/ti-k3-image-gen/Config.in
 create mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.hash
 create mode 100644 boot/ti-k3-image-gen/ti-k3-image-gen.mk
 create mode 100644 boot/ti-k3-r5-loader/Config.in
 create mode 100644 boot/ti-k3-r5-loader/ti-k3-r5-loader.hash
 create mode 100644 boot/ti-k3-r5-loader/ti-k3-r5-loader.mk
 create mode 100644 configs/am64x_sk_defconfig

Comments

Bryan Brattlof Nov. 17, 2022, 8:10 p.m. UTC | #1 
On November 16, 2022 thus sayeth Anand Gadiyar:
> This series introduces support for TI's AM64x SK boards.
> 
> We would like to add support for the AM62x SK as well, but are
> currently blocked by availability of some firmware. That's still
> on the list, as is the SK-TDA4VM. We should also be able to
> enable the beagleboard-ai64 alongside that at the same time.
> 
> 
> This series was previously sent out by Xuanhao in August and
> was reviewed by Giulio Benetti up to v5 (Thanks!).
> 
> This series addresses further review comments for v5 from Romain
> Naour. Thanks for the review Romain!
> 
> Andrew Davis acked the previous series, except for one new change
> that I've addressed in this version.
> 
> I addressed all of Romain's comments except one - I couldn't get
> the sha256sum for the k3-image-gen package to be updated in the
> source repository, so for now it's still manually computed. I'll
> see what I can do about getting the repository owners to generate
> these automatically at release time.
> 
> Changes in v6:
> - rebased to latest next branch and retested
> - updated u-boot and kernel to latest released versions as of today
> From Andrew's comments:
> - added a new SOC_TYPE option for k3-image-gen, as requested by Andrew
>   Davis in a review comment.
> From Romain's comments:
> - use "if" instead of "depends on" for sub-options
> - move TI K3 R5 Loader defconfig selection to Kconfig
> - use $(HOST_DIR) instead of $(HOST_ARM_GNU_TOOLCHAIN_INSTALL_DIR)
> - Retain Xuanhao's gmail ID in the MAINTAINERs file, but drop his TI
>   email from CC list as it will be inactive till he rejoins TI
> - Add a plain-text license file into the k3-image-gen repository and use
>   it instead of the HTML manifest file. Confirmed that this is still
>   BSD-3-Clause license.
> - Add comments in the ti-k3-image-gen.mk file for a couple of options
> 

Sorry for the noise everyone.. I wasn't subscribed to the lists and it 
rejected my mail :(

Tested-by: Bryan Brattlof <bb@ti.com>


The patches still look great to me :)
~Bryan