| Message ID | 1505302931-17387-1-git-send-email-jteki@openedev.com |
|---|---|
| Headers | show |
| Series | engicam: Add new boards and qt5 | expand |
On Wed, Sep 13, 2017 at 5:12 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote: > From: Jagan Teki <jagan@amarulasolutions.com> > > This series add new boards from Engicam with qt5 support for each. > > Jagan Teki (6): > engicam: imx6qdl_icore: Bump to latest Linux and uboot releases > board: icorem6: Add Qt5 configs for 800x480 LVDS display > engicam: icorem6: Add OF C.TOUCH 10.1 Kit > board: icorem6: Add Qt5 configs for 1280x800 LVDS display > engicam: icorem6: Add OF C.TOUCH 12 Kit > board: icorem6: Add Qt5 configs for 1280x480 LVDS display Any comments on this? thanks!
On 21-Sep-2017 6:05 PM, "Jagan Teki" <jagannadh.teki@gmail.com> wrote: On Wed, Sep 13, 2017 at 5:12 PM, Jagan Teki <jagannadh.teki@gmail.com> wrote: > From: Jagan Teki <jagan@amarulasolutions.com> > > This series add new boards from Engicam with qt5 support for each. > > Jagan Teki (6): > engicam: imx6qdl_icore: Bump to latest Linux and uboot releases > board: icorem6: Add Qt5 configs for 800x480 LVDS display > engicam: icorem6: Add OF C.TOUCH 10.1 Kit > board: icorem6: Add Qt5 configs for 1280x800 LVDS display > engicam: icorem6: Add OF C.TOUCH 12 Kit > board: icorem6: Add Qt5 configs for 1280x480 LVDS display Any comments on this? We're planning to send GST patches on top of this series, would you please comment. <div dir="auto"><div><br><div class="gmail_extra"><br><div class="gmail_quote">On 21-Sep-2017 6:05 PM, "Jagan Teki" <<a href="mailto:jagannadh.teki@gmail.com">jagannadh.teki@gmail.com</a>> wrote:<br type="attribution"><blockquote class="quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="quoted-text">On Wed, Sep 13, 2017 at 5:12 PM, Jagan Teki <<a href="mailto:jagannadh.teki@gmail.com">jagannadh.teki@gmail.com</a>> wrote:<br> > From: Jagan Teki <<a href="mailto:jagan@amarulasolutions.com">jagan@amarulasolutions.com</a>><br> ><br> > This series add new boards from Engicam with qt5 support for each.<br> ><br> > Jagan Teki (6):<br> > engicam: imx6qdl_icore: Bump to latest Linux and uboot releases<br> > board: icorem6: Add Qt5 configs for 800x480 LVDS display<br> > engicam: icorem6: Add OF C.TOUCH 10.1 Kit<br> > board: icorem6: Add Qt5 configs for 1280x800 LVDS display<br> > engicam: icorem6: Add OF C.TOUCH 12 Kit<br> > board: icorem6: Add Qt5 configs for 1280x480 LVDS display<br> <br> </div>Any comments on this?<br></blockquote></div></div></div><div dir="auto"><br></div><div dir="auto">We're planning to send GST patches on top of this series, would you please comment.</div><div dir="auto"><div class="gmail_extra"><br></div></div></div>
Hi Jagan, On 27-09-17 19:57, Jagan Teki wrote: > > > On 21-Sep-2017 6:05 PM, "Jagan Teki" <jagannadh.teki@gmail.com > <mailto:jagannadh.teki@gmail.com>> wrote: > > On Wed, Sep 13, 2017 at 5:12 PM, Jagan Teki <jagannadh.teki@gmail.com > <mailto:jagannadh.teki@gmail.com>> wrote: > > From: Jagan Teki <jagan@amarulasolutions.com > <mailto:jagan@amarulasolutions.com>> > > > > This series add new boards from Engicam with qt5 support for each. > > > > Jagan Teki (6): > > engicam: imx6qdl_icore: Bump to latest Linux and uboot releases > > board: icorem6: Add Qt5 configs for 800x480 LVDS display > > engicam: icorem6: Add OF C.TOUCH 10.1 Kit > > board: icorem6: Add Qt5 configs for 1280x800 LVDS display > > engicam: icorem6: Add OF C.TOUCH 12 Kit > > board: icorem6: Add Qt5 configs for 1280x480 LVDS display > > Any comments on this? > > > We're planning to send GST patches on top of this series, would you please comment. I've been wary about applying this patch series because we don't really want qt5 defconfigs for every board. Especially since we already have a mx6/Etnaviv defconfig (imx6-sabresd_qt5_defconfig). Initially I even thought you were adding three different qt5 defconfigs... But fortunately it's just one. That said, since you're clearly actively working with this, it's worth including it. Peter, Thomas, opinions? Regards, Arnout
Hello, On Wed, 27 Sep 2017 21:43:41 +0200, Arnout Vandecappelle wrote: > I've been wary about applying this patch series because we don't really want > qt5 defconfigs for every board. Especially since we already have a mx6/Etnaviv > defconfig (imx6-sabresd_qt5_defconfig). Initially I even thought you were adding > three different qt5 defconfigs... But fortunately it's just one. > > That said, since you're clearly actively working with this, it's worth > including it. > > Peter, Thomas, opinions? I'm also worried about the growing number of defconfig files, targeting specific use cases. But we don't really have a better way to support such example configurations other by merging more defconfig files, so probably we should do it. As long as we remain aggressive in dropping defconfig files that are not maintained, I believe we can accept more defconfig files. Best regards, Thomas
On 13-09-17 13:42, Jagan Teki wrote: > From: Jagan Teki <jagan@amarulasolutions.com> > > This series add new boards from Engicam with qt5 support for each. > > Jagan Teki (6): > engicam: imx6qdl_icore: Bump to latest Linux and uboot releases > board: icorem6: Add Qt5 configs for 800x480 LVDS display > engicam: icorem6: Add OF C.TOUCH 10.1 Kit > board: icorem6: Add Qt5 configs for 1280x800 LVDS display > engicam: icorem6: Add OF C.TOUCH 12 Kit > board: icorem6: Add Qt5 configs for 1280x480 LVDS display Series applied to master, with slight changes to readme.txt. I pushed an additional separate patch to readme.txt that makes an IMO nicer distinction between the different boards - I found the list of DTB files a bit confusing. Could you take a look at the result? It would have been nice to be able to merge more of this stuff with the sabre configs, but as you mentioned they still have separate U-Boot configs so that won't be possible, and the json files are also different. Pity. Regards, Arnout > > .gitlab-ci.yml | 1 + > DEVELOPERS | 1 + > board/engicam/icorem6/genimage.cfg | 4 +- > board/engicam/icorem6/linux_qt5.fragment | 4 ++ > board/engicam/icorem6/readme.txt | 24 +++++++ > .../rootfs_overlay/root/imx6qdl-icore-ofcap10.json | 11 +++ > .../rootfs_overlay/root/imx6qdl-icore-ofcap12.json | 11 +++ > .../icorem6/rootfs_overlay/root/imx6qdl-icore.json | 11 +++ > configs/engicam_imx6qdl_icore_defconfig | 12 ++-- > configs/engicam_imx6qdl_icore_qt5_defconfig | 81 ++++++++++++++++++++++ > 10 files changed, 153 insertions(+), 7 deletions(-) > create mode 100644 board/engicam/icorem6/linux_qt5.fragment > create mode 100644 board/engicam/icorem6/rootfs_overlay/root/imx6qdl-icore-ofcap10.json > create mode 100644 board/engicam/icorem6/rootfs_overlay/root/imx6qdl-icore-ofcap12.json > create mode 100644 board/engicam/icorem6/rootfs_overlay/root/imx6qdl-icore.json > create mode 100644 configs/engicam_imx6qdl_icore_qt5_defconfig >
From: Jagan Teki <jagan@amarulasolutions.com> This series add new boards from Engicam with qt5 support for each. Jagan Teki (6): engicam: imx6qdl_icore: Bump to latest Linux and uboot releases board: icorem6: Add Qt5 configs for 800x480 LVDS display engicam: icorem6: Add OF C.TOUCH 10.1 Kit board: icorem6: Add Qt5 configs for 1280x800 LVDS display engicam: icorem6: Add OF C.TOUCH 12 Kit board: icorem6: Add Qt5 configs for 1280x480 LVDS display .gitlab-ci.yml | 1 + DEVELOPERS | 1 + board/engicam/icorem6/genimage.cfg | 4 +- board/engicam/icorem6/linux_qt5.fragment | 4 ++ board/engicam/icorem6/readme.txt | 24 +++++++ .../rootfs_overlay/root/imx6qdl-icore-ofcap10.json | 11 +++ .../rootfs_overlay/root/imx6qdl-icore-ofcap12.json | 11 +++ .../icorem6/rootfs_overlay/root/imx6qdl-icore.json | 11 +++ configs/engicam_imx6qdl_icore_defconfig | 12 ++-- configs/engicam_imx6qdl_icore_qt5_defconfig | 81 ++++++++++++++++++++++ 10 files changed, 153 insertions(+), 7 deletions(-) create mode 100644 board/engicam/icorem6/linux_qt5.fragment create mode 100644 board/engicam/icorem6/rootfs_overlay/root/imx6qdl-icore-ofcap10.json create mode 100644 board/engicam/icorem6/rootfs_overlay/root/imx6qdl-icore-ofcap12.json create mode 100644 board/engicam/icorem6/rootfs_overlay/root/imx6qdl-icore.json create mode 100644 configs/engicam_imx6qdl_icore_qt5_defconfig