diff mbox series

[v3,2/9] package/asterisk: libsrtp needs openssl

Message ID 20181014090202.31122-2-bernd.kuhls@t-online.de
State Accepted
Headers show
Series [v3,1/9] DEVELOPERS: add myself for asterisk | expand

Commit Message

Bernd Kuhls Oct. 14, 2018, 9:01 a.m. UTC
Fixes configure error

checking for the ability of -lsrtp2 to be linked in a shared object... yes
checking for srtp_crypto_policy_set_aes_cm_256_hmac_sha1_80 in -lsrtp2... yes
checking for srtp_crypto_policy_set_aes_cm_192_hmac_sha1_80 in -lsrtp2... no
checking for srtp_crypto_policy_set_aes_gcm_128_8_auth in -lsrtp2... no
checking for srtp_shutdown in -lsrtp2... yes
checking for srtp2/srtp.h... (cached) yes
configure: WARNING: ***
configure: WARNING: *** OpenSSL required when using libsrtp2, checking for libsrtp instead.
configure: WARNING: ***

using this defconfig:

BR2_PACKAGE_LIBSRTP=y
BR2_PACKAGE_ASTERISK=y

Please note that openssl support in libsrtp is not available for static
builds:
https://git.buildroot.net/buildroot/tree/package/libsrtp/libsrtp.mk#n27

Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
---
v3: no changes
v2: Added comment in commit log about libsrtp dependencies (Thomas)

 package/asterisk/asterisk.mk | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Comments

Thomas Petazzoni Dec. 6, 2018, 10:17 p.m. UTC | #1
Hello,

On Sun, 14 Oct 2018 11:01:54 +0200, Bernd Kuhls wrote:
> Fixes configure error
> 
> checking for the ability of -lsrtp2 to be linked in a shared object... yes
> checking for srtp_crypto_policy_set_aes_cm_256_hmac_sha1_80 in -lsrtp2... yes
> checking for srtp_crypto_policy_set_aes_cm_192_hmac_sha1_80 in -lsrtp2... no
> checking for srtp_crypto_policy_set_aes_gcm_128_8_auth in -lsrtp2... no
> checking for srtp_shutdown in -lsrtp2... yes
> checking for srtp2/srtp.h... (cached) yes
> configure: WARNING: ***
> configure: WARNING: *** OpenSSL required when using libsrtp2, checking for libsrtp instead.
> configure: WARNING: ***
> 
> using this defconfig:
> 
> BR2_PACKAGE_LIBSRTP=y
> BR2_PACKAGE_ASTERISK=y
> 
> Please note that openssl support in libsrtp is not available for static
> builds:
> https://git.buildroot.net/buildroot/tree/package/libsrtp/libsrtp.mk#n27
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>

I could indeed reproduce this build issue. One question that comes up
is: why hasn't the autobuilder found this build problem ? It happens on
a fairly basic/straightforward configuration, it's really strange that
it has never popped up. Any idea about this?

Best regards,

Thomas
Thomas Petazzoni Dec. 9, 2018, 9:24 p.m. UTC | #2
Hello,

On Sun, 14 Oct 2018 11:01:54 +0200, Bernd Kuhls wrote:
> Fixes configure error
> 
> checking for the ability of -lsrtp2 to be linked in a shared object... yes
> checking for srtp_crypto_policy_set_aes_cm_256_hmac_sha1_80 in -lsrtp2... yes
> checking for srtp_crypto_policy_set_aes_cm_192_hmac_sha1_80 in -lsrtp2... no
> checking for srtp_crypto_policy_set_aes_gcm_128_8_auth in -lsrtp2... no
> checking for srtp_shutdown in -lsrtp2... yes
> checking for srtp2/srtp.h... (cached) yes
> configure: WARNING: ***
> configure: WARNING: *** OpenSSL required when using libsrtp2, checking for libsrtp instead.
> configure: WARNING: ***
> 
> using this defconfig:
> 
> BR2_PACKAGE_LIBSRTP=y
> BR2_PACKAGE_ASTERISK=y
> 
> Please note that openssl support in libsrtp is not available for static
> builds:
> https://git.buildroot.net/buildroot/tree/package/libsrtp/libsrtp.mk#n27
> 
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> v3: no changes
> v2: Added comment in commit log about libsrtp dependencies (Thomas)

Applied to master, thanks.

Thomas
Peter Korsgaard Dec. 16, 2018, 8:02 p.m. UTC | #3
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Sun, 14 Oct 2018 11:01:54 +0200, Bernd Kuhls wrote:
 >> Fixes configure error
 >> 
 >> checking for the ability of -lsrtp2 to be linked in a shared object... yes
 >> checking for srtp_crypto_policy_set_aes_cm_256_hmac_sha1_80 in -lsrtp2... yes
 >> checking for srtp_crypto_policy_set_aes_cm_192_hmac_sha1_80 in -lsrtp2... no
 >> checking for srtp_crypto_policy_set_aes_gcm_128_8_auth in -lsrtp2... no
 >> checking for srtp_shutdown in -lsrtp2... yes
 >> checking for srtp2/srtp.h... (cached) yes
 >> configure: WARNING: ***
 >> configure: WARNING: *** OpenSSL required when using libsrtp2, checking for libsrtp instead.
 >> configure: WARNING: ***
 >> 
 >> using this defconfig:
 >> 
 >> BR2_PACKAGE_LIBSRTP=y
 >> BR2_PACKAGE_ASTERISK=y
 >> 
 >> Please note that openssl support in libsrtp is not available for static
 >> builds:
 >> https://git.buildroot.net/buildroot/tree/package/libsrtp/libsrtp.mk#n27
 >> 
 >> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
 >> ---
 >> v3: no changes
 >> v2: Added comment in commit log about libsrtp dependencies (Thomas)

Committed to 2018.11.x, thanks.
diff mbox series

Patch

diff --git a/package/asterisk/asterisk.mk b/package/asterisk/asterisk.mk
index 4ed85743b0..6de498ed07 100644
--- a/package/asterisk/asterisk.mk
+++ b/package/asterisk/asterisk.mk
@@ -242,7 +242,8 @@  else
 ASTERISK_CONF_OPTS += --without-speex  --without-speexdsp
 endif
 
-ifeq ($(BR2_PACKAGE_LIBSRTP),y)
+# asterisk needs an openssl-enabled libsrtp
+ifeq ($(BR2_PACKAGE_LIBSRTP)$(BR2_PACKAGE_OPENSSL)x$(BR2_STATIC_LIBS),yyx)
 ASTERISK_DEPENDENCIES += libsrtp
 ASTERISK_CONF_OPTS += --with-srtp
 else