| Message ID | 20180322202007.23088-3-malat@debian.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/ppc32: make W=1 compilation errors free | expand |
Le 22/03/2018 à 21:19, Mathieu Malaterre a écrit : > Since the value of x is never intended to be read, declare it with gcc > attribute as unused. Fix warning treated as error with W=1: > > arch/powerpc/platforms/powermac/udbg_scc.c:76:9: error: variable ‘x’ set but not used [-Werror=unused-but-set-variable] > > Signed-off-by: Mathieu Malaterre <malat@debian.org> > --- > arch/powerpc/platforms/powermac/udbg_scc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/powerpc/platforms/powermac/udbg_scc.c b/arch/powerpc/platforms/powermac/udbg_scc.c > index d83135a9830e..c38ca406df1a 100644 > --- a/arch/powerpc/platforms/powermac/udbg_scc.c > +++ b/arch/powerpc/platforms/powermac/udbg_scc.c > @@ -73,7 +73,7 @@ void udbg_scc_init(int force_scc) > struct device_node *stdout = NULL, *escc = NULL, *macio = NULL; > struct device_node *ch, *ch_def = NULL, *ch_a = NULL; > const char *path; > - int i, x; > + int i, x __maybe_unused; You could just replace 'x = in_8(sccc)' by 'in_8(sccc)' and get rid of the x. Christophe > > escc = of_find_node_by_name(NULL, "escc"); > if (escc == NULL) > --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus
diff --git a/arch/powerpc/platforms/powermac/udbg_scc.c b/arch/powerpc/platforms/powermac/udbg_scc.c index d83135a9830e..c38ca406df1a 100644 --- a/arch/powerpc/platforms/powermac/udbg_scc.c +++ b/arch/powerpc/platforms/powermac/udbg_scc.c @@ -73,7 +73,7 @@ void udbg_scc_init(int force_scc) struct device_node *stdout = NULL, *escc = NULL, *macio = NULL; struct device_node *ch, *ch_def = NULL, *ch_a = NULL; const char *path; - int i, x; + int i, x __maybe_unused; escc = of_find_node_by_name(NULL, "escc"); if (escc == NULL)
Since the value of x is never intended to be read, declare it with gcc attribute as unused. Fix warning treated as error with W=1: arch/powerpc/platforms/powermac/udbg_scc.c:76:9: error: variable ‘x’ set but not used [-Werror=unused-but-set-variable] Signed-off-by: Mathieu Malaterre <malat@debian.org> --- arch/powerpc/platforms/powermac/udbg_scc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)