| Message ID | 20180322202007.23088-16-malat@debian.org (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | powerpc/ppc32: make W=1 compilation errors free | expand |
Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit : > Add one missing prototype for function rh_dump_blk. Fix warning treated as > error in W=1: > > arch/powerpc/lib/rheap.c:740:6: error: no previous prototype for ‘rh_dump_blk’ [-Werror=missing-prototypes] > > Signed-off-by: Mathieu Malaterre <malat@debian.org> > --- > arch/powerpc/include/asm/rheap.h | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/arch/powerpc/include/asm/rheap.h b/arch/powerpc/include/asm/rheap.h > index 172381769cfc..e75d96de19a0 100644 > --- a/arch/powerpc/include/asm/rheap.h > +++ b/arch/powerpc/include/asm/rheap.h > @@ -83,6 +83,9 @@ extern int rh_get_stats(rh_info_t * info, int what, int max_stats, > /* Simple dump of remote heap info */ > extern void rh_dump(rh_info_t * info); > > +/* Simple dump of remote info block */ > +extern void rh_dump_blk(rh_info_t *info, rh_block_t *blk); > + Only used in one place, should be static Christophe > /* Set owner of taken block */ > extern int rh_set_owner(rh_info_t * info, unsigned long start, const char *owner); > > --- L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast. https://www.avast.com/antivirus
On Fri, Mar 23, 2018 at 1:20 PM, christophe leroy <christophe.leroy@c-s.fr> wrote: > > > Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit : >> >> Add one missing prototype for function rh_dump_blk. Fix warning treated as >> error in W=1: >> >> arch/powerpc/lib/rheap.c:740:6: error: no previous prototype for >> ‘rh_dump_blk’ [-Werror=missing-prototypes] >> >> Signed-off-by: Mathieu Malaterre <malat@debian.org> >> --- >> arch/powerpc/include/asm/rheap.h | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/arch/powerpc/include/asm/rheap.h >> b/arch/powerpc/include/asm/rheap.h >> index 172381769cfc..e75d96de19a0 100644 >> --- a/arch/powerpc/include/asm/rheap.h >> +++ b/arch/powerpc/include/asm/rheap.h >> @@ -83,6 +83,9 @@ extern int rh_get_stats(rh_info_t * info, int what, int >> max_stats, >> /* Simple dump of remote heap info */ >> extern void rh_dump(rh_info_t * info); >> +/* Simple dump of remote info block */ >> +extern void rh_dump_blk(rh_info_t *info, rh_block_t *blk); >> + > > > Only used in one place, should be static Well here is what I see over here: $ git grep rh_dump_blk ... arch/powerpc/lib/rheap.c:EXPORT_SYMBOL_GPL(rh_dump_blk); > Christophe > >> /* Set owner of taken block */ >> extern int rh_set_owner(rh_info_t * info, unsigned long start, const >> char *owner); >> > > > --- > L'absence de virus dans ce courrier électronique a été vérifiée par le > logiciel antivirus Avast. > https://www.avast.com/antivirus >
Mathieu Malaterre <malat@debian.org> a écrit : > On Fri, Mar 23, 2018 at 1:20 PM, christophe leroy > <christophe.leroy@c-s.fr> wrote: >> >> >> Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit : >>> >>> Add one missing prototype for function rh_dump_blk. Fix warning treated as >>> error in W=1: >>> >>> arch/powerpc/lib/rheap.c:740:6: error: no previous prototype for >>> ‘rh_dump_blk’ [-Werror=missing-prototypes] >>> >>> Signed-off-by: Mathieu Malaterre <malat@debian.org> >>> --- >>> arch/powerpc/include/asm/rheap.h | 3 +++ >>> 1 file changed, 3 insertions(+) >>> >>> diff --git a/arch/powerpc/include/asm/rheap.h >>> b/arch/powerpc/include/asm/rheap.h >>> index 172381769cfc..e75d96de19a0 100644 >>> --- a/arch/powerpc/include/asm/rheap.h >>> +++ b/arch/powerpc/include/asm/rheap.h >>> @@ -83,6 +83,9 @@ extern int rh_get_stats(rh_info_t * info, int what, int >>> max_stats, >>> /* Simple dump of remote heap info */ >>> extern void rh_dump(rh_info_t * info); >>> +/* Simple dump of remote info block */ >>> +extern void rh_dump_blk(rh_info_t *info, rh_block_t *blk); >>> + >> >> >> Only used in one place, should be static > > Well here is what I see over here: > > $ git grep rh_dump_blk > ... > arch/powerpc/lib/rheap.c:EXPORT_SYMBOL_GPL(rh_dump_blk); If it was really used by anybody in a module, it would already be in a .h so I think we should simply delete the function Christophe > > > >> Christophe >> >>> /* Set owner of taken block */ >>> extern int rh_set_owner(rh_info_t * info, unsigned long start, const >>> char *owner); >>> >> >> >> --- >> L'absence de virus dans ce courrier électronique a été vérifiée par le >> logiciel antivirus Avast. >> https://www.avast.com/antivirus >>
On Thu, Mar 29, 2018 at 6:02 PM, LEROY Christophe <christophe.leroy@c-s.fr> wrote: > Mathieu Malaterre <malat@debian.org> a écrit : > > >> On Fri, Mar 23, 2018 at 1:20 PM, christophe leroy >> <christophe.leroy@c-s.fr> wrote: >>> >>> >>> >>> Le 22/03/2018 à 21:20, Mathieu Malaterre a écrit : >>>> >>>> >>>> Add one missing prototype for function rh_dump_blk. Fix warning treated >>>> as >>>> error in W=1: >>>> >>>> arch/powerpc/lib/rheap.c:740:6: error: no previous prototype for >>>> ‘rh_dump_blk’ [-Werror=missing-prototypes] >>>> >>>> Signed-off-by: Mathieu Malaterre <malat@debian.org> >>>> --- >>>> arch/powerpc/include/asm/rheap.h | 3 +++ >>>> 1 file changed, 3 insertions(+) >>>> >>>> diff --git a/arch/powerpc/include/asm/rheap.h >>>> b/arch/powerpc/include/asm/rheap.h >>>> index 172381769cfc..e75d96de19a0 100644 >>>> --- a/arch/powerpc/include/asm/rheap.h >>>> +++ b/arch/powerpc/include/asm/rheap.h >>>> @@ -83,6 +83,9 @@ extern int rh_get_stats(rh_info_t * info, int what, >>>> int >>>> max_stats, >>>> /* Simple dump of remote heap info */ >>>> extern void rh_dump(rh_info_t * info); >>>> +/* Simple dump of remote info block */ >>>> +extern void rh_dump_blk(rh_info_t *info, rh_block_t *blk); >>>> + >>> >>> >>> >>> Only used in one place, should be static >> >> >> Well here is what I see over here: >> >> $ git grep rh_dump_blk >> ... >> arch/powerpc/lib/rheap.c:EXPORT_SYMBOL_GPL(rh_dump_blk); > > > If it was really used by anybody in a module, it would already be in a .h so > I think we should simply delete the function > Sent a v3 without the extern keyword. I did not feel bold enough to remove completely a function. Could one of the maintainers confirm removal of the function ? > Christophe > > >> >> >> >>> Christophe >>> >>>> /* Set owner of taken block */ >>>> extern int rh_set_owner(rh_info_t * info, unsigned long start, const >>>> char *owner); >>>> >>> >>> >>> --- >>> L'absence de virus dans ce courrier électronique a été vérifiée par le >>> logiciel antivirus Avast. >>> https://www.avast.com/antivirus >>> > >
diff --git a/arch/powerpc/include/asm/rheap.h b/arch/powerpc/include/asm/rheap.h index 172381769cfc..e75d96de19a0 100644 --- a/arch/powerpc/include/asm/rheap.h +++ b/arch/powerpc/include/asm/rheap.h @@ -83,6 +83,9 @@ extern int rh_get_stats(rh_info_t * info, int what, int max_stats, /* Simple dump of remote heap info */ extern void rh_dump(rh_info_t * info); +/* Simple dump of remote info block */ +extern void rh_dump_blk(rh_info_t *info, rh_block_t *blk); + /* Set owner of taken block */ extern int rh_set_owner(rh_info_t * info, unsigned long start, const char *owner);
Add one missing prototype for function rh_dump_blk. Fix warning treated as error in W=1: arch/powerpc/lib/rheap.c:740:6: error: no previous prototype for ‘rh_dump_blk’ [-Werror=missing-prototypes] Signed-off-by: Mathieu Malaterre <malat@debian.org> --- arch/powerpc/include/asm/rheap.h | 3 +++ 1 file changed, 3 insertions(+)