diff mbox series

[U-Boot] MPC8315ERDB: Enable DHCP support

Message ID 20180304181752.20009-1-marex@denx.de
State Accepted
Commit 1bb34c8b89704a346a10cc1e34c9f9114a98658c
Delegated to: Tom Rini
Headers show
Series [U-Boot] MPC8315ERDB: Enable DHCP support | expand

Commit Message

Marek Vasut March 4, 2018, 6:17 p.m. UTC 
Enable DHCP support for this board.

Signed-off-by: Marek Vasut <marex@denx.de>
From: Ed Bartosh <ed.bartosh@linux.intel.com>
Cc: Tom Rini <trini@konsulko.com>
---
NOTE: This patch is here just to get rid of extra patches in OE
      recipes. This is the last one we have pending there.
---
 configs/MPC8315ERDB_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Fabio Estevam March 4, 2018, 7:35 p.m. UTC | #1 
Hi Marek,

On Sun, Mar 4, 2018 at 3:17 PM, Marek Vasut <marex@denx.de> wrote:
> Enable DHCP support for this board.
>
> Signed-off-by: Marek Vasut <marex@denx.de>
> From: Ed Bartosh <ed.bartosh@linux.intel.com>

The From line should be the first one.

Then a Signed-off-by tag from Ed should also be present, followed by yours.
Tom Rini March 5, 2018, 12:27 p.m. UTC | #2 
On Sun, Mar 04, 2018 at 04:35:29PM -0300, Fabio Estevam wrote:
> Hi Marek,
> 
> On Sun, Mar 4, 2018 at 3:17 PM, Marek Vasut <marex@denx.de> wrote:
> > Enable DHCP support for this board.
> >
> > Signed-off-by: Marek Vasut <marex@denx.de>
> > From: Ed Bartosh <ed.bartosh@linux.intel.com>
> 
> The From line should be the first one.
> 
> Then a Signed-off-by tag from Ed should also be present, followed by yours.

For the record, the OpenEmebedded version of this patch has Ed's S-o-B:
http://git.openembedded.org/openembedded-core/tree/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
Marek Vasut March 5, 2018, 12:32 p.m. UTC | #3 
On 03/05/2018 01:27 PM, Tom Rini wrote:
> On Sun, Mar 04, 2018 at 04:35:29PM -0300, Fabio Estevam wrote:
>> Hi Marek,
>>
>> On Sun, Mar 4, 2018 at 3:17 PM, Marek Vasut <marex@denx.de> wrote:
>>> Enable DHCP support for this board.
>>>
>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>> From: Ed Bartosh <ed.bartosh@linux.intel.com>
>>
>> The From line should be the first one.
>>
>> Then a Signed-off-by tag from Ed should also be present, followed by yours.
> 
> For the record, the OpenEmebedded version of this patch has Ed's S-o-B:
> http://git.openembedded.org/openembedded-core/tree/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch

Do we retain that even if he's not communicating since forever ?
Tom Rini March 5, 2018, 1:57 p.m. UTC | #4 
On Mon, Mar 05, 2018 at 01:32:23PM +0100, Marek Vasut wrote:
> On 03/05/2018 01:27 PM, Tom Rini wrote:
> > On Sun, Mar 04, 2018 at 04:35:29PM -0300, Fabio Estevam wrote:
> >> Hi Marek,
> >>
> >> On Sun, Mar 4, 2018 at 3:17 PM, Marek Vasut <marex@denx.de> wrote:
> >>> Enable DHCP support for this board.
> >>>
> >>> Signed-off-by: Marek Vasut <marex@denx.de>
> >>> From: Ed Bartosh <ed.bartosh@linux.intel.com>
> >>
> >> The From line should be the first one.
> >>
> >> Then a Signed-off-by tag from Ed should also be present, followed by yours.
> > 
> > For the record, the OpenEmebedded version of this patch has Ed's S-o-B:
> > http://git.openembedded.org/openembedded-core/tree/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
> 
> Do we retain that even if he's not communicating since forever ?

Yes, it's his patch.
Marek Vasut March 5, 2018, 1:59 p.m. UTC | #5 
On 03/05/2018 02:57 PM, Tom Rini wrote:
> On Mon, Mar 05, 2018 at 01:32:23PM +0100, Marek Vasut wrote:
>> On 03/05/2018 01:27 PM, Tom Rini wrote:
>>> On Sun, Mar 04, 2018 at 04:35:29PM -0300, Fabio Estevam wrote:
>>>> Hi Marek,
>>>>
>>>> On Sun, Mar 4, 2018 at 3:17 PM, Marek Vasut <marex@denx.de> wrote:
>>>>> Enable DHCP support for this board.
>>>>>
>>>>> Signed-off-by: Marek Vasut <marex@denx.de>
>>>>> From: Ed Bartosh <ed.bartosh@linux.intel.com>
>>>>
>>>> The From line should be the first one.
>>>>
>>>> Then a Signed-off-by tag from Ed should also be present, followed by yours.
>>>
>>> For the record, the OpenEmebedded version of this patch has Ed's S-o-B:
>>> http://git.openembedded.org/openembedded-core/tree/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
>>
>> Do we retain that even if he's not communicating since forever ?
> 
> Yes, it's his patch.

OK
Tom Rini March 5, 2018, 6:54 p.m. UTC | #6 
On Sun, Mar 04, 2018 at 07:17:52PM +0100, Marek Vasut wrote:

> From: Ed Bartosh <ed.bartosh@linux.intel.com>
> 
> Enable DHCP support for this board.
> 
> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
> Signed-off-by: Marek Vasut <marex@denx.de>
> Signed-off-by: Tom Rini <trini@konsulko.com>

Applied to u-boot/master, thanks!
Marek Vasut March 5, 2018, 7:07 p.m. UTC | #7 
On 03/05/2018 07:54 PM, Tom Rini wrote:
> On Sun, Mar 04, 2018 at 07:17:52PM +0100, Marek Vasut wrote:
> 
>> From: Ed Bartosh <ed.bartosh@linux.intel.com>
>>
>> Enable DHCP support for this board.
>>
>> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
>> Signed-off-by: Marek Vasut <marex@denx.de>
>> Signed-off-by: Tom Rini <trini@konsulko.com>
> 
> Applied to u-boot/master, thanks!

Much appreciated, thanks.
diff mbox series

Patch

diff --git a/configs/MPC8315ERDB_defconfig b/configs/MPC8315ERDB_defconfig
index c931624bf0..e6f9224141 100644
--- a/configs/MPC8315ERDB_defconfig
+++ b/configs/MPC8315ERDB_defconfig
@@ -13,6 +13,7 @@  CONFIG_CMD_PCI=y
 CONFIG_CMD_SATA=y
 CONFIG_CMD_USB=y
 # CONFIG_CMD_SETEXPR is not set
+CONFIG_CMD_DHCP=y
 CONFIG_CMD_MII=y
 CONFIG_CMD_PING=y
 CONFIG_CMD_DATE=y