Message ID | 20180304181752.20009-1-marex@denx.de |
---|---|
State | Accepted |
Commit | 1bb34c8b89704a346a10cc1e34c9f9114a98658c |
Delegated to: | Tom Rini |
Headers | show |
Series | [U-Boot] MPC8315ERDB: Enable DHCP support | expand |
Hi Marek, On Sun, Mar 4, 2018 at 3:17 PM, Marek Vasut <marex@denx.de> wrote: > Enable DHCP support for this board. > > Signed-off-by: Marek Vasut <marex@denx.de> > From: Ed Bartosh <ed.bartosh@linux.intel.com> The From line should be the first one. Then a Signed-off-by tag from Ed should also be present, followed by yours.
On Sun, Mar 04, 2018 at 04:35:29PM -0300, Fabio Estevam wrote: > Hi Marek, > > On Sun, Mar 4, 2018 at 3:17 PM, Marek Vasut <marex@denx.de> wrote: > > Enable DHCP support for this board. > > > > Signed-off-by: Marek Vasut <marex@denx.de> > > From: Ed Bartosh <ed.bartosh@linux.intel.com> > > The From line should be the first one. > > Then a Signed-off-by tag from Ed should also be present, followed by yours. For the record, the OpenEmebedded version of this patch has Ed's S-o-B: http://git.openembedded.org/openembedded-core/tree/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch
On 03/05/2018 01:27 PM, Tom Rini wrote: > On Sun, Mar 04, 2018 at 04:35:29PM -0300, Fabio Estevam wrote: >> Hi Marek, >> >> On Sun, Mar 4, 2018 at 3:17 PM, Marek Vasut <marex@denx.de> wrote: >>> Enable DHCP support for this board. >>> >>> Signed-off-by: Marek Vasut <marex@denx.de> >>> From: Ed Bartosh <ed.bartosh@linux.intel.com> >> >> The From line should be the first one. >> >> Then a Signed-off-by tag from Ed should also be present, followed by yours. > > For the record, the OpenEmebedded version of this patch has Ed's S-o-B: > http://git.openembedded.org/openembedded-core/tree/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch Do we retain that even if he's not communicating since forever ?
On Mon, Mar 05, 2018 at 01:32:23PM +0100, Marek Vasut wrote: > On 03/05/2018 01:27 PM, Tom Rini wrote: > > On Sun, Mar 04, 2018 at 04:35:29PM -0300, Fabio Estevam wrote: > >> Hi Marek, > >> > >> On Sun, Mar 4, 2018 at 3:17 PM, Marek Vasut <marex@denx.de> wrote: > >>> Enable DHCP support for this board. > >>> > >>> Signed-off-by: Marek Vasut <marex@denx.de> > >>> From: Ed Bartosh <ed.bartosh@linux.intel.com> > >> > >> The From line should be the first one. > >> > >> Then a Signed-off-by tag from Ed should also be present, followed by yours. > > > > For the record, the OpenEmebedded version of this patch has Ed's S-o-B: > > http://git.openembedded.org/openembedded-core/tree/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch > > Do we retain that even if he's not communicating since forever ? Yes, it's his patch.
On 03/05/2018 02:57 PM, Tom Rini wrote: > On Mon, Mar 05, 2018 at 01:32:23PM +0100, Marek Vasut wrote: >> On 03/05/2018 01:27 PM, Tom Rini wrote: >>> On Sun, Mar 04, 2018 at 04:35:29PM -0300, Fabio Estevam wrote: >>>> Hi Marek, >>>> >>>> On Sun, Mar 4, 2018 at 3:17 PM, Marek Vasut <marex@denx.de> wrote: >>>>> Enable DHCP support for this board. >>>>> >>>>> Signed-off-by: Marek Vasut <marex@denx.de> >>>>> From: Ed Bartosh <ed.bartosh@linux.intel.com> >>>> >>>> The From line should be the first one. >>>> >>>> Then a Signed-off-by tag from Ed should also be present, followed by yours. >>> >>> For the record, the OpenEmebedded version of this patch has Ed's S-o-B: >>> http://git.openembedded.org/openembedded-core/tree/meta/recipes-bsp/u-boot/files/MPC8315ERDB-enable-DHCP.patch >> >> Do we retain that even if he's not communicating since forever ? > > Yes, it's his patch. OK
On Sun, Mar 04, 2018 at 07:17:52PM +0100, Marek Vasut wrote: > From: Ed Bartosh <ed.bartosh@linux.intel.com> > > Enable DHCP support for this board. > > Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> > Signed-off-by: Marek Vasut <marex@denx.de> > Signed-off-by: Tom Rini <trini@konsulko.com> Applied to u-boot/master, thanks!
On 03/05/2018 07:54 PM, Tom Rini wrote: > On Sun, Mar 04, 2018 at 07:17:52PM +0100, Marek Vasut wrote: > >> From: Ed Bartosh <ed.bartosh@linux.intel.com> >> >> Enable DHCP support for this board. >> >> Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com> >> Signed-off-by: Marek Vasut <marex@denx.de> >> Signed-off-by: Tom Rini <trini@konsulko.com> > > Applied to u-boot/master, thanks! Much appreciated, thanks.
diff --git a/configs/MPC8315ERDB_defconfig b/configs/MPC8315ERDB_defconfig index c931624bf0..e6f9224141 100644 --- a/configs/MPC8315ERDB_defconfig +++ b/configs/MPC8315ERDB_defconfig @@ -13,6 +13,7 @@ CONFIG_CMD_PCI=y CONFIG_CMD_SATA=y CONFIG_CMD_USB=y # CONFIG_CMD_SETEXPR is not set +CONFIG_CMD_DHCP=y CONFIG_CMD_MII=y CONFIG_CMD_PING=y CONFIG_CMD_DATE=y