| Message ID | 20171223190617.3981-3-alexander.i.mukhin@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | hostapd: new configuration options | expand |
Hello Alexander, > Add configuration options for hostapd to select which > drivers to build. > > Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com> [...] > +comment "at least one driver must be selected" > + depends on !BR2_PACKAGE_HOSTAPD_DRIVER_HOSTAP > + depends on !BR2_PACKAGE_HOSTAPD_DRIVER_NL80211 > + depends on !BR2_PACKAGE_HOSTAPD_DRIVER_RTW > + Does it makes sense to enforce enablement of at least one driver ? Another option would be to add DRIVER_NONE to the list of drivers, and enable it by default if no other actual wired/wireless driver has been selected. According to example hostapd.conf only 'none' driver is needed if hostapd is built as a standalone RADIUS server. Regards, Sergey
Hello Sergey, > Does it makes sense to enforce enablement of at least one driver ? > > Another option would be to add DRIVER_NONE to the list of drivers, > and enable it by default if no other actual wired/wireless driver > has been selected. According to example hostapd.conf only 'none' > driver is needed if hostapd is built as a standalone RADIUS server. Yes, I agree with you. I'll send a patch for that.
Hello, On Sat, 23 Dec 2017 22:06:15 +0300, Alexander Mukhin wrote: > Add configuration options for hostapd to select which > drivers to build. > > Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com> Since you got some feedback on this patch, could you send a new iteration of your hostapd series ? It should also include the two other patches you sent as a separate series, to be clearer. Thanks! Thomas
diff --git a/package/hostapd/Config.in b/package/hostapd/Config.in index 84156e8f11..509797a44a 100644 --- a/package/hostapd/Config.in +++ b/package/hostapd/Config.in @@ -14,11 +14,28 @@ config BR2_PACKAGE_HOSTAPD if BR2_PACKAGE_HOSTAPD +config BR2_PACKAGE_HOSTAPD_DRIVER_HOSTAP + bool "Enable hostap driver" + default y + help + Enable support for Host AP driver. + +config BR2_PACKAGE_HOSTAPD_DRIVER_NL80211 + bool "Enable nl80211 driver" + default y + help + Enable support for drivers using the nl80211 kernel interface. + config BR2_PACKAGE_HOSTAPD_DRIVER_RTW bool "Enable rtl871xdrv driver" help Enable support for Realtek wireless chips. +comment "at least one driver must be selected" + depends on !BR2_PACKAGE_HOSTAPD_DRIVER_HOSTAP + depends on !BR2_PACKAGE_HOSTAPD_DRIVER_NL80211 + depends on !BR2_PACKAGE_HOSTAPD_DRIVER_RTW + config BR2_PACKAGE_HOSTAPD_ACS bool "Enable ACS" default y diff --git a/package/hostapd/hostapd.mk b/package/hostapd/hostapd.mk index 04ffa35758..143efe9627 100644 --- a/package/hostapd/hostapd.mk +++ b/package/hostapd/hostapd.mk @@ -45,6 +45,14 @@ HOSTAPD_CONFIG_DISABLE += CONFIG_EAP_PWD HOSTAPD_CONFIG_EDITS += 's/\#\(CONFIG_TLS=\).*/\1internal/' endif +ifneq ($(BR2_PACKAGE_HOSTAPD_DRIVER_HOSTAP),y) +HOSTAPD_CONFIG_DISABLE += CONFIG_DRIVER_HOSTAP +endif + +ifneq ($(BR2_PACKAGE_HOSTAPD_DRIVER_NL80211),y) +HOSTAPD_CONFIG_DISABLE += CONFIG_DRIVER_NL80211 +endif + ifeq ($(BR2_PACKAGE_HOSTAPD_DRIVER_RTW),y) HOSTAPD_PATCH += https://github.com/pritambaral/hostapd-rtl871xdrv/raw/master/rtlxdrv.patch HOSTAPD_CONFIG_SET += CONFIG_DRIVER_RTW
Add configuration options for hostapd to select which drivers to build. Signed-off-by: Alexander Mukhin <alexander.i.mukhin@gmail.com> --- package/hostapd/Config.in | 17 +++++++++++++++++ package/hostapd/hostapd.mk | 8 ++++++++ 2 files changed, 25 insertions(+)