| Message ID | 20171130111122.7774-1-gary.bisson@boundarydevices.com |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [NEXT] gst1-imx: add missing dependency for imxv4l2videosink plugin | expand |
Hello, On Thu, 30 Nov 2017 12:11:22 +0100, Gary Bisson wrote: > The plugin source code uses V4L2_COLORSPACE_DEFAULT macro which was > defined in kernel 4.2, so make sure the toolchain headers match this > requirement. > > Fixes: > http://autobuild.buildroot.net/results/48dd782161fa5e8860b5ea00a5d60207cb623108/ > http://autobuild.buildroot.net/results/f970c782b5bfbcf66ff3ba200b060d3653ff2630/ > > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > --- > package/gstreamer1/gst1-imx/Config.in | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/gstreamer1/gst1-imx/Config.in b/package/gstreamer1/gst1-imx/Config.in > index 9b977bdde8..cedd917019 100644 > --- a/package/gstreamer1/gst1-imx/Config.in > +++ b/package/gstreamer1/gst1-imx/Config.in > @@ -87,6 +87,7 @@ config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC > config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSINK > bool "imxv4l2videosink" > select BR2_PACKAGE_GST1_PLUGINS_BAD > + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 Thanks! However you need to add the corresponding Config.in comment. Thomas
Hi Thomas, On Thu, Nov 30, 2017 at 01:41:54PM +0100, Thomas Petazzoni wrote: > Hello, > > On Thu, 30 Nov 2017 12:11:22 +0100, Gary Bisson wrote: > > The plugin source code uses V4L2_COLORSPACE_DEFAULT macro which was > > defined in kernel 4.2, so make sure the toolchain headers match this > > requirement. > > > > Fixes: > > http://autobuild.buildroot.net/results/48dd782161fa5e8860b5ea00a5d60207cb623108/ > > http://autobuild.buildroot.net/results/f970c782b5bfbcf66ff3ba200b060d3653ff2630/ > > > > Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> > > --- > > package/gstreamer1/gst1-imx/Config.in | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/package/gstreamer1/gst1-imx/Config.in b/package/gstreamer1/gst1-imx/Config.in > > index 9b977bdde8..cedd917019 100644 > > --- a/package/gstreamer1/gst1-imx/Config.in > > +++ b/package/gstreamer1/gst1-imx/Config.in > > @@ -87,6 +87,7 @@ config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC > > config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSINK > > bool "imxv4l2videosink" > > select BR2_PACKAGE_GST1_PLUGINS_BAD > > + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 > > Thanks! However you need to add the corresponding Config.in comment. Is a simple mention of the macro sufficient? depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 # V4L2_COLORSPACE_DEFAULT Or would rather have a full sentence above the 'depends'? Regards, Gary
Hello, On Thu, 30 Nov 2017 14:47:05 +0100, Gary Bisson wrote: > > Thanks! However you need to add the corresponding Config.in comment. > > Is a simple mention of the macro sufficient? > depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 # V4L2_COLORSPACE_DEFAULT > > Or would rather have a full sentence above the 'depends'? I'm talking about a Config.in comment, i.e comment "feature foobaz needs kernel headers >= 4.2" depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 Thomas
Hi Thomas, On Thu, Nov 30, 2017 at 02:57:38PM +0100, Thomas Petazzoni wrote: > Hello, > > On Thu, 30 Nov 2017 14:47:05 +0100, Gary Bisson wrote: > > > > Thanks! However you need to add the corresponding Config.in comment. > > > > Is a simple mention of the macro sufficient? > > depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 # V4L2_COLORSPACE_DEFAULT > > > > Or would rather have a full sentence above the 'depends'? > > I'm talking about a Config.in comment, i.e > > comment "feature foobaz needs kernel headers >= 4.2" > depends on !BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 Right, completely forgot about that. I'll submit a v2 in no time. Thanks, Gary
diff --git a/package/gstreamer1/gst1-imx/Config.in b/package/gstreamer1/gst1-imx/Config.in index 9b977bdde8..cedd917019 100644 --- a/package/gstreamer1/gst1-imx/Config.in +++ b/package/gstreamer1/gst1-imx/Config.in @@ -87,6 +87,7 @@ config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSRC config BR2_PACKAGE_GST1_IMX_V4L2VIDEOSINK bool "imxv4l2videosink" select BR2_PACKAGE_GST1_PLUGINS_BAD + depends on BR2_TOOLCHAIN_HEADERS_AT_LEAST_4_2 help Elements for V4L2 output
The plugin source code uses V4L2_COLORSPACE_DEFAULT macro which was defined in kernel 4.2, so make sure the toolchain headers match this requirement. Fixes: http://autobuild.buildroot.net/results/48dd782161fa5e8860b5ea00a5d60207cb623108/ http://autobuild.buildroot.net/results/f970c782b5bfbcf66ff3ba200b060d3653ff2630/ Signed-off-by: Gary Bisson <gary.bisson@boundarydevices.com> --- package/gstreamer1/gst1-imx/Config.in | 1 + 1 file changed, 1 insertion(+)