diff mbox series

[v1] gdb: prevent installation of libbfd.so

Message ID 20171027180214.12657-1-ps.report@gmx.net
State Changes Requested
Headers show
Series [v1] gdb: prevent installation of libbfd.so | expand

Commit Message

Peter Seiderer Oct. 27, 2017, 6:02 p.m. UTC
Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
For a previous discussion on this topic see [1].

[1] http://lists.busybox.net/pipermail/buildroot/2017-September/202337.html
---
 package/gdb/gdb.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Petazzoni Oct. 28, 2017, 1:40 p.m. UTC | #1
Hello,

On Fri, 27 Oct 2017 20:02:14 +0200, Peter Seiderer wrote:
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

We really want a more detailed commit log for such a change that isn't
obvious.

> For a previous discussion on this topic see [1].
> 
> [1] http://lists.busybox.net/pipermail/buildroot/2017-September/202337.html

I know this link provides some details, but they should be in the
commit log.

Thanks!

Thomas
Thomas Petazzoni Nov. 29, 2017, 10:48 p.m. UTC | #2
Hello Peter,

On Sat, 28 Oct 2017 15:40:33 +0200, Thomas Petazzoni wrote:
> On Fri, 27 Oct 2017 20:02:14 +0200, Peter Seiderer wrote:
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>  
> 
> We really want a more detailed commit log for such a change that isn't
> obvious.
> 
> > For a previous discussion on this topic see [1].
> > 
> > [1] http://lists.busybox.net/pipermail/buildroot/2017-September/202337.html  
> 
> I know this link provides some details, but they should be in the
> commit log.

Ping ? :-)

I'll mark this patch as Changes Requested.

Thanks!

Thomas
Peter Seiderer Dec. 8, 2017, 9:32 p.m. UTC | #3
Hello Thomas,

On Wed, 29 Nov 2017 23:48:18 +0100, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote:

> Hello Peter,
> 
> On Sat, 28 Oct 2017 15:40:33 +0200, Thomas Petazzoni wrote:
> > On Fri, 27 Oct 2017 20:02:14 +0200, Peter Seiderer wrote:  
> > > Signed-off-by: Peter Seiderer <ps.report@gmx.net>    
> > 
> > We really want a more detailed commit log for such a change that isn't
> > obvious.
> >   
> > > For a previous discussion on this topic see [1].
> > > 
> > > [1] http://lists.busybox.net/pipermail/buildroot/2017-September/202337.html    
> > 
> > I know this link provides some details, but they should be in the
> > commit log.  
> 
> Ping ? :-)

Sorry, for the delay (not enough spare time for buildroot stuff at the moment)...

Just sent a new version of the patch...

Regards,
Peter

> 
> I'll mark this patch as Changes Requested.
> 
> Thanks!
> 
> Thomas
diff mbox series

Patch

diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
index 7e86ba0c7e..8c4188b1fe 100644
--- a/package/gdb/gdb.mk
+++ b/package/gdb/gdb.mk
@@ -111,7 +111,7 @@  GDB_CONF_OPTS = \
 	--with-curses \
 	--without-included-gettext \
 	--disable-werror \
-	--enable-static
+	--enable-static --disable-shared
 
 # When gdb is built as C++ application for ARC it segfaults at runtime
 # So we pass --disable-build-with-cxx config option to force gdb not to