| Message ID | 20171011131539.19407-1-ps.report@gmx.net |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1] wiringpi: bump version to 96344ff7125182989f98d3be8d111952a8f74e15 (the real 2.44) | expand |
Hello, On Wed, 11 Oct 2017 15:15:39 +0200, Peter Seiderer wrote: > Fixes bug 10391 [1]. > > [1] https://bugs.busybox.net/show_bug.cgi?id=10391 > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> I don't think it really fixes bug 10391. Bug 10391 is bogus by itself. The update to 96344ff7125182989f98d3be8d111952a8f74e15 doesn't fix anything, it only adds support for RPi Zero W. Thomas
Hello Thomas, On Wed, 11 Oct 2017 15:59:32 +0200, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Wed, 11 Oct 2017 15:15:39 +0200, Peter Seiderer wrote: > > Fixes bug 10391 [1]. > > > > [1] https://bugs.busybox.net/show_bug.cgi?id=10391 > > > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > > I don't think it really fixes bug 10391. Bug 10391 is bogus by itself. > The update to 96344ff7125182989f98d3be8d111952a8f74e15 doesn't fix > anything, it only adds support for RPi Zero W. Saving a download as wiringpi-2.44.tar.gz containing something identifying itself as 2.42? I would call it a bug (not on the buildroot side but in the original git repository). The suggested patch fixes the original complain of Bug 10391: 'WiringPi retrieves wrong (old) version' Any suggestion on how to reference the bug report otherwise? Regards, Peter > > Thomas
Hello, On Wed, 11 Oct 2017 22:21:24 +0200, Peter Seiderer wrote: > > I don't think it really fixes bug 10391. Bug 10391 is bogus by itself. > > The update to 96344ff7125182989f98d3be8d111952a8f74e15 doesn't fix > > anything, it only adds support for RPi Zero W. > > Saving a download as wiringpi-2.44.tar.gz containing something > identifying itself as 2.42? I would call it a bug (not on the buildroot > side but in the original git repository). The release identified as 2.42 is in fact 2.44, since both tags point to exactly the same commit. > The suggested patch fixes the original complain of Bug 10391: > 'WiringPi retrieves wrong (old) version' > > Any suggestion on how to reference the bug report otherwise? I'll try to find a reasonable wording when applying, no need to respin. Best regards, Thomas
Hello, On Wed, 11 Oct 2017 15:15:39 +0200, Peter Seiderer wrote: > Fixes bug 10391 [1]. > > [1] https://bugs.busybox.net/show_bug.cgi?id=10391 > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > --- > package/wiringpi/wiringpi.hash | 2 +- > package/wiringpi/wiringpi.mk | 3 ++- > 2 files changed, 3 insertions(+), 2 deletions(-) Applied to master, with a reworked commit log. Best regards, Thomas
diff --git a/package/wiringpi/wiringpi.hash b/package/wiringpi/wiringpi.hash index 35eedb935f..f4832e5fa8 100644 --- a/package/wiringpi/wiringpi.hash +++ b/package/wiringpi/wiringpi.hash @@ -1,2 +1,2 @@ # Locally calculated -sha256 464c98ed54f5c0ad6611e270be3491c4598a32b7e86b208255862a301c564955 wiringpi-2.44.tar.gz +sha256 4eae1d4f37f77534b1e2db4678a1003a5fd7ced4721c340527e3476d0bed1d9f wiringpi-96344ff7125182989f98d3be8d111952a8f74e15.tar.gz diff --git a/package/wiringpi/wiringpi.mk b/package/wiringpi/wiringpi.mk index cec34fadd1..f2e9e246d9 100644 --- a/package/wiringpi/wiringpi.mk +++ b/package/wiringpi/wiringpi.mk @@ -4,7 +4,8 @@ # ################################################################################ -WIRINGPI_VERSION = 2.44 +# using git commit id instead of (wrong) 2.44 git tag (Bug 10391) +WIRINGPI_VERSION = 96344ff7125182989f98d3be8d111952a8f74e15 WIRINGPI_SITE = git://git.drogon.net/wiringPi WIRINGPI_LICENSE = LGPL-3.0+
Fixes bug 10391 [1]. [1] https://bugs.busybox.net/show_bug.cgi?id=10391 Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- package/wiringpi/wiringpi.hash | 2 +- package/wiringpi/wiringpi.mk | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)