diff mbox series

[U-Boot] x86: theadorable-x86-common: Remove "ip=dhcp" from default environment

Message ID 20170830074017.12942-1-sr@denx.de
State Accepted
Commit f04034cba4c2351da5b54ae36f5a30e3ccfce1cc
Delegated to: Bin Meng
Headers show
Series [U-Boot] x86: theadorable-x86-common: Remove "ip=dhcp" from default environment | expand

Commit Message

Stefan Roese Aug. 30, 2017, 7:40 a.m. UTC
Without ethernet cable plugged, "ip=dhcp" leads to a complete hangup in
Linux booting and the system does not boot into userland at all. Since
its not required to have an active network connection on these board,
lets remove this statement from the default environment.

Signed-off-by: Stefan Roese <sr@denx.de>
Cc: Bin Meng <bmeng.cn@gmail.com>
---
 include/configs/theadorable-x86-common.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Bin Meng Aug. 30, 2017, 11:53 a.m. UTC | #1
On Wed, Aug 30, 2017 at 3:40 PM, Stefan Roese <sr@denx.de> wrote:
> Without ethernet cable plugged, "ip=dhcp" leads to a complete hangup in
> Linux booting and the system does not boot into userland at all. Since
> its not required to have an active network connection on these board,
> lets remove this statement from the default environment.
>
> Signed-off-by: Stefan Roese <sr@denx.de>
> Cc: Bin Meng <bmeng.cn@gmail.com>
> ---
>  include/configs/theadorable-x86-common.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Bin Meng Sept. 2, 2017, 3:50 p.m. UTC | #2
On Wed, Aug 30, 2017 at 7:53 PM, Bin Meng <bmeng.cn@gmail.com> wrote:
> On Wed, Aug 30, 2017 at 3:40 PM, Stefan Roese <sr@denx.de> wrote:
>> Without ethernet cable plugged, "ip=dhcp" leads to a complete hangup in
>> Linux booting and the system does not boot into userland at all. Since
>> its not required to have an active network connection on these board,
>> lets remove this statement from the default environment.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Bin Meng <bmeng.cn@gmail.com>
>> ---
>>  include/configs/theadorable-x86-common.h | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>
> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>

applied to u-boot-x86, thanks!
diff mbox series

Patch

diff --git a/include/configs/theadorable-x86-common.h b/include/configs/theadorable-x86-common.h
index 37b78c1b57..8de659a496 100644
--- a/include/configs/theadorable-x86-common.h
+++ b/include/configs/theadorable-x86-common.h
@@ -88,7 +88,7 @@ 
 		"/boot/initrd.img-${kernel-ver}-generic;"	\
 		"run boot\0"					\
 	"yocto_args=setenv bootargs root=/dev/sda${yocto_part} " \
-		"ip=dhcp panic=1\0"				\
+		"panic=1\0"				\
 	"yocto_args_fast=setenv bootargs root=/dev/sda${yocto_part} " \
 		"quiet panic=1\0"				\
 	"yocto_boot=run yocto_args addmtd addmisc addtty_yocto;" \
@@ -110,7 +110,7 @@ 
 		"fi\0"						\
 	"swupdate-initrd=/boot/swupdate-image-theadorable.ext4.gz\0" \
 	"swupdate-kernel=/boot/bzImage\0"			\
-	"swupdate_args=setenv bootargs root=/dev/ram rw ip=dhcp panic=1\0" \
+	"swupdate_args=setenv bootargs root=/dev/ram rw panic=1\0" \
 	"swupdate_dev=0\0"					\
 	"swupdate_factory=0\0"					\
 	"swupdate_interface=usb\0"				\