| Message ID | 1499250824-26093-1-git-send-email-keguang.zhang@gmail.com |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Wed, 5 Jul 2017 18:33:44 +0800, Kelvin Cheung wrote: > From: Keguang Zhang <keguang.zhang@spreadtrum.com> > > The latest upstream version had fixed the build issus. > > Fixes: > http://autobuild.buildroot.net/results/1d9/1d9f0b62e4cc387f508b4fe0086621ab9996a085/ > > Signed-off-by: Keguang Zhang <keguang.zhang@spreadtrum.com> Thanks. However, rather than bumping and having to autoreconf, I'm wondering if simply adding https://github.com/vgropp/bwm-ng/commit/d5daf15c2098040b8b01753d3cdce8c1c79fc528.patch inside package/bwm-ng/ isn't a simpler solution. Peter? Thomas
Hi Thomas, Since the upstream had fixed the error, we have no reason to keep a patch inside package/bwm-ng/. Moreover, the update contains not only th fix for build issue, but also a improvement https://github.com/vgropp/bwm-ng/commit/e9b980464e1fd72ae1b3d1002afb3b911daad619.patch . Therefore, I think updating version is better. 2017-07-05 18:38 GMT+08:00 Thomas Petazzoni < thomas.petazzoni@free-electrons.com>: > Hello, > > On Wed, 5 Jul 2017 18:33:44 +0800, Kelvin Cheung wrote: > > From: Keguang Zhang <keguang.zhang@spreadtrum.com> > > > > The latest upstream version had fixed the build issus. > > > > Fixes: > > http://autobuild.buildroot.net/results/1d9/ > 1d9f0b62e4cc387f508b4fe0086621ab9996a085/ > > > > Signed-off-by: Keguang Zhang <keguang.zhang@spreadtrum.com> > > Thanks. However, rather than bumping and having to autoreconf, I'm > wondering if simply adding > https://github.com/vgropp/bwm-ng/commit/d5daf15c2098040b8b01753d3cdce8 > c1c79fc528.patch > inside package/bwm-ng/ isn't a simpler solution. > > Peter? > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com >
Hi Thomas, The autobuild keeps sending the mail to mek. Can this patch be accepted? Thanks! 2017-07-06 10:00 GMT+08:00 Kelvin Cheung <keguang.zhang@gmail.com>: > Hi Thomas, > Since the upstream had fixed the error, we have no reason to keep a patch > inside package/bwm-ng/. > > Moreover, the update contains not only th fix for build issue, but also a > improvement > https://github.com/vgropp/bwm-ng/commit/e9b980464e1fd72ae1b3d1002afb3b > 911daad619.patch. > > Therefore, I think updating version is better. > > 2017-07-05 18:38 GMT+08:00 Thomas Petazzoni <thomas.petazzoni@free- > electrons.com>: > >> Hello, >> >> On Wed, 5 Jul 2017 18:33:44 +0800, Kelvin Cheung wrote: >> > From: Keguang Zhang <keguang.zhang@spreadtrum.com> >> > >> > The latest upstream version had fixed the build issus. >> > >> > Fixes: >> > http://autobuild.buildroot.net/results/1d9/1d9f0b62e4cc387f5 >> 08b4fe0086621ab9996a085/ >> > >> > Signed-off-by: Keguang Zhang <keguang.zhang@spreadtrum.com> >> >> Thanks. However, rather than bumping and having to autoreconf, I'm >> wondering if simply adding >> https://github.com/vgropp/bwm-ng/commit/d5daf15c2098040b8b01 >> 753d3cdce8c1c79fc528.patch >> inside package/bwm-ng/ isn't a simpler solution. >> >> Peter? >> >> Thomas >> -- >> Thomas Petazzoni, CTO, Free Electrons >> Embedded Linux and Kernel engineering >> http://free-electrons.com >> > > > > -- > Best regards, > > Kelvin Cheung >
Hello, On Wed, 5 Jul 2017 18:33:44 +0800, Kelvin Cheung wrote: > From: Keguang Zhang <keguang.zhang@spreadtrum.com> > > The latest upstream version had fixed the build issus. > > Fixes: > http://autobuild.buildroot.net/results/1d9/1d9f0b62e4cc387f508b4fe0086621ab9996a085/ > > Signed-off-by: Keguang Zhang <keguang.zhang@spreadtrum.com> > --- > package/bwm-ng/bwm-ng.hash | 2 +- > package/bwm-ng/bwm-ng.mk | 5 +++-- > 2 files changed, 4 insertions(+), 3 deletions(-) Applied to master, thanks. Thomas
diff --git a/package/bwm-ng/bwm-ng.hash b/package/bwm-ng/bwm-ng.hash index 1d3a240..4c12b0d 100644 --- a/package/bwm-ng/bwm-ng.hash +++ b/package/bwm-ng/bwm-ng.hash @@ -1,2 +1,2 @@ # Locally calculated -sha256 027cf3c960cd96fc9ffacdf7713df62d0fc55eeef4a1388289f8a62ae5e50df0 bwm-ng-0.6.1.tar.gz +sha256 4b34a8ac2eae2d204d6dea8258c5e34b37094259086f8c9169391409a9311fb5 bwm-ng-f54b3fad2c80bfe63f920c9b5e7c1d80389c57ef.tar.gz diff --git a/package/bwm-ng/bwm-ng.mk b/package/bwm-ng/bwm-ng.mk index 85ee689..587ffbe 100644 --- a/package/bwm-ng/bwm-ng.mk +++ b/package/bwm-ng/bwm-ng.mk @@ -4,11 +4,12 @@ # ################################################################################ -BWM_NG_VERSION = 0.6.1 -BWM_NG_SITE = http://www.gropp.org/bwm-ng +BWM_NG_VERSION = f54b3fad2c80bfe63f920c9b5e7c1d80389c57ef +BWM_NG_SITE = $(call github,vgropp,bwm-ng,$(BWM_NG_VERSION)) BWM_NG_CONF_OPTS = --with-procnetdev --with-diskstats BWM_NG_LICENSE = GPL-2.0 BWM_NG_LICENSE_FILES = COPYING +BWM_NG_AUTORECONF = YES ifeq ($(BR2_PACKAGE_NCURSES),y) BWM_NG_CONF_OPTS += --with-ncurses