diff mbox

libtirpc: Fix build error due to missing stdint.h inclusion

Message ID 20170619150626.31273-1-dmitrii@synopsys.com
State Changes Requested
Headers show

Commit Message

Dmitrii Kolesnichenko June 19, 2017, 3:06 p.m. UTC
Add patch to fix following error:
| ../../libtirpc-1.0.1/src/xdr_sizeof.c:93:13: error: 'uintptr_t' undeclared (first use in this function); did you mean '__intptr_t'?
|   if (len < (uintptr_t)xdrs->x_base) {
|              ^~~~~~~~~

It includes stdint.h to provide uintptr_t.

This patch has been submitted upstream:
https://sourceforge.net/p/libtirpc/mailman/libtirpc-devel/

Signed-off-by: Dmitrii Kolesnichenko <dmitrii@synopsys.com>
---
 ...ild-error-due-to-missing-stdint.h-include.patch | 26 ++++++++++++++++++++++
 1 file changed, 26 insertions(+)
 create mode 100644 package/libtirpc/0008-Fix-build-error-due-to-missing-stdint.h-include.patch

Comments

Thomas Petazzoni June 19, 2017, 7:31 p.m. UTC | #1
Hello,

On Mon, 19 Jun 2017 18:06:26 +0300, Dmitrii Kolesnichenko wrote:
> Add patch to fix following error:
> | ../../libtirpc-1.0.1/src/xdr_sizeof.c:93:13: error: 'uintptr_t' undeclared (first use in this function); did you mean '__intptr_t'?
> |   if (len < (uintptr_t)xdrs->x_base) {
> |              ^~~~~~~~~
> 
> It includes stdint.h to provide uintptr_t.
> 
> This patch has been submitted upstream:
> https://sourceforge.net/p/libtirpc/mailman/libtirpc-devel/
> 
> Signed-off-by: Dmitrii Kolesnichenko <dmitrii@synopsys.com>

Thanks, but this commit log and patch description still don't explain
with which version of glibc you're seeing the problem. Indeed, this
error has not been caught by our autobuilders, so one may wonder why
this additional patch is needed.

Can you add such an explanation in the commit description?

Thanks,

Thomas
diff mbox

Patch

diff --git a/package/libtirpc/0008-Fix-build-error-due-to-missing-stdint.h-include.patch b/package/libtirpc/0008-Fix-build-error-due-to-missing-stdint.h-include.patch
new file mode 100644
index 0000000..ccb0dff
--- /dev/null
+++ b/package/libtirpc/0008-Fix-build-error-due-to-missing-stdint.h-include.patch
@@ -0,0 +1,27 @@ 
+Fixes
+| ../../libtirpc-1.0.1/src/xdr_sizeof.c:93:13: error: 'uintptr_t' undeclared (first use in this function); did you mean '__intptr_t'?
+|   if (len < (uintptr_t)xdrs->x_base) {
+|              ^~~~~~~~~
+
+Signed-off-by: Khem Raj <raj.khem@...>
+Signed-off-by: Dmitrii Kolesnichenko <dmitrii@synopsys.com>
+---
+Upstream-Status: Pending
+
+ src/xdr_sizeof.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/src/xdr_sizeof.c b/src/xdr_sizeof.c
+index d23fbd1..79d6707 100644
+--- a/src/xdr_sizeof.c
++++ b/src/xdr_sizeof.c
+@@ -39,6 +39,7 @@
+ #include <rpc/xdr.h>
+ #include <sys/types.h>
+ #include <stdlib.h>
++#include <stdint.h>
+ #include "un-namespace.h"
+ 
+ /* ARGSUSED */
+-- 
+2.13.0