| Message ID | 20170604094839.23541-1-yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Commit | b0fc65a11b2ac11dc492146ec50168739810c2f8 |
| Headers | show |
Hello, On Sun, 4 Jun 2017 11:48:39 +0200, Yann E. MORIN wrote: > In 4c10eedc1 (systemd: enable required kernel features), we added > setting a few required kernel features to ensure systemd works. > > However, there was a typo for one of the variables: CONFIG_TMPFS_XATTR > was written as CONFIG_TMPFS_POSIX_XATTR, which does not exist (and never > ever existed, at least not since 2.6.12)... > > Fixes #9926. The patch looks good, but I'm not sure why you say it fixes #9926. It has been noticed as part of the #9926 discussion, but to me it doesn't fix this bug. Could you clarify? Thanks, Thomas
Thomas, All, On 2017-06-05 11:54 +0200, Thomas Petazzoni spake thusly: > On Sun, 4 Jun 2017 11:48:39 +0200, Yann E. MORIN wrote: > > In 4c10eedc1 (systemd: enable required kernel features), we added > > setting a few required kernel features to ensure systemd works. > > > > However, there was a typo for one of the variables: CONFIG_TMPFS_XATTR > > was written as CONFIG_TMPFS_POSIX_XATTR, which does not exist (and never > > ever existed, at least not since 2.6.12)... > > > > Fixes #9926. > > The patch looks good, but I'm not sure why you say it fixes #9926. It > has been noticed as part of the #9926 discussion, but to me it doesn't > fix this bug. > > Could you clarify? OK, I mis-read the comment in #9926. I does not fix it. Still, the patch is meaningful on its own. Can you just drop the "Fixes #9926" part before applying, please? ;-) Regards, Yann E. MORIN.
>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes: > In 4c10eedc1 (systemd: enable required kernel features), we added > setting a few required kernel features to ensure systemd works. > However, there was a typo for one of the variables: CONFIG_TMPFS_XATTR > was written as CONFIG_TMPFS_POSIX_XATTR, which does not exist (and never > ever existed, at least not since 2.6.12)... > Fixes #9926. Committed to master, 2017.05.x and 2017.02.x after dropping the reference to #9926, thanks.
diff --git a/linux/linux.mk b/linux/linux.mk index e387c7dd44..9da7e9bec1 100644 --- a/linux/linux.mk +++ b/linux/linux.mk @@ -278,7 +278,7 @@ define LINUX_KCONFIG_FIXUP_CMDS $(call KCONFIG_ENABLE_OPT,CONFIG_FHANDLE,$(@D)/.config) $(call KCONFIG_ENABLE_OPT,CONFIG_AUTOFS4_FS,$(@D)/.config) $(call KCONFIG_ENABLE_OPT,CONFIG_TMPFS_POSIX_ACL,$(@D)/.config) - $(call KCONFIG_ENABLE_OPT,CONFIG_TMPFS_POSIX_XATTR,$(@D)/.config)) + $(call KCONFIG_ENABLE_OPT,CONFIG_TMPFS_XATTR,$(@D)/.config)) $(if $(BR2_PACKAGE_SMACK), $(call KCONFIG_ENABLE_OPT,CONFIG_SECURITY,$(@D)/.config) $(call KCONFIG_ENABLE_OPT,CONFIG_SECURITY_SMACK,$(@D)/.config)
In 4c10eedc1 (systemd: enable required kernel features), we added setting a few required kernel features to ensure systemd works. However, there was a typo for one of the variables: CONFIG_TMPFS_XATTR was written as CONFIG_TMPFS_POSIX_XATTR, which does not exist (and never ever existed, at least not since 2.6.12)... Fixes #9926. Reported-by: Michael Heinemann <posted@heine.so> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Maxime Hadjinlian <maxime.hadjinlian@gmail.com> Cc: Eric Le Bihan <eric.le.bihan.dev@free.fr> Cc: Michael Heinemann <posted@heine.so> --- linux/linux.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)