| Message ID | 20170602235653.4655-3-andrew.smirnov@gmail.com |
|---|---|
| State | Not Applicable |
| Headers | show |
Hi Andrey, On Sat, Jun 3, 2017 at 1:56 AM, Andrey Smirnov <andrew.smirnov@gmail.com> wrote: > Enum34's setup.py imports 'setuptools' directly, without any fallback > logic, so we need to have host-setuptools in order to install > it. Switching this also removes unspecified implicit dependency on > BR2_PACKAGE_PYTHON_ZLIB, by not installing the package as zipped .egg > > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> > --- > package/python-enum34/python-enum34.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/package/python-enum34/python-enum34.mk b/package/python-enum34/python-enum34.mk > index 1a4c6c6..c612cb6 100644 > --- a/package/python-enum34/python-enum34.mk > +++ b/package/python-enum34/python-enum34.mk > @@ -7,7 +7,7 @@ > PYTHON_ENUM34_VERSION = 1.1.6 > PYTHON_ENUM34_SOURCE = enum34-$(PYTHON_ENUM34_VERSION).tar.gz > PYTHON_ENUM34_SITE = https://pypi.python.org/packages/bf/3e/31d502c25302814a7c2f1d3959d2a3b3f78e509002ba91aea64993936876 > -PYTHON_ENUM34_SETUP_TYPE = distutils > +PYTHON_ENUM34_SETUP_TYPE = setuptools > PYTHON_ENUM34_LICENSE = BSD-3-Clause > PYTHON_ENUM34_LICENSE_FILES = enum/LICENSE Such a patch has been already applied. Commit 3c54b7086fc0eaddb7f04560f30bb8cc99860b25 Yegor
On Fri, Jun 2, 2017 at 10:23 PM, Yegor Yefremov <yegorslists@googlemail.com> wrote: > Hi Andrey, > > On Sat, Jun 3, 2017 at 1:56 AM, Andrey Smirnov <andrew.smirnov@gmail.com> wrote: >> Enum34's setup.py imports 'setuptools' directly, without any fallback >> logic, so we need to have host-setuptools in order to install >> it. Switching this also removes unspecified implicit dependency on >> BR2_PACKAGE_PYTHON_ZLIB, by not installing the package as zipped .egg >> >> Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> >> --- >> package/python-enum34/python-enum34.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/package/python-enum34/python-enum34.mk b/package/python-enum34/python-enum34.mk >> index 1a4c6c6..c612cb6 100644 >> --- a/package/python-enum34/python-enum34.mk >> +++ b/package/python-enum34/python-enum34.mk >> @@ -7,7 +7,7 @@ >> PYTHON_ENUM34_VERSION = 1.1.6 >> PYTHON_ENUM34_SOURCE = enum34-$(PYTHON_ENUM34_VERSION).tar.gz >> PYTHON_ENUM34_SITE = https://pypi.python.org/packages/bf/3e/31d502c25302814a7c2f1d3959d2a3b3f78e509002ba91aea64993936876 >> -PYTHON_ENUM34_SETUP_TYPE = distutils >> +PYTHON_ENUM34_SETUP_TYPE = setuptools >> PYTHON_ENUM34_LICENSE = BSD-3-Clause >> PYTHON_ENUM34_LICENSE_FILES = enum/LICENSE > > Such a patch has been already applied. > > Commit 3c54b7086fc0eaddb7f04560f30bb8cc99860b25 Sorry, my bad, didn't make sure my patches was rebased against latest master. I'll drop this patch and re-spin v4 shortly. Thanks for pointing this out! Andrey Smirnov
Hello, On Mon, 5 Jun 2017 06:02:52 -0700, Andrey Smirnov wrote: > Sorry, my bad, didn't make sure my patches was rebased against latest > master. I'll drop this patch and re-spin v4 shortly. Please don't respin a v4 just for this change. I'll mark this patch as Not applicable. Thanks! Thomas
On Mon, Jun 5, 2017 at 6:08 AM, Thomas Petazzoni <thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Mon, 5 Jun 2017 06:02:52 -0700, Andrey Smirnov wrote: > >> Sorry, my bad, didn't make sure my patches was rebased against latest >> master. I'll drop this patch and re-spin v4 shortly. > > Please don't respin a v4 just for this change. I'll mark this patch as > Not applicable. Sure, that's even easier for me :-) Thanks, Andrey Smirnov
diff --git a/package/python-enum34/python-enum34.mk b/package/python-enum34/python-enum34.mk index 1a4c6c6..c612cb6 100644 --- a/package/python-enum34/python-enum34.mk +++ b/package/python-enum34/python-enum34.mk @@ -7,7 +7,7 @@ PYTHON_ENUM34_VERSION = 1.1.6 PYTHON_ENUM34_SOURCE = enum34-$(PYTHON_ENUM34_VERSION).tar.gz PYTHON_ENUM34_SITE = https://pypi.python.org/packages/bf/3e/31d502c25302814a7c2f1d3959d2a3b3f78e509002ba91aea64993936876 -PYTHON_ENUM34_SETUP_TYPE = distutils +PYTHON_ENUM34_SETUP_TYPE = setuptools PYTHON_ENUM34_LICENSE = BSD-3-Clause PYTHON_ENUM34_LICENSE_FILES = enum/LICENSE
Enum34's setup.py imports 'setuptools' directly, without any fallback logic, so we need to have host-setuptools in order to install it. Switching this also removes unspecified implicit dependency on BR2_PACKAGE_PYTHON_ZLIB, by not installing the package as zipped .egg Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com> --- package/python-enum34/python-enum34.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)