| Message ID | 1494211950-2633-2-git-send-email-bmeng.cn@gmail.com |
|---|---|
| State | Accepted |
| Commit | c2f17939f4b429c90a453e26927a7c578e5456b5 |
| Delegated to: | Bin Meng |
| Headers | show |
On 08.05.2017 04:52, Bin Meng wrote: > Remove 'pad-offset' of soc_gpio_s5_0, soc_gpio_s5_1, soc_gpio_s5_2, > pin_usb_host_en0 and pin_usb_host_en1. These offsets are actually > wrong. Correct value should be added by 0x2000, but since they > are supposed to be 'mode-gpio', 'pad-offset' is not needed at all. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: Stefan Roese <sr@denx.de> Thanks, Stefan
On 7 May 2017 at 20:52, Bin Meng <bmeng.cn@gmail.com> wrote: > Remove 'pad-offset' of soc_gpio_s5_0, soc_gpio_s5_1, soc_gpio_s5_2, > pin_usb_host_en0 and pin_usb_host_en1. These offsets are actually > wrong. Correct value should be added by 0x2000, but since they > are supposed to be 'mode-gpio', 'pad-offset' is not needed at all. > > Signed-off-by: Bin Meng <bmeng.cn@gmail.com> > --- > > arch/x86/dts/minnowmax.dts | 5 ----- > 1 file changed, 5 deletions(-) Reviewed-by: Simon Glass <sjg@chromium.org>
On Mon, May 15, 2017 at 11:02 AM, Simon Glass <sjg@chromium.org> wrote: > On 7 May 2017 at 20:52, Bin Meng <bmeng.cn@gmail.com> wrote: >> Remove 'pad-offset' of soc_gpio_s5_0, soc_gpio_s5_1, soc_gpio_s5_2, >> pin_usb_host_en0 and pin_usb_host_en1. These offsets are actually >> wrong. Correct value should be added by 0x2000, but since they >> are supposed to be 'mode-gpio', 'pad-offset' is not needed at all. >> >> Signed-off-by: Bin Meng <bmeng.cn@gmail.com> >> --- >> >> arch/x86/dts/minnowmax.dts | 5 ----- >> 1 file changed, 5 deletions(-) > > Reviewed-by: Simon Glass <sjg@chromium.org> applied to u-boot-x86, thanks!
diff --git a/arch/x86/dts/minnowmax.dts b/arch/x86/dts/minnowmax.dts index bc382a8..af64c68 100644 --- a/arch/x86/dts/minnowmax.dts +++ b/arch/x86/dts/minnowmax.dts @@ -35,7 +35,6 @@ /* GPIO E0 */ soc_gpio_s5_0@0 { gpio-offset = <0x80 0>; - pad-offset = <0x1d0>; mode-gpio; output-value = <0>; direction = <PIN_OUTPUT>; @@ -44,7 +43,6 @@ /* GPIO E1 */ soc_gpio_s5_1@0 { gpio-offset = <0x80 1>; - pad-offset = <0x210>; mode-gpio; output-value = <0>; direction = <PIN_OUTPUT>; @@ -53,7 +51,6 @@ /* GPIO E2 */ soc_gpio_s5_2@0 { gpio-offset = <0x80 2>; - pad-offset = <0x1e0>; mode-gpio; output-value = <0>; direction = <PIN_OUTPUT>; @@ -61,7 +58,6 @@ pin_usb_host_en0@0 { gpio-offset = <0x80 8>; - pad-offset = <0x260>; mode-gpio; output-value = <1>; direction = <PIN_OUTPUT>; @@ -69,7 +65,6 @@ pin_usb_host_en1@0 { gpio-offset = <0x80 9>; - pad-offset = <0x250>; mode-gpio; output-value = <1>; direction = <PIN_OUTPUT>;
Remove 'pad-offset' of soc_gpio_s5_0, soc_gpio_s5_1, soc_gpio_s5_2, pin_usb_host_en0 and pin_usb_host_en1. These offsets are actually wrong. Correct value should be added by 0x2000, but since they are supposed to be 'mode-gpio', 'pad-offset' is not needed at all. Signed-off-by: Bin Meng <bmeng.cn@gmail.com> --- arch/x86/dts/minnowmax.dts | 5 ----- 1 file changed, 5 deletions(-)