diff mbox

[1/1] ext2.mk: ensure -b option is always set for mke2img and genext2fs

Message ID 1493555747-27289-1-git-send-email-g4@novadsp.com
State Accepted
Headers show

Commit Message

J Evans April 30, 2017, 12:35 p.m. UTC 
Signed-off-by: J Evans <g4@novadsp.com>
---
 fs/ext2/ext2.mk | 2 --
 1 file changed, 2 deletions(-)

Comments

Yann E. MORIN April 30, 2017, 5:14 p.m. UTC | #1 
J, All,

On 2017-04-30 13:35 +0100, J Evans spake thusly:
> Signed-off-by: J Evans <g4@novadsp.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Thanks! :-)

Regards,
Yann E. MORIN.

> ---
>  fs/ext2/ext2.mk | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/fs/ext2/ext2.mk b/fs/ext2/ext2.mk
> index 30f1d17..9d3e8fd 100644
> --- a/fs/ext2/ext2.mk
> +++ b/fs/ext2/ext2.mk
> @@ -6,9 +6,7 @@
>  
>  EXT2_OPTS = -G $(BR2_TARGET_ROOTFS_EXT2_GEN) -R $(BR2_TARGET_ROOTFS_EXT2_REV)
>  
> -ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)),0)
>  EXT2_OPTS += -b $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)
> -endif
>  
>  ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_INODES)),0)
>  EXT2_OPTS += -i $(BR2_TARGET_ROOTFS_EXT2_INODES)
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni April 30, 2017, 5:33 p.m. UTC | #2 
Hello,

On Sun, 30 Apr 2017 13:35:47 +0100, J Evans wrote:
> Signed-off-by: J Evans <g4@novadsp.com>
> ---
>  fs/ext2/ext2.mk | 2 --
>  1 file changed, 2 deletions(-)

Applied to master, thanks.

However, I believe we should do the same for the number of inodes:

ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_INODES)),0)
EXT2_OPTS += -i $(BR2_TARGET_ROOTFS_EXT2_INODES)
endif

Thomas
Yann E. MORIN April 30, 2017, 7:43 p.m. UTC | #3 
Thomas, All,

On 2017-04-30 19:33 +0200, Thomas Petazzoni spake thusly:
> On Sun, 30 Apr 2017 13:35:47 +0100, J Evans wrote:
> > Signed-off-by: J Evans <g4@novadsp.com>
> > ---
> >  fs/ext2/ext2.mk | 2 --
> >  1 file changed, 2 deletions(-)
> 
> Applied to master, thanks.
> 
> However, I believe we should do the same for the number of inodes:
> 
> ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_INODES)),0)
> EXT2_OPTS += -i $(BR2_TARGET_ROOTFS_EXT2_INODES)
> endif

Yep, was going to work on that next...

Regards,
Yann E. MORIN.

> Thomas
> -- 
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux, Kernel and Android engineering
> http://free-electrons.com
diff mbox

Patch

diff --git a/fs/ext2/ext2.mk b/fs/ext2/ext2.mk
index 30f1d17..9d3e8fd 100644
--- a/fs/ext2/ext2.mk
+++ b/fs/ext2/ext2.mk
@@ -6,9 +6,7 @@ 
 
 EXT2_OPTS = -G $(BR2_TARGET_ROOTFS_EXT2_GEN) -R $(BR2_TARGET_ROOTFS_EXT2_REV)
 
-ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)),0)
 EXT2_OPTS += -b $(BR2_TARGET_ROOTFS_EXT2_BLOCKS)
-endif
 
 ifneq ($(strip $(BR2_TARGET_ROOTFS_EXT2_INODES)),0)
 EXT2_OPTS += -i $(BR2_TARGET_ROOTFS_EXT2_INODES)