diff mbox

cukinia: new package

Message ID 20170425135814.8787-1-alexandre.leblanc@savoirfairelinux.com
State Changes Requested
Headers show

Commit Message

Alexandre Leblanc April 25, 2017, 1:58 p.m. UTC 
Cukinia is designed to help Linux-based embedded firmware developers
run simple validation tests on their firmware. For basic usage it
requires no dependencies other than busybox.

Cukinia can run tests at boot time which is why we are using SZZcukinia
since it would possibly be the last script to be executed in 'init.d'.

Signed-off-by: Alexandre Leblanc <alexandre.leblanc@savoirfairelinux.com>
---
 package/Config.in            |  1 +
 package/cukinia/Config.in    | 12 ++++++++++++
 package/cukinia/SZZcukinia   |  7 +++++++
 package/cukinia/cukinia.conf |  1 +
 package/cukinia/cukinia.mk   | 26 ++++++++++++++++++++++++++
 5 files changed, 47 insertions(+)
 create mode 100644 package/cukinia/Config.in
 create mode 100644 package/cukinia/SZZcukinia
 create mode 100644 package/cukinia/cukinia.conf
 create mode 100644 package/cukinia/cukinia.mk

Comments

Thomas Petazzoni May 1, 2017, 8:51 a.m. UTC | #1 
Hello,

On Tue, 25 Apr 2017 09:58:14 -0400, Alexandre Leblanc wrote:
> Cukinia is designed to help Linux-based embedded firmware developers
> run simple validation tests on their firmware. For basic usage it
> requires no dependencies other than busybox.
> 
> Cukinia can run tests at boot time which is why we are using SZZcukinia
> since it would possibly be the last script to be executed in 'init.d'.
> 
> Signed-off-by: Alexandre Leblanc <alexandre.leblanc@savoirfairelinux.com>

As much as I like adding new package in Buildroot, this project feels
like your own project, very recently started, with no outside
contributions. In the end it's just a single shell script providing a
few functions. Could be useful, but I'm not sure we want to add this as
a Buildroot package that quickly.

Perhaps we need to see if there is some interest/adoption first?

>  package/cukinia/Config.in    | 12 ++++++++++++
>  package/cukinia/SZZcukinia   |  7 +++++++

I'm not sure I like this idea of SZZcukinia, though indeed S99 wouldn't
work because a few other Buildroot services are started at S99, and you
want to be after those services. Maybe other developers will have some
ideas?

> +CUKINIA_LICENSE = Apache-2.0 or GPLv3

GPLv3 should be GPL-3.0.

Best regards,

Thomas
Alexandre Leblanc May 1, 2017, 2:48 p.m. UTC | #2 
Thank you for your reply.
I'm quite new to the world of project up-streaming. 
Knowing This might be a hard question to answer, would you be able to quantify how many outside contribution would be reasonably acceptable ? 

Thank you again 

Alexandre Leblanc 


----- Original Message -----
From: "Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>
To: "Alexandre Leblanc" <alexandre.leblanc@savoirfairelinux.com>
Cc: buildroot@busybox.net
Sent: Monday, May 1, 2017 4:51:18 AM
Subject: Re: [Buildroot] [PATCH] cukinia: new package

Hello,

On Tue, 25 Apr 2017 09:58:14 -0400, Alexandre Leblanc wrote:
> Cukinia is designed to help Linux-based embedded firmware developers
> run simple validation tests on their firmware. For basic usage it
> requires no dependencies other than busybox.
> 
> Cukinia can run tests at boot time which is why we are using SZZcukinia
> since it would possibly be the last script to be executed in 'init.d'.
> 
> Signed-off-by: Alexandre Leblanc <alexandre.leblanc@savoirfairelinux.com>

As much as I like adding new package in Buildroot, this project feels
like your own project, very recently started, with no outside
contributions. In the end it's just a single shell script providing a
few functions. Could be useful, but I'm not sure we want to add this as
a Buildroot package that quickly.

Perhaps we need to see if there is some interest/adoption first?

>  package/cukinia/Config.in    | 12 ++++++++++++
>  package/cukinia/SZZcukinia   |  7 +++++++

I'm not sure I like this idea of SZZcukinia, though indeed S99 wouldn't
work because a few other Buildroot services are started at S99, and you
want to be after those services. Maybe other developers will have some
ideas?

> +CUKINIA_LICENSE = Apache-2.0 or GPLv3

GPLv3 should be GPL-3.0.

Best regards,

Thomas
Thomas Petazzoni May 4, 2017, 9:16 a.m. UTC | #3 
Hello,

On Mon, 1 May 2017 10:48:20 -0400 (EDT), Alexandre   Leblanc wrote:

> I'm quite new to the world of project up-streaming. 
> Knowing This might be a hard question to answer, would you be able to quantify how many outside contribution would be reasonably acceptable ? 

There is no exact quantity, it's just a feeling about the project
activity/spread/usefulness.

Thomas
Angelo Compagnucci April 26, 2020, 7:56 p.m. UTC | #4 
Il giorno gio 4 mag 2017 alle ore 11:16 Thomas Petazzoni <
thomas.petazzoni@free-electrons.com> ha scritto:

> Hello,
>
> On Mon, 1 May 2017 10:48:20 -0400 (EDT), Alexandre   Leblanc wrote:
>
> > I'm quite new to the world of project up-streaming.
> > Knowing This might be a hard question to answer, would you be able to
> quantify how many outside contribution would be reasonably acceptable ?
>
> There is no exact quantity, it's just a feeling about the project
> activity/spread/usefulness.
>

Could you resend an updated patch? I'm interested in the project and I
would like to have a buildroot package.

Thanks!


> Thomas
> --
> Thomas Petazzoni, CTO, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
Shyam Saini April 27, 2020, 8:08 a.m. UTC | #5 
Thank you for your interest Angelo,

I have just sent an updated patch.


On Mon, Apr 27, 2020 at 1:27 AM Angelo Compagnucci <
angelo.compagnucci@gmail.com> wrote:

>
>
> Il giorno gio 4 mag 2017 alle ore 11:16 Thomas Petazzoni <
> thomas.petazzoni@free-electrons.com> ha scritto:
>
>> Hello,
>>
>> On Mon, 1 May 2017 10:48:20 -0400 (EDT), Alexandre   Leblanc wrote:
>>
>> > I'm quite new to the world of project up-streaming.
>> > Knowing This might be a hard question to answer, would you be able to
>> quantify how many outside contribution would be reasonably acceptable ?
>>
>> There is no exact quantity, it's just a feeling about the project
>> activity/spread/usefulness.
>>
>
> Could you resend an updated patch? I'm interested in the project and I
> would like to have a buildroot package.
>
> Thanks!
>
>
>> Thomas
>> --
>> Thomas Petazzoni, CTO, Free Electrons
>> Embedded Linux and Kernel engineering
>> http://free-electrons.com
>> _______________________________________________
>> buildroot mailing list
>> buildroot@busybox.net
>> http://lists.busybox.net/mailman/listinfo/buildroot
>>
>
>
> --
> Profile: http://it.linkedin.com/in/compagnucciangelo
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
>
diff mbox

Patch

diff --git a/package/Config.in b/package/Config.in
index 4eaa95b..e3f8ce4 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -73,6 +73,7 @@  menu "Debugging, profiling and benchmark"
 	source "package/blktrace/Config.in"
 	source "package/bonnie/Config.in"
 	source "package/cache-calibrator/Config.in"
+	source "package/cukinia/Config.in"
 	source "package/dhrystone/Config.in"
 	source "package/dieharder/Config.in"
 	source "package/dmalloc/Config.in"
diff --git a/package/cukinia/Config.in b/package/cukinia/Config.in
new file mode 100644
index 0000000..2588bb6
--- /dev/null
+++ b/package/cukinia/Config.in
@@ -0,0 +1,12 @@ 
+config BR2_PACKAGE_CUKINIA
+	bool "cukinia"
+	help
+	  Cukinia is designed to help Linux-based embedded firmware
+	  developers run simple validation tests on their firmware.
+
+	  https://github.com/savoirfairelinux/cukinia
+
+config BR2_PACKAGE_CUKINIA_BOOT
+	bool "run at boot time"
+	depends on BR2_PACKAGE_CUKINIA && (BR2_INIT_SYSV || BR2_INIT_BUSYBOX)
+
diff --git a/package/cukinia/SZZcukinia b/package/cukinia/SZZcukinia
new file mode 100644
index 0000000..d9dc144
--- /dev/null
+++ b/package/cukinia/SZZcukinia
@@ -0,0 +1,7 @@ 
+#!/bin/sh
+#
+# Run cukinia
+#
+
+[ "$1" == "start"] || exit 0
+/usr/bin/cukinia
diff --git a/package/cukinia/cukinia.conf b/package/cukinia/cukinia.conf
new file mode 100644
index 0000000..0593662
--- /dev/null
+++ b/package/cukinia/cukinia.conf
@@ -0,0 +1 @@ 
+cukinia_user root
diff --git a/package/cukinia/cukinia.mk b/package/cukinia/cukinia.mk
new file mode 100644
index 0000000..d507e33
--- /dev/null
+++ b/package/cukinia/cukinia.mk
@@ -0,0 +1,26 @@ 
+################################################################################
+#
+# cukinia
+#
+################################################################################
+
+CUKINIA_VERSION = 152d4965dd1024a3f345a9ee1df6cf663a5775ed
+CUKINIA_SITE = $(call github,savoirfairelinux,cukinia,$(CUKINIA_VERSION))
+CUKINIA_LICENSE = Apache-2.0 or GPLv3
+
+define CUKINIA_INSTALL_TARGET_CMDS
+	$(INSTALL) -D -m 0755 $(@D)/cukinia \
+		$(TARGET_DIR)/usr/bin/cukinia
+
+	$(INSTALL) -D -m 0644 $(CUKINIA_PKGDIR)/cukinia.conf \
+		$(TARGET_DIR)/etc/cukinia/cukinia.conf
+endef
+
+ifeq ($(BR2_PACKAGE_CUKINIA_BOOT),y)
+define CUKINIA_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 $(CUKINIA_PKGDIR)/SZZcukinia \
+		$(TARGET_DIR)/etc/init.d/SZZcukinia
+endef
+endif
+
+$(eval $(generic-package))