| Message ID | 1489741879-13900-1-git-send-email-marcin.nowakowski@imgtec.com |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Friday 17 March 2017 02:41 PM, Marcin Nowakowski wrote: > This package provides a userspace library that allows easy use of crypto > interfaces exposed by the kernel. > > A git tip is used instead of the last official release, as autotools > support and cross-compilation fixes have been added only very recently. > > Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com> > > --- > v2: > Remove unnecessary AUTORECONF_OPTS > Update to latest git hash > Config: depends on ... -> if ... > Add all license files It looks good to me. Reviewed-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com> Thanks, Rahul
Hello, On Fri, 17 Mar 2017 10:11:19 +0100, Marcin Nowakowski wrote: > This package provides a userspace library that allows easy use of crypto > interfaces exposed by the kernel. > > A git tip is used instead of the last official release, as autotools > support and cross-compilation fixes have been added only very recently. > > Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com> > > --- > v2: > Remove unnecessary AUTORECONF_OPTS > Update to latest git hash > Config: depends on ... -> if ... > Add all license files > --- > DEVELOPERS | 3 +++ > package/Config.in | 1 + > package/libkcapi/Config.in | 16 ++++++++++++++++ > package/libkcapi/libkcapi.hash | 2 ++ > package/libkcapi/libkcapi.mk | 18 ++++++++++++++++++ > 5 files changed, 40 insertions(+) > create mode 100644 package/libkcapi/Config.in > create mode 100644 package/libkcapi/libkcapi.hash > create mode 100644 package/libkcapi/libkcapi.mk Applied to master, after doing the following changes: [Thomas: - Change sub-option prompt to "build test applications" - Be more specific about the license: the library is under BSD-3c only, while the programs are under BSD-3c or GPLv2. - Explicitly disable programs when BR2_PACKAGE_LIBKCAPI_APPS is not enabled.] Thanks! Thomas
Hello, On Saturday 18 March 2017 07:50 PM, Thomas Petazzoni wrote: > Hello, > > On Fri, 17 Mar 2017 10:11:19 +0100, Marcin Nowakowski wrote: >> This package provides a userspace library that allows easy use of crypto >> interfaces exposed by the kernel. >> >> A git tip is used instead of the last official release, as autotools >> support and cross-compilation fixes have been added only very recently. >> >> Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com> >> >> --- >> v2: >> Remove unnecessary AUTORECONF_OPTS >> Update to latest git hash >> Config: depends on ... -> if ... >> Add all license files >> --- >> DEVELOPERS | 3 +++ >> package/Config.in | 1 + >> package/libkcapi/Config.in | 16 ++++++++++++++++ >> package/libkcapi/libkcapi.hash | 2 ++ >> package/libkcapi/libkcapi.mk | 18 ++++++++++++++++++ >> 5 files changed, 40 insertions(+) >> create mode 100644 package/libkcapi/Config.in >> create mode 100644 package/libkcapi/libkcapi.hash >> create mode 100644 package/libkcapi/libkcapi.mk > > Applied to master, after doing the following changes: > > [Thomas: > - Change sub-option prompt to "build test applications" > - Be more specific about the license: the library is under BSD-3c only, > while the programs are under BSD-3c or GPLv2. Unless I'm missing something, library is also under BSD-3c or GPLv2. Almost all source files under /lib have following comment in file header. "License: see COPYING file in root directory" And COPYING file in root directory - says It is BSD-3c or GPLv2. Thanks, Rahul
diff --git a/DEVELOPERS b/DEVELOPERS index ff72ca1..cf24db8 100644 --- a/DEVELOPERS +++ b/DEVELOPERS @@ -991,6 +991,9 @@ F: package/easydbus/ F: package/rs485conf/ F: package/turbolua/ +N: Marcin Nowakowski <marcin.nowakowski@imgtec.com> +F: package/libkcapi/ + N: Marek Belisko <marek.belisko@open-nandra.com> F: package/libatasmart/ F: package/polkit/ diff --git a/package/Config.in b/package/Config.in index cfe7fc6..2e605f0 100644 --- a/package/Config.in +++ b/package/Config.in @@ -933,6 +933,7 @@ menu "Crypto" source "package/libgcrypt/Config.in" source "package/libgpg-error/Config.in" source "package/libgpgme/Config.in" + source "package/libkcapi/Config.in" source "package/libksba/Config.in" source "package/libmcrypt/Config.in" source "package/libmhash/Config.in" diff --git a/package/libkcapi/Config.in b/package/libkcapi/Config.in new file mode 100644 index 0000000..2968128 --- /dev/null +++ b/package/libkcapi/Config.in @@ -0,0 +1,16 @@ +config BR2_PACKAGE_LIBKCAPI + bool "libkcapi" + help + Linux Kernel Crypto API userspace interface library + + http://www.chronox.de/libkcapi.html + +if BR2_PACKAGE_LIBKCAPI + +config BR2_PACKAGE_LIBKCAPI_APPS + bool "libkcapi test applications" + help + Build additional test applications that can provide + performance or algorithm tests. + +endif diff --git a/package/libkcapi/libkcapi.hash b/package/libkcapi/libkcapi.hash new file mode 100644 index 0000000..e191970 --- /dev/null +++ b/package/libkcapi/libkcapi.hash @@ -0,0 +1,2 @@ +# Locally calculated +sha256 1ed007a35d9fe31383d1131e9f8e14af4df8d55e6c48828b5075324b2876364a libkcapi-a039f8a5adca57dc69a19d7361600c2f410e0c26.tar.gz diff --git a/package/libkcapi/libkcapi.mk b/package/libkcapi/libkcapi.mk new file mode 100644 index 0000000..6bbfbbe --- /dev/null +++ b/package/libkcapi/libkcapi.mk @@ -0,0 +1,18 @@ +################################################################################ +# +# libkcapi +# +################################################################################ + +LIBKCAPI_VERSION = a039f8a5adca57dc69a19d7361600c2f410e0c26 +LIBKCAPI_SITE = $(call github,smuellerDD,libkcapi,$(LIBKCAPI_VERSION)) +LIBKCAPI_AUTORECONF = YES +LIBKCAPI_INSTALL_STAGING = YES +LIBKCAPI_LICENSE = BSD-3c or GPLv2 +LIBKCAPI_LICENSE_FILES = COPYING COPYING.gplv2 COPYING.bsd + +ifeq ($(BR2_PACKAGE_LIBKCAPI_APPS),y) +LIBKCAPI_CONF_OPTS += --enable-kcapi-speed --enable-kcapi-test --enable-apps +endif + +$(eval $(autotools-package))
This package provides a userspace library that allows easy use of crypto interfaces exposed by the kernel. A git tip is used instead of the last official release, as autotools support and cross-compilation fixes have been added only very recently. Signed-off-by: Marcin Nowakowski <marcin.nowakowski@imgtec.com> --- v2: Remove unnecessary AUTORECONF_OPTS Update to latest git hash Config: depends on ... -> if ... Add all license files --- DEVELOPERS | 3 +++ package/Config.in | 1 + package/libkcapi/Config.in | 16 ++++++++++++++++ package/libkcapi/libkcapi.hash | 2 ++ package/libkcapi/libkcapi.mk | 18 ++++++++++++++++++ 5 files changed, 40 insertions(+) create mode 100644 package/libkcapi/Config.in create mode 100644 package/libkcapi/libkcapi.hash create mode 100644 package/libkcapi/libkcapi.mk