| Message ID | 5f582368-797e-10ad-1c19-a998496cabbf@ya.ru |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Mon, 6 Mar 2017 03:02:02 +0300, Oleg Kitain wrote: > Subject: [PATCH 1/1] pcre: Change download location > > The location at ftp.csx.cam.ac.uk only stores 2 latest versions of PCRE. > This results in old (2015.11 and older currently) buildroot versions > timing out on wget several times and having to retrieve the package > from sources.buildroot.org afterwards. > > Signed-off-by: Oleg Kitain <okitain@ya.ru> > --- > package/pcre/pcre.mk | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied to master, thanks. Peter: do we want this sort of fix in the LTS release? Thanks, Thomas
>>>>> "Oleg" == Oleg Kitain <okitain@ya.ru> writes: > Subject: [PATCH 1/1] pcre: Change download location > The location at ftp.csx.cam.ac.uk only stores 2 latest versions of PCRE. > This results in old (2015.11 and older currently) buildroot versions > timing out on wget several times and having to retrieve the package > from sources.buildroot.org afterwards. Timing out several times? Is ftp access blocked in your firewall? A missing file should not cause any timeout, it should simply generate an error and fall back to sources.buildroot.net, E.G.: wget ftp://ftp.csx.cam.ac.uk/pub/software/programming/pcre/pcre-8.37.tar.bz2 --2017-03-07 13:43:28-- ftp://ftp.csx.cam.ac.uk/pub/software/programming/pcre/pcre-8.37.tar.bz2 => ‘pcre-8.37.tar.bz2’ Resolving ftp.csx.cam.ac.uk (ftp.csx.cam.ac.uk)... 131.111.8.115 Connecting to ftp.csx.cam.ac.uk (ftp.csx.cam.ac.uk)|131.111.8.115|:21... connected. Logging in as anonymous ... Logged in! ==> SYST ... done. ==> PWD ... done. ==> TYPE I ... done. ==> CWD (1) /pub/software/programming/pcre ... done. ==> SIZE pcre-8.37.tar.bz2 ... done. ==> PASV ... done. ==> RETR pcre-8.37.tar.bz2 ... No such file ‘pcre-8.37.tar.bz2’.
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > Hello, > On Mon, 6 Mar 2017 03:02:02 +0300, Oleg Kitain wrote: >> Subject: [PATCH 1/1] pcre: Change download location >> >> The location at ftp.csx.cam.ac.uk only stores 2 latest versions of PCRE. >> This results in old (2015.11 and older currently) buildroot versions >> timing out on wget several times and having to retrieve the package >> from sources.buildroot.org afterwards. >> >> Signed-off-by: Oleg Kitain <okitain@ya.ru> >> --- >> package/pcre/pcre.mk | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > Applied to master, thanks. Peter: do we want this sort of fix in the > LTS release? I'm a bit confused about the description. To me it sounds like a local firewall issue with ftp access instead, but OK - Others might have a similar setup. Committed to 2017.02.x, thanks.
Hello, On Tue, 07 Mar 2017 13:47:45 +0100, Peter Korsgaard wrote: > I'm a bit confused about the description. To me it sounds like a local > firewall issue with ftp access instead, but OK - Others might have a > similar setup. If you look at Buildroot 2015.11, as point out in the commit log, it contains: PCRE_VERSION = 8.38 PCRE_SITE = ftp://ftp.csx.cam.ac.uk/pub/software/programming/pcre However, the 8.38 version is no longer available at ftp://ftp.csx.cam.ac.uk/pub/software/programming/pcre, the oldest available version from this site is 8.39. Hence, the fact that we have been using ftp://ftp.csx.cam.ac.uk/pub/software/programming/pcre in older Buildroot versions means that these older versions are now "broken" and have to fallback on sources.buildroot.net. So, no: it's not a local issue due to a firewall. By using the https://ftp.pcre.org/pub/pcre/ location, which contains all previous versions, we increase our chances that 2017.02 will not be "broken" in 2 years. We could have also said that pcre.org looks a bit more official/upstream, and indeed https:// is better than ftp://. Best regards, Thomas
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes: > Hello, > On Tue, 07 Mar 2017 13:47:45 +0100, Peter Korsgaard wrote: >> I'm a bit confused about the description. To me it sounds like a local >> firewall issue with ftp access instead, but OK - Others might have a >> similar setup. > If you look at Buildroot 2015.11, as point out in the commit log, it > contains: > PCRE_VERSION = 8.38 > PCRE_SITE = ftp://ftp.csx.cam.ac.uk/pub/software/programming/pcre > However, the 8.38 version is no longer available at > ftp://ftp.csx.cam.ac.uk/pub/software/programming/pcre, the oldest > available version from this site is 8.39. > Hence, the fact that we have been using > ftp://ftp.csx.cam.ac.uk/pub/software/programming/pcre in older > Buildroot versions means that these older versions are now "broken" and > have to fallback on sources.buildroot.net. > So, no: it's not a local issue due to a firewall. But how would this cause several TIMEOUTS? E.G. something where wget will try several times to contact the ftp server. It should just have done a single ftp login + get, and as soon as it failed fall back to sources.buildroot.net unless something is causing the ftp connection to "hang".
Hello, On Tue, 07 Mar 2017 15:03:49 +0100, Peter Korsgaard wrote: > But how would this cause several TIMEOUTS? E.G. something where wget > will try several times to contact the ftp server. > > It should just have done a single ftp login + get, and as soon as it > failed fall back to sources.buildroot.net unless something is causing > the ftp connection to "hang". Yes, agreed. I guess Oleg can explain more what's going. But we all agree that the fix is good I suppose :) Thomas
diff --git a/package/pcre/pcre.mk b/package/pcre/pcre.mk index 211e2359a..7b06db1a5 100644 --- a/package/pcre/pcre.mk +++ b/package/pcre/pcre.mk @@ -5,7 +5,7 @@ ################################################################################ PCRE_VERSION = 8.40 -PCRE_SITE = ftp://ftp.csx.cam.ac.uk/pub/software/programming/pcre +PCRE_SITE = https://ftp.pcre.org/pub/pcre PCRE_SOURCE = pcre-$(PCRE_VERSION).tar.bz2 PCRE_LICENSE = BSD-3c PCRE_LICENSE_FILES = LICENCE
Subject: [PATCH 1/1] pcre: Change download location The location at ftp.csx.cam.ac.uk only stores 2 latest versions of PCRE. This results in old (2015.11 and older currently) buildroot versions timing out on wget several times and having to retrieve the package from sources.buildroot.org afterwards. Signed-off-by: Oleg Kitain <okitain@ya.ru> --- package/pcre/pcre.mk | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)