| Message ID | 1486672636-20750-2-git-send-email-apalos@gmail.com |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Thu, 9 Feb 2017 22:37:16 +0200, Ilias Apalodimas wrote: > Signed-off-by: Ilias Apalodimas <apalos@gmail.com> > --- > package/ipset/ipset.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/ipset/ipset.mk b/package/ipset/ipset.mk > index db4952b..bb40fee 100644 > --- a/package/ipset/ipset.mk > +++ b/package/ipset/ipset.mk > @@ -13,5 +13,6 @@ IPSET_CONF_OPTS = --with-kmod=no > IPSET_AUTORECONF = YES > IPSET_LICENSE = GPLv2 > IPSET_LICENSE_FILES = COPYING > +IPSET_INSTALL_STAGING = YES Why? ipset installs some libraries used by other packages? In any case, this shouldn't be a separate commit, it should be part of the commit adding the keepalived package. Thanks, Thomas
Hello, On Thu, 9 Feb 2017 21:42:09 +0100, Thomas Petazzoni wrote: > On Thu, 9 Feb 2017 22:37:16 +0200, Ilias Apalodimas wrote: > > Signed-off-by: Ilias Apalodimas <apalos@gmail.com> > > --- > > package/ipset/ipset.mk | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/package/ipset/ipset.mk b/package/ipset/ipset.mk > > index db4952b..bb40fee 100644 > > --- a/package/ipset/ipset.mk > > +++ b/package/ipset/ipset.mk > > @@ -13,5 +13,6 @@ IPSET_CONF_OPTS = --with-kmod=no > > IPSET_AUTORECONF = YES > > IPSET_LICENSE = GPLv2 > > IPSET_LICENSE_FILES = COPYING > > +IPSET_INSTALL_STAGING = YES > > Why? ipset installs some libraries used by other packages? > > In any case, this shouldn't be a separate commit, it should be part of > the commit adding the keepalived package. My bad: I didn't realize this was touching the ipset package, not keepalived. So here are better comments for this patch: 1. It should come as a first patch in the series, *before* the patch adding the keepalived package, since the keepalived package uses the fact that ipset installs a library. 2. The commit title should not be "Added keepalived", because this is not at all what this patch is doing. Please use a sensible commit title, and a commit log that explains why this is needed. Thanks, Thomas
diff --git a/package/ipset/ipset.mk b/package/ipset/ipset.mk index db4952b..bb40fee 100644 --- a/package/ipset/ipset.mk +++ b/package/ipset/ipset.mk @@ -13,5 +13,6 @@ IPSET_CONF_OPTS = --with-kmod=no IPSET_AUTORECONF = YES IPSET_LICENSE = GPLv2 IPSET_LICENSE_FILES = COPYING +IPSET_INSTALL_STAGING = YES $(eval $(autotools-package))
Signed-off-by: Ilias Apalodimas <apalos@gmail.com> --- package/ipset/ipset.mk | 1 + 1 file changed, 1 insertion(+)