diff mbox

[U-Boot,PATCHv5,02/17] dm: pci: return the real controller in pci_bus_to_hose()

Message ID 1481612064-10336-2-git-send-email-Zhiqiang.Hou@nxp.com
State Accepted
Delegated to: York Sun
Headers show

Commit Message

Z.Q. Hou Dec. 13, 2016, 6:54 a.m. UTC
From: Minghuan Lian <Minghuan.Lian@nxp.com>

for the legacy PCI driver, the function pci_bus_to_hose() returns
the real PCIe controller. To keep consistency, this function is
changed to return the PCIe controller pointer of the root bus
instead of the current PCIe bus.

Signed-off-by: Minghuan Lian <Minghuan.Lian@nxp.com>
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
Reviewed-by: Simon Glass <sjg@chromium.org>
---
V5:
 - No change

 drivers/pci/pci_compat.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Bin Meng Dec. 13, 2016, 7:47 a.m. UTC | #1
On Tue, Dec 13, 2016 at 2:54 PM, Zhiqiang Hou <Zhiqiang.Hou@nxp.com> wrote:
> From: Minghuan Lian <Minghuan.Lian@nxp.com>
>
> for the legacy PCI driver, the function pci_bus_to_hose() returns
> the real PCIe controller. To keep consistency, this function is
> changed to return the PCIe controller pointer of the root bus
> instead of the current PCIe bus.
>
> Signed-off-by: Minghuan Lian <Minghuan.Lian@nxp.com>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> Reviewed-by: Simon Glass <sjg@chromium.org>
> ---
> V5:
>  - No change
>
>  drivers/pci/pci_compat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>

Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Z.Q. Hou Dec. 14, 2016, 2:38 a.m. UTC | #2
Hi Bin,

Thanks for your review!

B.R
Zhiqiang

> -----Original Message-----

> From: Bin Meng [mailto:bmeng.cn@gmail.com]

> Sent: 2016年12月13日 15:48

> To: Z.Q. Hou <zhiqiang.hou@nxp.com>

> Cc: U-Boot Mailing List <u-boot@lists.denx.de>; Albert ARIBAUD

> <albert.u.boot@aribaud.net>; Prabhakar Kushwaha

> <prabhakar.kushwaha@nxp.com>; Alison Wang <alison.wang@nxp.com>;

> Sumit Garg <sumit.garg@nxp.com>; Ruchika Gupta <ruchika.gupta@nxp.com>;

> york sun <york.sun@nxp.com>; M.H. Lian <minghuan.lian@nxp.com>; Simon

> Glass <sjg@chromium.org>; Mingkai Hu <mingkai.hu@nxp.com>

> Subject: Re: [PATCHv5 02/17] dm: pci: return the real controller in

> pci_bus_to_hose()

> 

> On Tue, Dec 13, 2016 at 2:54 PM, Zhiqiang Hou <Zhiqiang.Hou@nxp.com>

> wrote:

> > From: Minghuan Lian <Minghuan.Lian@nxp.com>

> >

> > for the legacy PCI driver, the function pci_bus_to_hose() returns the

> > real PCIe controller. To keep consistency, this function is changed to

> > return the PCIe controller pointer of the root bus instead of the

> > current PCIe bus.

> >

> > Signed-off-by: Minghuan Lian <Minghuan.Lian@nxp.com>

> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>

> > Reviewed-by: Simon Glass <sjg@chromium.org>

> > ---

> > V5:

> >  - No change

> >

> >  drivers/pci/pci_compat.c | 2 +-

> >  1 file changed, 1 insertion(+), 1 deletion(-)

> >

> 

> Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
diff mbox

Patch

diff --git a/drivers/pci/pci_compat.c b/drivers/pci/pci_compat.c
index ddaf358..25bc095 100644
--- a/drivers/pci/pci_compat.c
+++ b/drivers/pci/pci_compat.c
@@ -49,5 +49,5 @@  struct pci_controller *pci_bus_to_hose(int busnum)
 		return NULL;
 	}
 
-	return dev_get_uclass_priv(bus);
+	return dev_get_uclass_priv(pci_get_controller(bus));
 }