| Message ID | a2d0f2c0a262a2a40e8ccc1f3c0d89fdb834af39.1478643505.git.yann.morin.1998@free.fr |
|---|---|
| State | Accepted |
| Headers | show |
On 08-11-16 23:18, Yann E. MORIN wrote: > pseudo can detect the host bitness, but is not sure about it: it checks > what type of file /bin/sh is, using file(1). > > However, in some conditions, /bin/sh can be of a different bitness than > the rest of the system (weird, but not impossible), which causes build > issues. > > Just enforce the bitness, so that pseudo needs not (wrongly) guess it. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Gaël PORTAY <gael.portay@savoirfairelinux.com> > Cc: Patrick Keroulas <patrick.keroulas@savoirfairelinux.com> > Cc: Erico Nunes <nunes.erico@gmail.com> > Cc: Julien BOIBESSOT <julien.boibessot@free.fr> > Cc: Arnout Vandecappelle <arnout@mind.be> Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> Regards, Arnout > > --- > Changes v1 -> v2: > - directly extract bitness for $(HOSTARCH) (Arnout) > --- > package/pseudo/pseudo.mk | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/package/pseudo/pseudo.mk b/package/pseudo/pseudo.mk > index 67538a6..92de2c6 100644 > --- a/package/pseudo/pseudo.mk > +++ b/package/pseudo/pseudo.mk > @@ -17,6 +17,7 @@ HOST_PSEUDO_DEPENDENCIES = host-attr host-sqlite > # configure script is not generated by autoconf, so passing --libdir > # is necessary, even if the infrastructure passes --prefix already. > HOST_PSEUDO_CONF_OPTS = \ > + --bits=$(if $(filter %64,$(HOSTARCH)),64,32) \ > --libdir=$(HOST_DIR)/usr/lib \ > --with-sqlite=$(HOST_DIR)/usr > >
Hello, On Tue, 8 Nov 2016 23:18:31 +0100, Yann E. MORIN wrote: > pseudo can detect the host bitness, but is not sure about it: it checks > what type of file /bin/sh is, using file(1). > > However, in some conditions, /bin/sh can be of a different bitness than > the rest of the system (weird, but not impossible), which causes build > issues. > > Just enforce the bitness, so that pseudo needs not (wrongly) guess it. > > Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> > Cc: Gaël PORTAY <gael.portay@savoirfairelinux.com> > Cc: Patrick Keroulas <patrick.keroulas@savoirfairelinux.com> > Cc: Erico Nunes <nunes.erico@gmail.com> > Cc: Julien BOIBESSOT <julien.boibessot@free.fr> > Cc: Arnout Vandecappelle <arnout@mind.be> > > --- > Changes v1 -> v2: > - directly extract bitness for $(HOSTARCH) (Arnout) > --- > package/pseudo/pseudo.mk | 1 + > 1 file changed, 1 insertion(+) Applied to master, thanks. Thomas
diff --git a/package/pseudo/pseudo.mk b/package/pseudo/pseudo.mk index 67538a6..92de2c6 100644 --- a/package/pseudo/pseudo.mk +++ b/package/pseudo/pseudo.mk @@ -17,6 +17,7 @@ HOST_PSEUDO_DEPENDENCIES = host-attr host-sqlite # configure script is not generated by autoconf, so passing --libdir # is necessary, even if the infrastructure passes --prefix already. HOST_PSEUDO_CONF_OPTS = \ + --bits=$(if $(filter %64,$(HOSTARCH)),64,32) \ --libdir=$(HOST_DIR)/usr/lib \ --with-sqlite=$(HOST_DIR)/usr
pseudo can detect the host bitness, but is not sure about it: it checks what type of file /bin/sh is, using file(1). However, in some conditions, /bin/sh can be of a different bitness than the rest of the system (weird, but not impossible), which causes build issues. Just enforce the bitness, so that pseudo needs not (wrongly) guess it. Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr> Cc: Gaël PORTAY <gael.portay@savoirfairelinux.com> Cc: Patrick Keroulas <patrick.keroulas@savoirfairelinux.com> Cc: Erico Nunes <nunes.erico@gmail.com> Cc: Julien BOIBESSOT <julien.boibessot@free.fr> Cc: Arnout Vandecappelle <arnout@mind.be> --- Changes v1 -> v2: - directly extract bitness for $(HOSTARCH) (Arnout) --- package/pseudo/pseudo.mk | 1 + 1 file changed, 1 insertion(+)