| Message ID | 20161016170522.36074-1-Vincent.Riera@imgtec.com |
|---|---|
| State | Superseded |
| Headers | show |
Hi Vincent, On 16-10-16 19:05, Vicente Olivert Riera wrote: > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> > --- > toolchain/toolchain-wrapper.mk | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/toolchain/toolchain-wrapper.mk b/toolchain/toolchain-wrapper.mk > index af39071..6e480e6 100644 > --- a/toolchain/toolchain-wrapper.mk > +++ b/toolchain/toolchain-wrapper.mk > @@ -12,9 +12,14 @@ endif > TOOLCHAIN_WRAPPER_ARGS = $($(PKG)_TOOLCHAIN_WRAPPER_ARGS) > TOOLCHAIN_WRAPPER_ARGS += -DBR_SYSROOT='"$(STAGING_SUBDIR)"' > > +# MIPS optimization flags > +TOOLCHAIN_WRAPPER_MIPS_OPTS = This is not exactly what I meant, so I've sent a quick patch that does do what I meant. Wait a little for Thomas to provide feedback on it, and then you can include it in your series. For now I've marked the series as Superseded and Changes Requested. Regards, Arnout > + > # We create a list like '"-mfoo", "-mbar", "-mbarfoo"' so that each flag is a > # separate argument when used in execv() by the toolchain wrapper. > TOOLCHAIN_WRAPPER_OPTS = \ > + $(foreach f,$(call qstrip,$(TOOLCHAIN_WRAPPER_MIPS_OPTS)),"$(f)"$(comma)) > +TOOLCHAIN_WRAPPER_OPTS += \ > $(foreach f,$(call qstrip,$(BR2_TARGET_OPTIMIZATION)),"$(f)"$(comma)) > TOOLCHAIN_WRAPPER_ARGS += -DBR_ADDITIONAL_CFLAGS='$(TOOLCHAIN_WRAPPER_OPTS)' > >
Hello, On Tue, 18 Oct 2016 20:59:08 +0200, Arnout Vandecappelle wrote: > This is not exactly what I meant, so I've sent a quick patch that does do what > I meant. Wait a little for Thomas to provide feedback on it, and then you can > include it in your series. For now I've marked the series as Superseded and > Changes Requested. Only patches 1/7 and 2/7 were marked as Changes Requested or Superseded, but patches 3/7 to 7/7 were still in patchwork. So I've also marked them as Changes Requested, as they need to be resent with the rest. Vicente: for the next iteration, you can merge patches 3/7 to 7/7 in a single patch, like: mips: indicate which MIPS cores have MSA support Thanks, Thomas
diff --git a/toolchain/toolchain-wrapper.mk b/toolchain/toolchain-wrapper.mk index af39071..6e480e6 100644 --- a/toolchain/toolchain-wrapper.mk +++ b/toolchain/toolchain-wrapper.mk @@ -12,9 +12,14 @@ endif TOOLCHAIN_WRAPPER_ARGS = $($(PKG)_TOOLCHAIN_WRAPPER_ARGS) TOOLCHAIN_WRAPPER_ARGS += -DBR_SYSROOT='"$(STAGING_SUBDIR)"' +# MIPS optimization flags +TOOLCHAIN_WRAPPER_MIPS_OPTS = + # We create a list like '"-mfoo", "-mbar", "-mbarfoo"' so that each flag is a # separate argument when used in execv() by the toolchain wrapper. TOOLCHAIN_WRAPPER_OPTS = \ + $(foreach f,$(call qstrip,$(TOOLCHAIN_WRAPPER_MIPS_OPTS)),"$(f)"$(comma)) +TOOLCHAIN_WRAPPER_OPTS += \ $(foreach f,$(call qstrip,$(BR2_TARGET_OPTIMIZATION)),"$(f)"$(comma)) TOOLCHAIN_WRAPPER_ARGS += -DBR_ADDITIONAL_CFLAGS='$(TOOLCHAIN_WRAPPER_OPTS)'
Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com> --- toolchain/toolchain-wrapper.mk | 5 +++++ 1 file changed, 5 insertions(+)