| Message ID | 1476321239-13894-2-git-send-email-gustavo@zacarias.com.ar |
|---|---|
| State | Changes Requested |
| Headers | show |
Hello, On Wed, 12 Oct 2016 22:13:53 -0300, Gustavo Zacarias wrote: > This is required for the upcoming evince package. > > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> > --- > package/adwaita-icon-theme/adwaita-icon-theme.mk | 1 + > 1 file changed, 1 insertion(+) It feels a bit odd that evince needs icons in the staging directory. Could you improve the commit message a bit to explain why this is needed? Thanks! Thomas
On 16/10/16 13:15, Thomas Petazzoni wrote: > Hello, > > On Wed, 12 Oct 2016 22:13:53 -0300, Gustavo Zacarias wrote: >> This is required for the upcoming evince package. >> >> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> >> --- >> package/adwaita-icon-theme/adwaita-icon-theme.mk | 1 + >> 1 file changed, 1 insertion(+) > > It feels a bit odd that evince needs icons in the staging directory. > Could you improve the commit message a bit to explain why this is > needed? > > Thanks! > > Thomas Hi. It's actually very simple, evince checks for adwaita icons via pkgconfig, hence if they're not installed in staging they're not found. Should i resend the series or just this one? Regards.
On 17-10-16 12:08, Gustavo Zacarias wrote: > On 16/10/16 13:15, Thomas Petazzoni wrote: > >> Hello, >> >> On Wed, 12 Oct 2016 22:13:53 -0300, Gustavo Zacarias wrote: >>> This is required for the upcoming evince package. >>> >>> Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> >>> --- >>> package/adwaita-icon-theme/adwaita-icon-theme.mk | 1 + >>> 1 file changed, 1 insertion(+) >> >> It feels a bit odd that evince needs icons in the staging directory. >> Could you improve the commit message a bit to explain why this is >> needed? >> >> Thanks! >> >> Thomas > > Hi. > It's actually very simple, evince checks for adwaita icons via pkgconfig, hence > if they're not installed in staging they're not found. I indeed thought something like that, but then I thought: why bother installing everything to staging if only the .pc file is needed? However, it is staging, so we don't really care how much crap is in there, and we do prefer to use the upstream install commands. So OK for me. Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be> > Should i resend the series or just this one? Normally I'd say: the series. However, we're not going to accept python-libxml2. The idea is to bite the bullet and add Config.in.host entries for all host packages, so this type of problem can be properly resolved. We'll do that gradually. Python and python3 would be good to start with - although those are already pretty heavy, roughly 50 packages need to be updated to select BR2_PACKAGE_HOST_PYTHON{,3}). Regards, Arnout
diff --git a/package/adwaita-icon-theme/adwaita-icon-theme.mk b/package/adwaita-icon-theme/adwaita-icon-theme.mk index b9ec0c0..fdf66c8 100644 --- a/package/adwaita-icon-theme/adwaita-icon-theme.mk +++ b/package/adwaita-icon-theme/adwaita-icon-theme.mk @@ -8,6 +8,7 @@ ADWAITA_ICON_THEME_VERSION_MAJOR = 3.22 ADWAITA_ICON_THEME_VERSION = $(ADWAITA_ICON_THEME_VERSION_MAJOR).0 ADWAITA_ICON_THEME_SITE = http://ftp.gnome.org/pub/gnome/sources/adwaita-icon-theme/$(ADWAITA_ICON_THEME_VERSION_MAJOR) ADWAITA_ICON_THEME_SOURCE = adwaita-icon-theme-$(ADWAITA_ICON_THEME_VERSION).tar.xz +ADWAITA_ICON_THEME_INSTALL_STAGING = YES ADWAITA_ICON_THEME_LICENSE = LGPLv3 or CC-BY-SA-3.0 ADWAITA_ICON_THEME_LICENSE_FILES = COPYING COPYING_LGPL COPYING_CCBYSA3 ADWAITA_ICON_THEME_DEPENDENCIES = host-intltool host-libgtk3
This is required for the upcoming evince package. Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar> --- package/adwaita-icon-theme/adwaita-icon-theme.mk | 1 + 1 file changed, 1 insertion(+)