| Message ID | 1475452871-16982-6-git-send-email-sjg@chromium.org |
|---|---|
| State | Accepted |
| Commit | 1fb33434e37db722a9b1aef91aca6c4efc58303b |
| Delegated to: | Tom Rini |
| Headers | show |
Hi Simon, On Mon, Oct 3, 2016 at 8:01 AM, Simon Glass <sjg@chromium.org> wrote: > Drop a few that are not used in U-Boot. > > Signed-off-by: Simon Glass <sjg@chromium.org> > --- > > README | 20 -------------------- > include/configs/ls2080a_simu.h | 3 --- > 2 files changed, 23 deletions(-) > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Should we clean up scripts/config_whitelist.txt to remove these options too? Regards, Bin
On Sun, Oct 02, 2016 at 06:01:00PM -0600, Simon Glass wrote: > Drop a few that are not used in U-Boot. > > Signed-off-by: Simon Glass <sjg@chromium.org> > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Applied to u-boot/master, thanks!
Hi Bin, On 5 October 2016 at 00:11, Bin Meng <bmeng.cn@gmail.com> wrote: > > Hi Simon, > > On Mon, Oct 3, 2016 at 8:01 AM, Simon Glass <sjg@chromium.org> wrote: > > Drop a few that are not used in U-Boot. > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > --- > > > > README | 20 -------------------- > > include/configs/ls2080a_simu.h | 3 --- > > 2 files changed, 23 deletions(-) > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > Should we clean up scripts/config_whitelist.txt to remove these options too? Yes. The script should not include things that are only in the README, but in this case they were also in a header. Next time someone runs the build-whitelist.sh script they will go away. Regards, Simon
On Fri, Oct 07, 2016 at 01:30:31PM -0600, Simon Glass wrote: > Hi Bin, > > On 5 October 2016 at 00:11, Bin Meng <bmeng.cn@gmail.com> wrote: > > > > Hi Simon, > > > > On Mon, Oct 3, 2016 at 8:01 AM, Simon Glass <sjg@chromium.org> wrote: > > > Drop a few that are not used in U-Boot. > > > > > > Signed-off-by: Simon Glass <sjg@chromium.org> > > > --- > > > > > > README | 20 -------------------- > > > include/configs/ls2080a_simu.h | 3 --- > > > 2 files changed, 23 deletions(-) > > > > > > > Reviewed-by: Bin Meng <bmeng.cn@gmail.com> > > > > Should we clean up scripts/config_whitelist.txt to remove these options too? > > Yes. The script should not include things that are only in the README, > but in this case they were also in a header. Next time someone runs > the build-whitelist.sh script they will go away. And I'll probably do that "soon" along with a re-sync of the configs. I'm doing some conversions of stuff now.
diff --git a/README b/README index cdd58db..703c5f4 100644 --- a/README +++ b/README @@ -4805,10 +4805,6 @@ within that device. Specifies that QE/FMAN firmware is located on the primary SD/MMC device. CONFIG_SYS_FMAN_FW_ADDR is the byte offset on that device. -- CONFIG_SYS_QE_FMAN_FW_IN_SPIFLASH - Specifies that QE/FMAN firmware is located on the primary SPI - device. CONFIG_SYS_FMAN_FW_ADDR is the byte offset on that device. - - CONFIG_SYS_QE_FMAN_FW_IN_REMOTE Specifies that QE/FMAN firmware is located in the remote (master) memory space. CONFIG_SYS_FMAN_FW_ADDR is a virtual address which @@ -4827,22 +4823,6 @@ within that device. - CONFIG_FSL_MC_ENET Enable the MC driver for Layerscape SoCs. -- CONFIG_SYS_LS_MC_FW_ADDR - The address in the storage device where the firmware is located. The - meaning of this address depends on which CONFIG_SYS_LS_MC_FW_IN_xxx macro - is also specified. - -- CONFIG_SYS_LS_MC_FW_LENGTH - The maximum possible size of the firmware. The firmware binary format - has a field that specifies the actual size of the firmware, but it - might not be possible to read any part of the firmware unless some - local storage is allocated to hold the entire firmware first. - -- CONFIG_SYS_LS_MC_FW_IN_NOR - Specifies that MC firmware is located in NOR flash, mapped as - normal addressable memory via the LBC. CONFIG_SYS_LS_MC_FW_ADDR is the - virtual address in NOR flash. - Freescale Layerscape Debug Server Support: ------------------------------------------- The Freescale Layerscape Debug Server Support supports the loading of diff --git a/include/configs/ls2080a_simu.h b/include/configs/ls2080a_simu.h index 1851d41..f0ec6c4 100644 --- a/include/configs/ls2080a_simu.h +++ b/include/configs/ls2080a_simu.h @@ -146,9 +146,6 @@ #define CONFIG_SYS_DEBUG_SERVER_FW_ADDR 0x580C00000ULL /* MC firmware */ -#define CONFIG_SYS_LS_MC_FW_IN_NOR -#define CONFIG_SYS_LS_MC_FW_ADDR 0x580200000ULL - #define CONFIG_SYS_LS_MC_DPL_IN_NOR #define CONFIG_SYS_LS_MC_DPL_ADDR 0x5806C0000ULL
Drop a few that are not used in U-Boot. Signed-off-by: Simon Glass <sjg@chromium.org> --- README | 20 -------------------- include/configs/ls2080a_simu.h | 3 --- 2 files changed, 23 deletions(-)