| Message ID | 1474018609-2610-1-git-send-email-fpa@sbtaqua.com |
|---|---|
| State | Rejected |
| Headers | show |
Hello, On Fri, 16 Sep 2016 11:36:49 +0200, Frederik Aalund wrote: > -LIBFASTJSON_VERSION = v0.99.2 > +LIBFASTJSON_VERSION = 0.99.2 > LIBFASTJSON_SITE = $(call github,rsyslog,libfastjson,$(LIBFASTJSON_VERSION)) > +LIBFASTJSON_SOURCE = v$(LIBFASTJSON_VERSION).tar.gz This is not correct: the version is really v0.99.2, as this is the name of the Git tag. Moreover, I'm not sure what you're fixing here. It downloads perfectly fine here without your patch: >>> libfastjson v0.99.2 Downloading --2016-09-16 18:53:29-- https://github.com/rsyslog/libfastjson/archive/v0.99.2/libfastjson-v0.99.2.tar.gz Resolving github.com (github.com)... 192.30.253.113 Connecting to github.com (github.com)|192.30.253.113|:443... connected. HTTP request sent, awaiting response... 302 Found Location: https://codeload.github.com/rsyslog/libfastjson/tar.gz/v0.99.2 [following] --2016-09-16 18:53:36-- https://codeload.github.com/rsyslog/libfastjson/tar.gz/v0.99.2 Resolving codeload.github.com (codeload.github.com)... 192.30.253.121 Connecting to codeload.github.com (codeload.github.com)|192.30.253.121|:443... connected. HTTP request sent, awaiting response... 200 OK Length: unspecified [application/x-gzip] Saving to: ‘/home/thomas/projets/buildroot/output/build/.libfastjson-v0.99.2.tar.gz.PKe11m/output’ 0K .......... .......... .......... .......... .......... 80,8K 50K .......... .......... .......... ..... 118K=0,9s 2016-09-16 18:53:38 (92,9 KB/s) - ‘/home/thomas/projets/buildroot/output/build/.libfastjson-v0.99.2.tar.gz.PKe11m/output’ saved [87526] libfastjson-v0.99.2.tar.gz: OK (sha256: fcdca0c4702362de3db3f02c8da05f985b54a9eccd618af41730409b75d10a8f) Could you be more specific in the issue you were facing, such as posting a build log of what happens during the download without your patch applied? Thanks! Thomas
Hi Thomas Thanks for reviewing! Strange that it builds without problems at your end. Here is what I see from the build log (without the patch): --2016-09-20 15:22:21-- https://github.com/rsyslog/libfastjson/archive/v0.99.2.tar.gz Resolving github.com (github.com)... 192.30.253.113 Connecting to github.com (github.com)|192.30.253.113|:443... connected. HTTP request sent, awaiting response... 302 Found Location: https://codeload.github.com/rsyslog/libfastjson/tar.gz/v0.99.2 [following] --2016-09-20 15:22:22-- https://codeload.github.com/rsyslog/libfastjson/tar.gz/v0.99.2 Resolving codeload.github.com (codeload.github.com)... 192.30.253.121 Connecting to codeload.github.com (codeload.github.com)|192.30.253.121|:443... connected. HTTP request sent, awaiting response... 200 OK Length: unspecified [application/x-gzip] Saving to: ‘/projects/RedPitaya/OS/buildroot/buildroot/output/build/.v0.99.2.tar.gz.eTu6lt/output’ /projects/RedPitaya/OS/bui [ <=> ] 85.47K 424KB/s in 0.2s 2016-09-20 15:22:23 (424 KB/s) - ‘/projects/RedPitaya/OS/buildroot/buildroot/output/build/.v0.99.2.tar.gz.eTu6lt/output’ saved [87526] ERROR: No hash found for v0.99.2.tar.gz --2016-09-20 15:22:23-- http://sources.buildroot.net/v0.99.2.tar.gz Resolving sources.buildroot.net (sources.buildroot.net)... 176.9.16.109 Connecting to sources.buildroot.net (sources.buildroot.net)|176.9.16.109|:80... connected. HTTP request sent, awaiting response... 404 Not Found 2016-09-20 15:22:23 ERROR 404: Not Found. package/pkg-generic.mk:113: recipe for target '/projects/RedPitaya/OS/buildroot/buildroot/output/build/libfastjson-v0.99.2/.stamp_downloaded' failed make[1]: *** [/projects/RedPitaya/OS/buildroot/buildroot/output/build/libfastjson-v0.99.2/.stamp_downloaded] Error 1 Makefile:41: recipe for target '_all' failed make: *** [_all] Error 2 I see that your package URL: --2016-09-16 18:53:29-- https://github.com/rsyslog/libfastjson/archive/v0.99.2/libfastjson-v0.99.2.tar.gz is different from mine: --2016-09-20 15:22:21-- https://github.com/rsyslog/libfastjson/archive/v0.99.2.tar.gz I don't know how that can be. At some point, I had an external package for libfastjson (before it was integrated into buildroot). However, I have deleted said external package and purged both buildroot/dl and buildroot/output/build. *Frederik Aalund* Chief Information Officer, Co-owner SBT Aqua Copenhagen, Denmark Mobile: +45 30340086 fpa@sbtaqua.com sbtaqua.com On Fri, 16 Sep 2016 at 18:56 Thomas Petazzoni < thomas.petazzoni@free-electrons.com> wrote: > Hello, > > On Fri, 16 Sep 2016 11:36:49 +0200, Frederik Aalund wrote: > > > -LIBFASTJSON_VERSION = v0.99.2 > > +LIBFASTJSON_VERSION = 0.99.2 > > LIBFASTJSON_SITE = $(call > github,rsyslog,libfastjson,$(LIBFASTJSON_VERSION)) > > +LIBFASTJSON_SOURCE = v$(LIBFASTJSON_VERSION).tar.gz > > This is not correct: the version is really v0.99.2, as this is the name > of the Git tag. > > Moreover, I'm not sure what you're fixing here. It downloads perfectly > fine here without your patch: > > >>> libfastjson v0.99.2 Downloading > --2016-09-16 18:53:29-- > https://github.com/rsyslog/libfastjson/archive/v0.99.2/libfastjson-v0.99.2.tar.gz > Resolving github.com (github.com)... 192.30.253.113 > Connecting to github.com (github.com)|192.30.253.113|:443... connected. > HTTP request sent, awaiting response... 302 Found > Location: https://codeload.github.com/rsyslog/libfastjson/tar.gz/v0.99.2 > [following] > --2016-09-16 18:53:36-- > https://codeload.github.com/rsyslog/libfastjson/tar.gz/v0.99.2 > Resolving codeload.github.com (codeload.github.com)... 192.30.253.121 > Connecting to codeload.github.com (codeload.github.com)|192.30.253.121|:443... > connected. > HTTP request sent, awaiting response... 200 OK > Length: unspecified [application/x-gzip] > Saving to: > ‘/home/thomas/projets/buildroot/output/build/.libfastjson-v0.99.2.tar.gz.PKe11m/output’ > > 0K .......... .......... .......... .......... .......... 80,8K > 50K .......... .......... .......... ..... 118K=0,9s > > 2016-09-16 18:53:38 (92,9 KB/s) - > ‘/home/thomas/projets/buildroot/output/build/.libfastjson-v0.99.2.tar.gz.PKe11m/output’ > saved [87526] > > libfastjson-v0.99.2.tar.gz: OK (sha256: > fcdca0c4702362de3db3f02c8da05f985b54a9eccd618af41730409b75d10a8f) > > Could you be more specific in the issue you were facing, such as > posting a build log of what happens during the download without your > patch applied? > > Thanks! > > Thomas > -- > Thomas Petazzoni, CTO, Free Electrons > Embedded Linux and Kernel engineering > http://free-electrons.com >
>>>>> "Frederik" == Frederik Peter Aalund <fpa@sbtaqua.com> writes: > Hi Thomas > Thanks for reviewing! Strange that it builds without problems at your end. > Here is what I see from the build log (without the patch): > I see that your package URL: > --2016-09-16 18:53:29-- > https://github.com/rsyslog/libfastjson/archive/v0.99.2/libfastjson-v0.99.2.tar.gz > is different from mine: > --2016-09-20 15:22:21-- > https://github.com/rsyslog/libfastjson/archive/v0.99.2.tar.gz > I don't know how that can be. At some point, I had an external package for > libfastjson (before it was integrated into buildroot). However, I have > deleted said external package and purged both buildroot/dl and > buildroot/output/build. <pkgname>-<version>.tar.gz is the default name of the tarball, so it sounds like you have a LIBFASTJSON_SOURCE = .. somewhere - Please double check. Notice that buildroot automatically includes */*.mk, so it will get read even though you have dropped the Config.in file. > *Frederik Aalund* > Chief Information Officer, Co-owner > SBT Aqua > Copenhagen, Denmark > Mobile: +45 30340086 > fpa@sbtaqua.com > sbtaqua.com Nice, so you are using Buildroot on the sensors?
Hi Peter > <pkgname>-<version>.tar.gz is the default name of the tarball, so it > sounds like you have a LIBFASTJSON_SOURCE = .. somewhere - Please double > check. That must have been the culprit. Even though I deleted the external libfastjson.mk file, the value of LIBFASTJSON_SOURCE must still have been cached somewhere. There were no errors after i purged the entire buildroot folder. Thanks for investigating. > Nice, so you are using Buildroot on the sensors? Yes, and I'm really liking it so far. `make legal-info` in particular is very handy when aggregating programs in a distribution. *Frederik Aalund* Chief Information Officer, Co-owner SBT Aqua Copenhagen, Denmark Mobile: +45 30340086 fpa@sbtaqua.com sbtaqua.com On Tue, 20 Sep 2016 at 16:33 Peter Korsgaard <peter@korsgaard.com> wrote: > >>>>> "Frederik" == Frederik Peter Aalund <fpa@sbtaqua.com> writes: > > > Hi Thomas > > Thanks for reviewing! Strange that it builds without problems at your > end. > > Here is what I see from the build log (without the patch): > > > I see that your package URL: > > --2016-09-16 18:53:29-- > > > https://github.com/rsyslog/libfastjson/archive/v0.99.2/libfastjson-v0.99.2.tar.gz > > > is different from mine: > > --2016-09-20 15:22:21-- > > https://github.com/rsyslog/libfastjson/archive/v0.99.2.tar.gz > > > I don't know how that can be. At some point, I had an external package > for > > libfastjson (before it was integrated into buildroot). However, I have > > deleted said external package and purged both buildroot/dl and > > buildroot/output/build. > > <pkgname>-<version>.tar.gz is the default name of the tarball, so it > sounds like you have a LIBFASTJSON_SOURCE = .. somewhere - Please double > check. Notice that buildroot automatically includes */*.mk, so it will > get read even though you have dropped the Config.in file. > > > *Frederik Aalund* > > Chief Information Officer, Co-owner > > > SBT Aqua > > Copenhagen, Denmark > > Mobile: +45 30340086 > > fpa@sbtaqua.com > > sbtaqua.com > > Nice, so you are using Buildroot on the sensors? > > -- > Bye, Peter Korsgaard >
Hello, On Wed, 21 Sep 2016 08:44:23 +0000, Frederik Peter Aalund wrote: > > <pkgname>-<version>.tar.gz is the default name of the tarball, so it > > sounds like you have a LIBFASTJSON_SOURCE = .. somewhere - Please double > > check. > > That must have been the culprit. Even though I deleted the external > libfastjson.mk file, > the value of LIBFASTJSON_SOURCE must still have been cached somewhere. There > were no errors after i purged the entire buildroot folder. Thanks for > investigating. There is no cache anywhere in Buildroot for such variables. So it must have been *defined* somewhere explicitly, due to a modification you had done. > > Nice, so you are using Buildroot on the sensors? > > Yes, and I'm really liking it so far. `make legal-info` in particular is > very handy when aggregating programs in a distribution. Glad to hear this is a useful functionality! Best regards, Thomas
diff --git a/package/libfastjson/libfastjson.hash b/package/libfastjson/libfastjson.hash index 8531dac..7089c3d 100644 --- a/package/libfastjson/libfastjson.hash +++ b/package/libfastjson/libfastjson.hash @@ -1,2 +1,2 @@ # Locally calculated -sha256 fcdca0c4702362de3db3f02c8da05f985b54a9eccd618af41730409b75d10a8f libfastjson-v0.99.2.tar.gz +sha256 fcdca0c4702362de3db3f02c8da05f985b54a9eccd618af41730409b75d10a8f v0.99.2.tar.gz diff --git a/package/libfastjson/libfastjson.mk b/package/libfastjson/libfastjson.mk index ec5390c..80e389f 100644 --- a/package/libfastjson/libfastjson.mk +++ b/package/libfastjson/libfastjson.mk @@ -4,8 +4,9 @@ # ################################################################################ -LIBFASTJSON_VERSION = v0.99.2 +LIBFASTJSON_VERSION = 0.99.2 LIBFASTJSON_SITE = $(call github,rsyslog,libfastjson,$(LIBFASTJSON_VERSION)) +LIBFASTJSON_SOURCE = v$(LIBFASTJSON_VERSION).tar.gz LIBFASTJSON_INSTALL_STAGING = YES # From git LIBFASTJSON_AUTORECONF = YES
Both the .hash and the .mk file was referencing non-existing files. This caused the build to fail. I've made both files point to the correct file names. Signed-off-by: Frederik Aalund <fpa@sbtaqua.com> --- package/libfastjson/libfastjson.hash | 2 +- package/libfastjson/libfastjson.mk | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-)