diff mbox

supertuxkart: Constrain to x86 architecture

Message ID 20160901194429.11761-1-ezequiel@vanguardiasur.com.ar
State Superseded
Headers show

Commit Message

Ezequiel Garcia Sept. 1, 2016, 7:44 p.m. UTC
Our build system has detected that angelscript can't be
cross-compiled properly. This has been also reported to
supertuxkart [1], and although the developers were open
to take patches fixing STK embedded angelscript, it was
pointed out that non-x86 architectures were not officially
supported and of little interest [2].

Hence, let's constrain the package selection to x86.

[1] https://github.com/supertuxkart/stk-code/issues/2569
[2] https://github.com/supertuxkart/stk-code/pull/2195

Fixes: http://autobuild.buildroot.net/results/655/655f046b3bb5f7a4ea492328b608e409d6769689/
Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
---
 package/supertuxkart/Config.in | 2 ++
 1 file changed, 2 insertions(+)

Comments

Thomas Petazzoni Sept. 2, 2016, 12:36 p.m. UTC | #1
Hello,

On Thu,  1 Sep 2016 16:44:29 -0300, Ezequiel Garcia wrote:
> Our build system has detected that angelscript can't be
> cross-compiled properly. This has been also reported to
> supertuxkart [1], and although the developers were open
> to take patches fixing STK embedded angelscript, it was
> pointed out that non-x86 architectures were not officially
> supported and of little interest [2].

If it's indeed that angelscript doesn't cross-compile properly, then,
it also needs to be limited to x86/x86_64 as the host compiler, no?

I.e: what happens if I'm using Buildroot on a PowerPC or ARM machine?

Best regards,

Thomas
Ezequiel Garcia Sept. 2, 2016, 2:21 p.m. UTC | #2
On 2 September 2016 at 09:36, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello,
>
> On Thu,  1 Sep 2016 16:44:29 -0300, Ezequiel Garcia wrote:
>> Our build system has detected that angelscript can't be
>> cross-compiled properly. This has been also reported to
>> supertuxkart [1], and although the developers were open
>> to take patches fixing STK embedded angelscript, it was
>> pointed out that non-x86 architectures were not officially
>> supported and of little interest [2].
>
> If it's indeed that angelscript doesn't cross-compile properly, then,
> it also needs to be limited to x86/x86_64 as the host compiler, no?
>
> I.e: what happens if I'm using Buildroot on a PowerPC or ARM machine?
>

Totally right. I just sent a v2.

Thanks,
diff mbox

Patch

diff --git a/package/supertuxkart/Config.in b/package/supertuxkart/Config.in
index a1f7074eb78f..9a8eabe2b611 100644
--- a/package/supertuxkart/Config.in
+++ b/package/supertuxkart/Config.in
@@ -1,5 +1,6 @@ 
 config BR2_PACKAGE_SUPERTUXKART
 	bool "supertuxkart"
+	depends on BR2_i386 || BR2_x86_64
 	depends on BR2_USE_MMU # fork()
 	depends on BR2_INSTALL_LIBSTDCPP # openal
 	depends on BR2_TOOLCHAIN_HAS_THREADS_NPTL # openal
@@ -25,6 +26,7 @@  config BR2_PACKAGE_SUPERTUXKART
 	  http://supertuxkart.sourceforge.net/Main_Page
 
 comment "supertuxkart needs an OpenGL backend, a uClibc or glibc toolchain w/ NPTL, C++"
+	depends on BR2_i386 || BR2_x86_64
 	depends on BR2_USE_MMU
 	depends on BR2_PACKAGE_OPENAL_ARCH_SUPPORTS
 	depends on BR2_PACKAGE_XORG7