diff mbox

[PATCHv2/next,4/4] docs/manual: add new section about the DEVELOPERS file and get-developer

Message ID 1471956466-22338-5-git-send-email-thomas.petazzoni@free-electrons.com
State Superseded
Headers show

Commit Message

Thomas Petazzoni Aug. 23, 2016, 12:47 p.m. UTC
Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 docs/manual/developers.txt | 45 +++++++++++++++++++++++++++++++++++++++++++++
 docs/manual/manual.txt     |  2 ++
 2 files changed, 47 insertions(+)
 create mode 100644 docs/manual/developers.txt

Comments

Arnout Vandecappelle Aug. 24, 2016, 12:21 a.m. UTC | #1
On 23-08-16 14:47, Thomas Petazzoni wrote:
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  docs/manual/developers.txt | 45 +++++++++++++++++++++++++++++++++++++++++++++
>  docs/manual/manual.txt     |  2 ++
>  2 files changed, 47 insertions(+)
>  create mode 100644 docs/manual/developers.txt
> 
> diff --git a/docs/manual/developers.txt b/docs/manual/developers.txt
> new file mode 100644
> index 0000000..e4c1d88
> --- /dev/null
> +++ b/docs/manual/developers.txt
> @@ -0,0 +1,45 @@
> +// -*- mode:doc; -*-
> +// vim: set syntax=asciidoc:
> +
> +== DEVELOPERS file and get-developers
> +
> +The main Buildroot directory contains a file named +DEVELOPERS+ that
> +list the developers in charge of various areas of Buildroot. Thanks to
> +this file, the +get-developer+ tool allows to:
> +
> +- Calculate the list of developers to whom patches should be sent, by
> +  parsing the patches and matching the modified files with the
> +  relevant developers. See xref:submitting-patches[] for details.
> +
> +- Find which developers are in charge of a given architecture or
> +  package, so that they can be notified when a build failure occurs on
> +  this architecture or package. This is done in interaction with
> +  Buildroot's autobuild infrastructure.
> +
> +We ask developers adding new packages, new boards, or generally new
> +functionality in Buildroot, to register themselves in the +DEVELOPERS+
> +file. As an example, we expect a developer contributing a new package
> +to include in his patch the appropriate modification to the
> ++DEVELOPERS+ file.

 As I hinted in my reply to patch 2, I would also add this message to the end of
the "The formatting of a patch" section in contribute.txt. Something like:

If you are interested in getting notified of build failures and of further
changes in the packages you modified, please add yourself to the DEVELOPERS
file. This should be done in a separate patch of the series. See
xref:DEVELOPERS[the DEVELOPERS file] for more information.

(and add [[DEVELOPERS]] to the developers section).


 Regards,
 Arnout


> +
> +The +DEVELOPERS+ file format is documented in detail inside the file
> +itself.
> +
> +The +get-developer+ tool, located in +support/scripts+ allows to use
> +the +DEVELOPERS+ file for various tasks:
> +
> +- When passing one or several patches as command line argument,
> +  +get-developer+ will return the appropriate +git send-email+
> +  command.
> +
> +- When using the +-a <arch>+ command line option, +get-developer+ will
> +  return the list of developers in charge of the given architecture.
> +
> +- When using the +-p <package>+ command line option, +get-developer+
> +  will return the list of developers in charge of the given package.
> +
> +- When using the +-c+ command line option, +get-developer+ will look
> +  at all files under version control in the Buildroot repository, and
> +  list the ones that are not handled by any developer. The purpose of
> +  this option is to help completing the +DEVELOPERS+ file.
> +
> diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt
> index 3c531e3..7630ea6 100644
> --- a/docs/manual/manual.txt
> +++ b/docs/manual/manual.txt
> @@ -64,6 +64,8 @@ include::debugging-buildroot.txt[]
>  
>  include::contribute.txt[]
>  
> +include::developers.txt[]
> +
>  = Appendix
>  
>  include::appendix.txt[]
>
Thomas Petazzoni Aug. 24, 2016, 2:22 p.m. UTC | #2
Hello,

On Wed, 24 Aug 2016 02:21:44 +0200, Arnout Vandecappelle wrote:

>  As I hinted in my reply to patch 2, I would also add this message to the end of
> the "The formatting of a patch" section in contribute.txt. Something like:
> 
> If you are interested in getting notified of build failures and of further
> changes in the packages you modified, please add yourself to the DEVELOPERS
> file. This should be done in a separate patch of the series. See
> xref:DEVELOPERS[the DEVELOPERS file] for more information.
> 
> (and add [[DEVELOPERS]] to the developers section).

Thanks for the suggestion, added.

While adding this, I noted that the references like:

   xref:label[some description]

are not rendered just has "some description" in the HTML, but as:

  "some description <the title of the section pointed to>"

For example, for:

  Before reporting any issue, please check in xref:community-resources[the mailing list archive] whether someone has

you get:

  Before reporting any issue, please check in the mailing list archive Chapter 5, Community resources whether someone has

which is not very pretty.

Maybe someone with AsciiDoc knowledge can look into this?

Thomas
diff mbox

Patch

diff --git a/docs/manual/developers.txt b/docs/manual/developers.txt
new file mode 100644
index 0000000..e4c1d88
--- /dev/null
+++ b/docs/manual/developers.txt
@@ -0,0 +1,45 @@ 
+// -*- mode:doc; -*-
+// vim: set syntax=asciidoc:
+
+== DEVELOPERS file and get-developers
+
+The main Buildroot directory contains a file named +DEVELOPERS+ that
+list the developers in charge of various areas of Buildroot. Thanks to
+this file, the +get-developer+ tool allows to:
+
+- Calculate the list of developers to whom patches should be sent, by
+  parsing the patches and matching the modified files with the
+  relevant developers. See xref:submitting-patches[] for details.
+
+- Find which developers are in charge of a given architecture or
+  package, so that they can be notified when a build failure occurs on
+  this architecture or package. This is done in interaction with
+  Buildroot's autobuild infrastructure.
+
+We ask developers adding new packages, new boards, or generally new
+functionality in Buildroot, to register themselves in the +DEVELOPERS+
+file. As an example, we expect a developer contributing a new package
+to include in his patch the appropriate modification to the
++DEVELOPERS+ file.
+
+The +DEVELOPERS+ file format is documented in detail inside the file
+itself.
+
+The +get-developer+ tool, located in +support/scripts+ allows to use
+the +DEVELOPERS+ file for various tasks:
+
+- When passing one or several patches as command line argument,
+  +get-developer+ will return the appropriate +git send-email+
+  command.
+
+- When using the +-a <arch>+ command line option, +get-developer+ will
+  return the list of developers in charge of the given architecture.
+
+- When using the +-p <package>+ command line option, +get-developer+
+  will return the list of developers in charge of the given package.
+
+- When using the +-c+ command line option, +get-developer+ will look
+  at all files under version control in the Buildroot repository, and
+  list the ones that are not handled by any developer. The purpose of
+  this option is to help completing the +DEVELOPERS+ file.
+
diff --git a/docs/manual/manual.txt b/docs/manual/manual.txt
index 3c531e3..7630ea6 100644
--- a/docs/manual/manual.txt
+++ b/docs/manual/manual.txt
@@ -64,6 +64,8 @@  include::debugging-buildroot.txt[]
 
 include::contribute.txt[]
 
+include::developers.txt[]
+
 = Appendix
 
 include::appendix.txt[]