| Message ID | 1471544678-12514-1-git-send-email-rahul.bedarkar@imgtec.com |
|---|---|
| State | Accepted |
| Headers | show |
Hello, On Thu, 18 Aug 2016 23:54:37 +0530, Rahul Bedarkar wrote: > Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com> > --- > package/libconfuse/Config.in | 1 + > package/libconfuse/libconfuse.mk | 4 ++++ > 2 files changed, 5 insertions(+) > > diff --git a/package/libconfuse/Config.in b/package/libconfuse/Config.in > index be18cbb..7dedd83 100644 > --- a/package/libconfuse/Config.in > +++ b/package/libconfuse/Config.in > @@ -1,5 +1,6 @@ > config BR2_PACKAGE_LIBCONFUSE > bool "libconfuse" > + select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE This was not correct: libconfuse does not *require* gettext, even if locale support is enabled. It can work fine without it. However, if it's available, it uses it. So I've changed your patch to just: ifeq ($(BR2_PACKAGE_GETTEXT),y) LIBCONFUSE_DEPENDENCIES += gettext endif which ensures that *if* gettext has been enabled in the configuration, it will be built before libconfuse. Thanks! Thomas
diff --git a/package/libconfuse/Config.in b/package/libconfuse/Config.in index be18cbb..7dedd83 100644 --- a/package/libconfuse/Config.in +++ b/package/libconfuse/Config.in @@ -1,5 +1,6 @@ config BR2_PACKAGE_LIBCONFUSE bool "libconfuse" + select BR2_PACKAGE_GETTEXT if BR2_NEEDS_GETTEXT_IF_LOCALE help LibConfuse is a configuration file parser library written in C. It supports sections and (lists of) values (strings, diff --git a/package/libconfuse/libconfuse.mk b/package/libconfuse/libconfuse.mk index fea90f1..e289798 100644 --- a/package/libconfuse/libconfuse.mk +++ b/package/libconfuse/libconfuse.mk @@ -14,5 +14,9 @@ HOST_LIBCONFUSE_DEPENDENCIES = host-flex LIBCONFUSE_LICENSE = ISC LIBCONFUSE_LICENSE_FILES = LICENSE +ifeq ($(BR2_NEEDS_GETTEXT_IF_LOCALE),y) +LIBCONFUSE_DEPENDENCIES += gettext +endif + $(eval $(autotools-package)) $(eval $(host-autotools-package))
Signed-off-by: Rahul Bedarkar <rahul.bedarkar@imgtec.com> --- package/libconfuse/Config.in | 1 + package/libconfuse/libconfuse.mk | 4 ++++ 2 files changed, 5 insertions(+)