diff mbox

[1/2] blktrace: add missing dependency on Config.in comment

Message ID 1470521474-16710-1-git-send-email-thomas.petazzoni@free-electrons.com
State Accepted
Headers show

Commit Message

Thomas Petazzoni Aug. 6, 2016, 10:11 p.m. UTC 
The BR2_PACKAGE_BLKTRACE option "depends on
BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS", but this architecture dependency was
not replicated in the Config.in comment. This commit fixes this
inconsistency.

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
---
 package/blktrace/Config.in | 1 +
 1 file changed, 1 insertion(+)

Comments

Yann E. MORIN Aug. 7, 2016, 8:04 p.m. UTC | #1 
Thomas, All,

On 2016-08-07 00:11 +0200, Thomas Petazzoni spake thusly:
> The BR2_PACKAGE_BLKTRACE option "depends on
> BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS", but this architecture dependency was
> not replicated in the Config.in comment. This commit fixes this
> inconsistency.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>

Acked-by: "Yann E. MORIN" <yann.morin.1998@free.fr>

Regards,
Yann E. MORIN.

> ---
>  package/blktrace/Config.in | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/package/blktrace/Config.in b/package/blktrace/Config.in
> index 958f004..c17de80 100644
> --- a/package/blktrace/Config.in
> +++ b/package/blktrace/Config.in
> @@ -12,4 +12,5 @@ config BR2_PACKAGE_BLKTRACE
>  	  http://git.kernel.dk/?p=blktrace.git;a=summary
>  
>  comment "blktrace needs a glibc or musl toolchain"
> +	depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
>  	depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL)
> -- 
> 2.7.4
> 
> _______________________________________________
> buildroot mailing list
> buildroot@busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Thomas Petazzoni Aug. 7, 2016, 8:59 p.m. UTC | #2 
Hello,

On Sun,  7 Aug 2016 00:11:13 +0200, Thomas Petazzoni wrote:
> The BR2_PACKAGE_BLKTRACE option "depends on
> BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS", but this architecture dependency was
> not replicated in the Config.in comment. This commit fixes this
> inconsistency.
> 
> Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
> ---
>  package/blktrace/Config.in | 1 +
>  1 file changed, 1 insertion(+)

Both applied.

Thomas
diff mbox

Patch

diff --git a/package/blktrace/Config.in b/package/blktrace/Config.in
index 958f004..c17de80 100644
--- a/package/blktrace/Config.in
+++ b/package/blktrace/Config.in
@@ -12,4 +12,5 @@  config BR2_PACKAGE_BLKTRACE
 	  http://git.kernel.dk/?p=blktrace.git;a=summary
 
 comment "blktrace needs a glibc or musl toolchain"
+	depends on BR2_PACKAGE_LIBAIO_ARCH_SUPPORTS
 	depends on !(BR2_TOOLCHAIN_USES_GLIBC || BR2_TOOLCHAIN_USES_MUSL)