diff mbox

[1/1] shellinabox - Patch to support latest buildroot environment

Message ID 1470186853-21468-1-git-send-email-olivier.singla@gmail.com
State Superseded
Headers show

Commit Message

Olivier Singla Aug. 3, 2016, 1:14 a.m. UTC
From: Olivier <osingla@localhost.localdomain>

Signed-off-by: Olivier <osingla@localhost.localdomain>
---
 .../0002-launcher.c-fix-ttydef-utmpx.patch         | 28 ++++++++++++++++++++++
 1 file changed, 28 insertions(+)
 create mode 100644 package/shellinabox/0002-launcher.c-fix-ttydef-utmpx.patch

Comments

Thomas Petazzoni Aug. 3, 2016, 10:21 a.m. UTC | #1
Hello,

On Tue,  2 Aug 2016 21:14:13 -0400, Olivier Singla wrote:
> From: Olivier <osingla@localhost.localdomain>
> 
> Signed-off-by: Olivier <osingla@localhost.localdomain>

This From and Signed-off-by look wrong.

Also, could you explain which problem this patch is fixing? If it's
fixing an autobuilder issue, you should have a reference like this:

"""
Fixes:

   http://autobuild.buildroot.net/results/1078c7c3a8ec7a52db567514b06ef1a05d07194d/
"""

Thanks!

Thomas
diff mbox

Patch

diff --git a/package/shellinabox/0002-launcher.c-fix-ttydef-utmpx.patch b/package/shellinabox/0002-launcher.c-fix-ttydef-utmpx.patch
new file mode 100644
index 0000000..54cb699
--- /dev/null
+++ b/package/shellinabox/0002-launcher.c-fix-ttydef-utmpx.patch
@@ -0,0 +1,28 @@ 
+launcher.c: added include to <sys/ttydefaults.h> to avoid missing definitions
+launcher.c: do not include utmpx.h (since ptsname_r is already defined in stdlib.h)
+
+Signed-off-by:  "Olivier Singla" <olivier.singla@gmail.com>
+
+--- shellinabox-v2.19/shellinabox/launcher.c.orig	2016-08-01 18:43:01.628002777 -0400
++++ shellinabox-v2.19/shellinabox/launcher.c	2016-08-01 18:45:14.943444066 -0400
+@@ -81,6 +81,10 @@
+ #include <sys/uio.h>
+ #endif
+ 
++#ifndef TTYDEF_IFLAG
++#include <sys/ttydefaults.h>
++#endif
++
+ #ifdef HAVE_UTIL_H
+ #include <util.h>
+ #endif
+@@ -90,7 +94,8 @@
+ #endif
+ 
+ #ifdef HAVE_UTMPX_H
+-#include <utmpx.h>
++//#include <utmpx.h>
++#undef HAVE_UTMPX_H
+ #endif
+ 
+ #if defined(HAVE_SECURITY_PAM_APPL_H)